Globally autoblock the user's IP address when User::spreadAnyEditBlock is called
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Dreamy_Jazz
	Sep 16 2024, 3:02 PM

Description

In T374857, a hook was added that allows extensions to spread any extension-specific blocks. This hook should be implemented by GlobalBlocking to autoblock the IP address used by the user if the user is blocked with a block that enables global autoblocks.

Acceptance criteria

When User::spreadAnyEditBlock is called, any relevant GlobalBlocking block is spread via an autoblock on the user's IP address

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Spread global blocks on SpreadAnyEditBlock	mediawiki/extensions/GlobalBlocking	master	+168 -27
	Correct documentation of GlobalBlock::getId	mediawiki/extensions/GlobalBlocking	master	+5 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
		Restricted Task
Resolved	kostajh	T294511 2021 Security Team wikireplicas audit
Declined	None	T284948 Raw IPs of logged-out users disclosed in wiki-replicas
Resolved	Niharika	T324492 Temporary accounts - MVP
Resolved	Madalina	T326816 [Epic] Update features for temporary accounts
Open	None	T355286 [Epic] Globally blocking a temporary account should prevent further account creations
Resolved	Dreamy_Jazz	T368949 [Epic] Implement global autoblocks from global user blocks
Resolved	Dreamy_Jazz	T374859 Globally autoblock the user's IP address when User::spreadAnyEditBlock is called
Resolved	Dreamy_Jazz	T374857 Call a hook in User::spreadAnyEditBlock to allow extensions to also spread relevant blocks
Resolved	Dreamy_Jazz	T374853 Update the GlobalBlockManager service to support global autoblocks
Resolved	Dreamy_Jazz	T374850 Add hook to get IPs to retroactively globally auto block
Declined	Dreamy_Jazz	T374855 Hide the value of gbw_address in the public replicas if the associated globalblocks table row has gb_autoblock_parent_id as not null
Resolved	fnegri	T371486 Hide the value of gb_address column in public replicas if gb_autoblock_parent_id is not null
Resolved	fnegri	T375760 update-views cookbook doesn't handle filters correctly
Resolved	Dreamy_Jazz	T374854 Update the GlobalBlockLookup service to support reading and applying global autoblocks

Event Timeline

Dreamy_Jazz created this task.Sep 16 2024, 3:02 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 16 2024, 3:02 PM

Dreamy_Jazz added a subtask: T374857: Call a hook in User::spreadAnyEditBlock to allow extensions to also spread relevant blocks.Sep 16 2024, 3:02 PM

Dreamy_Jazz added a subtask: T374853: Update the GlobalBlockManager service to support global autoblocks.

Dreamy_Jazz added a subtask: T374854: Update the GlobalBlockLookup service to support reading and applying global autoblocks.Sep 16 2024, 3:05 PM

kostajh moved this task from Backlog to In progress on the Temporary accounts (Blockers to minor pilot wiki deployment) board.Sep 24 2024, 8:35 AM

kostajh closed subtask T374857: Call a hook in User::spreadAnyEditBlock to allow extensions to also spread relevant blocks as Resolved.Sep 24 2024, 11:41 AM

kostajh moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)) board.Oct 8 2024, 10:22 AM

Dreamy_Jazz moved this task from Sprint Beatboxing (Sept 16-27) to Sprint Cello (Oct 7 - 18) on the Trust and Safety Product Sprint board.Oct 8 2024, 10:29 AM

Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)); removed Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)).

Dreamy_Jazz moved this task from Priority Backlog to Ready on the Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)) board.

Change #1078724 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] [WIP] Spread global blocks on SpreadAnyEditBlock

https://gerrit.wikimedia.org/r/1078724

gerritbot added a project: Patch-For-Review.Oct 8 2024, 6:25 PM

Dreamy_Jazz moved this task from Ready to In Progress on the Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)) board.Oct 8 2024, 6:26 PM

Dreamy_Jazz closed subtask T374854: Update the GlobalBlockLookup service to support reading and applying global autoblocks as Resolved.Oct 10 2024, 1:57 PM

Change #1079327 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Correct documentation of GlobalBlock::getId

https://gerrit.wikimedia.org/r/1079327

Change #1079327 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Correct documentation of GlobalBlock::getId

https://gerrit.wikimedia.org/r/1079327

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.27; 2024-10-15).Oct 10 2024, 6:00 PM

Dreamy_Jazz moved this task from In Progress to Needs review on the Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)) board.Oct 10 2024, 8:29 PM

Change #1078724 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Spread global blocks on SpreadAnyEditBlock

https://gerrit.wikimedia.org/r/1078724

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.28; 2024-10-22); removed MW-1.43-notes (1.43.0-wmf.27; 2024-10-15).Oct 16 2024, 2:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 16 2024, 2:31 PM

Dreamy_Jazz closed subtask T374853: Update the GlobalBlockManager service to support global autoblocks as Resolved.Oct 16 2024, 8:25 PM

Dreamy_Jazz moved this task from Needs review to Needs QA on the Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)) board.

For QA I would suggest checking that the acceptance criteria have been met. To do this, you can try to edit while using an account that is globally blocked with autoblocking enabled. This should create a global blocking autoblock for the IP that you are using. If one already exists, then the expiry of the autoblock should be updated to be 1 day in the future.

To be able to complete this test you will need to set $wgGlobalBlockingEnableAutoblocks = true; in your LocalSettings.php. If you wish to test this in patch demo, I can make a patch which you can include in the creation of the wiki to be able to test on patch demo (just let me know).

Dreamy_Jazz set the point value for this task to 2.Oct 16 2024, 8:35 PM

QA has been completed, see screenshots below, thank you @Dreamy_Jazz for the QA notes:
Before Editing an account that is autoblocked:

After Editing that same account that was autoblocked (expiration of the autoblocked IP has been updated to 1 day in the future):

Dreamy_Jazz closed this task as Resolved.Oct 22 2024, 8:22 AM

	F57632337: image.png
	Oct 22 2024, 5:08 AM

	F57632331: image.png
	Oct 22 2024, 5:08 AM

Globally autoblock the user's IP address when User::spreadAnyEditBlock is calledClosed, ResolvedPublic2 Estimated Story PointsActions