Page MenuHomePhabricator
Create Task
Maniphest T374863

Prevent global autoblocks on a configurable list of IP addresses
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Similar to the local block-autoblock-exemptionlist for local blocks, it should be possible to prevent global autoblocks on a configurable list of IP addresses.

This list should be global and definable such that it can be modified on wiki without the need to modify site config.

Global autoblocks should also potentially respect the local wiki's autoblock exempt list, such that they are disabled on that wiki if listed at MediaWiki:block-autoblock-exemptionlist).

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update description at Special:GlobalBlockList for global autoblocksmediawiki/extensions/GlobalBlockingmaster+1 -1
Locally disable global autoblocks when IP exempt from local autoblocksmediawiki/extensions/GlobalBlockingmaster+108 -3
Test AutoblockExemptionListmediawiki/coremaster+43 -0
Create GlobalBlockLocalStatusLookup::getLocalStatusInfomediawiki/extensions/GlobalBlockingmaster+32 -15
Customize query in gerrit

Related Objects
Search...

Event Timeline

Dreamy_Jazz created this task.Sep 16 2024, 3:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 16 2024, 3:48 PM
Dreamy_Jazz moved this task from Priority Backlog to Ready on the Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)) board.Sep 16 2024, 3:50 PM
Dreamy_Jazz moved this task from Ready to Priority Backlog on the Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)) board.
Dreamy_Jazz edited parent tasks, added: T374854: Update the GlobalBlockLookup service to support reading and applying global autoblocks; removed: T368949: [Epic] Implement global autoblocks from global user blocks.Sep 23 2024, 4:02 PM
Dreamy_Jazz removed a parent task: T374854: Update the GlobalBlockLookup service to support reading and applying global autoblocks.
Dreamy_Jazz added a subtask: T374854: Update the GlobalBlockLookup service to support reading and applying global autoblocks.
Dreamy_Jazz added a parent task: T368949: [Epic] Implement global autoblocks from global user blocks.
kostajh moved this task from Backlog to In progress on the Temporary accounts (Blockers to minor pilot wiki deployment) board.Sep 24 2024, 8:35 AM
Dreamy_Jazz mentioned this in T375580: Add a central global autoblocks exemption list.Sep 24 2024, 11:41 PM
Dreamy_Jazz closed subtask T375580: Add a central global autoblocks exemption list as Resolved.Sep 26 2024, 2:27 PM
kostajh moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)) board.Oct 8 2024, 10:22 AM
Dreamy_Jazz moved this task from Sprint Beatboxing (Sept 16-27) to Sprint Cello (Oct 7 - 18) on the Trust and Safety Product Sprint board.Oct 8 2024, 10:29 AM
Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)); removed Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)).
Dreamy_Jazz moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)) board.
Dreamy_Jazz moved this task from Needs review to Ready on the Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)) board.
Dreamy_Jazz closed subtask T374854: Update the GlobalBlockLookup service to support reading and applying global autoblocks as Resolved.Oct 10 2024, 1:57 PM
gerritbot added a comment.Oct 16 2024, 10:52 AM

Change #1080605 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Create GlobalBlockLocalStatusLookup::getLocalStatusInfo

https://gerrit.wikimedia.org/r/1080605

gerritbot added a project: Patch-For-Review.Oct 16 2024, 10:52 AM
gerritbot added a comment.Oct 16 2024, 12:31 PM

Change #1080636 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Locally disable global autoblocks when IP exempt from local autoblocks

https://gerrit.wikimedia.org/r/1080636

Dreamy_Jazz moved this task from Ready to Needs review on the Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)) board.Oct 16 2024, 1:00 PM
gerritbot added a comment.Oct 16 2024, 1:07 PM

Change #1080701 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Test AutoblockExemptionList

https://gerrit.wikimedia.org/r/1080701

gerritbot added a comment.Oct 16 2024, 1:46 PM

Change #1080605 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Create GlobalBlockLocalStatusLookup::getLocalStatusInfo

https://gerrit.wikimedia.org/r/1080605

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.28; 2024-10-22).Oct 16 2024, 2:00 PM
gerritbot added a comment.Oct 16 2024, 2:59 PM

Change #1080701 merged by jenkins-bot:

[mediawiki/core@master] Test AutoblockExemptionList

https://gerrit.wikimedia.org/r/1080701

gerritbot added a comment.Oct 16 2024, 4:09 PM

Change #1080757 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Update description at Special:GlobalBlockList for global autoblocks

https://gerrit.wikimedia.org/r/1080757

Dreamy_Jazz set the point value for this task to 2.Oct 16 2024, 8:23 PM
gerritbot added a comment.Oct 17 2024, 10:11 AM

Change #1080636 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Locally disable global autoblocks when IP exempt from local autoblocks

https://gerrit.wikimedia.org/r/1080636

gerritbot added a comment.Oct 17 2024, 10:16 AM

Change #1080757 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Update description at Special:GlobalBlockList for global autoblocks

https://gerrit.wikimedia.org/r/1080757

Maintenance_bot removed a project: Patch-For-Review.Oct 17 2024, 10:31 AM
Dreamy_Jazz moved this task from Needs review to Needs QA on the Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)) board.Oct 17 2024, 12:23 PM
Dreamy_Jazz added a comment.Oct 22 2024, 11:00 AM

Suggested QA steps:

  1. Create MediaWiki:globalblocking-globalautoblock-exemptionlist and add to the page the IP address you use to access the wiki after a * character (e.g. * 1.2.3.4). If you have wgGlobalBlockingCentralWiki set (such as on beta), then create this page on the central wiki (metawiki). Otherwise, create this page on the local wiki.
  2. Create a account
  3. Globally block the account created in step 2 with global autoblocks enabled
  4. While logged in to the account created in step 2, attempt to make an edit
  5. Verification step 1: Verify that no global autoblock is created due to step 4
  6. Delete MediaWiki:globalblocking-globalautoblock-exemptionlist
  7. While logged in to the account created in step 2, attempt to make an edit
  8. Verification step 2: Verify that a global autoblock is created due to step 7
  9. Verification step 3: While logged out, attempt to make an edit and verify that you are prevented from doing so due to the global autoblock
  10. Create MediaWiki:block-autoblock-exemptionlist on the local wiki (not the central wiki) with the same content as used in step 1. This will locally disable the global autoblock.
  11. Verification step 4: While logged out, attempt to make an edit and verify that you can do so.
Djackson-ctr moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)) board.Oct 24 2024, 2:38 AM
Djackson-ctr subscribed.

QA has been completed (global autoblocks are locally disabled if the target IP address is listed in the MediaWiki:Block-autoblock-exemptionlist).
I greatly appreciated the QA Steps @Dreamy_Jazz, thank you sir.

Dreamy_Jazz closed this task as Resolved.Oct 25 2024, 10:58 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits