Page MenuHomePhabricator

[S] Show profile icon instead of notifications bell in for Settings view for explore feed opt-outs
Closed, ResolvedPublic

Assigned To
None
Authored By
HNordeenWMF
Sep 16 2024, 6:05 PM
Referenced Files
F57515711: image.png
Sep 16 2024, 6:05 PM
F57515709: image.png
Sep 16 2024, 6:05 PM
F57515714: image.png
Sep 16 2024, 6:05 PM
F57515707: image.png
Sep 16 2024, 6:05 PM

Description

Background

As part of the Navigation refresh, T373712, we are creating a profile view that will be accessible from both article view and the main view for quick access to notifications, watchlist, and other items throughout the entire app.

Requirements

Within the Settings view that is shown as a tab when users have Explore tab turned off (Settings > Explore > Explore tab toggle)

  • Settings view accessed from here receives the same updates as elsewhere T374163: [S] Update Settings menu to remove items moved to new Profile view
  • Remove existing notifications entry point
  • Add profile icon / profile menu
  • Profile icon should show "unread" active state when user has unread notifications
  • Profile menu should be exactly the same as displayed from other entry points
  • Displays well in Landscape mode
  • Create equivalent version for iPad
Designs

If a user turns off Explore feed, their explore feed option is replaced with Settings

image.png (1×786 px, 439 KB)

image.png (2×1 px, 360 KB)
image.png (1×786 px, 214 KB)
image.png (1×786 px, 61 KB)
Existing screen: Settings replaces the Explore tabNew screen: Settings replaces the Explore tab, and Account icon is added to top right (replacing notification bell)Opening profile icon shows profile menu (Settings is also shown within account modal)

Event Timeline

Tsevener renamed this task from Show profile icon instead of notifications bell in for Settings view for explore feed opt-outs to [S] Show profile icon instead of notifications bell in for Settings view for explore feed opt-outs.Sep 17 2024, 6:21 PM
Tsevener updated the task description. (Show Details)
Tsevener updated the task description. (Show Details)

Partial PR is up, but we can't fully complete or test this work until Settings navigation is in (T374166).

This is challenging to test since the links in the profile view (including Settings) aren’t working yet @Tsevener.

@scblr sorry about that - I kicked off another build (Experimental 166) that should have the Settings links in place.

Works and looks good to me @Tsevener. Moving to the next column.