To allow the removal of the gbw_address and gbw_target_central_id columns (T374937), we need to stop reading data from these columns. Places where we read the value of these columns should be updated to first lookup by target using the globalblocks table and then use the relevant ID to find the global_block_whitelist row.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Stop reading from gbw_address and gbw_target_central_id | mediawiki/extensions/GlobalBlocking | master | +104 -395 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Restricted Task | |||||
| Resolved | kostajh | T294511 2021 Security Team wikireplicas audit | |||
| Declined | None | T284948 Raw IPs of logged-out users disclosed in wiki-replicas | |||
| Resolved | Niharika | T324492 Temporary accounts - MVP | |||
| Resolved | Madalina | T326816 [Epic] Update features for temporary accounts | |||
| Open | None | T355286 [Epic] Globally blocking a temporary account should prevent further account creations | |||
| Resolved | Dreamy_Jazz | T368949 [Epic] Implement global autoblocks from global user blocks | |||
| Resolved | Dreamy_Jazz | T374937 Drop gbw_address and gbw_target_central_id from the global_block_whitelist table | |||
| Resolved | Dreamy_Jazz | T374945 Stop writing to gbw_address and gbw_target_central_id | |||
| Resolved | Dreamy_Jazz | T374941 Stop reading from the gbw_address and gbw_target_central_id columns |
Change #1073459 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/GlobalBlocking@master] Stop reading from gbw_address and gbw_target_central_id
Change #1073459 merged by jenkins-bot:
[mediawiki/extensions/GlobalBlocking@master] Stop reading from gbw_address and gbw_target_central_id
For QA, I would suggest regression testing as no on-wiki functionality should have changed as a result of this ticket.
QA regression testing has been completed, and GlobalBlocking is functioning as expected.