So that we can support global autoblocks, the global_block_whitelist table needs to no longer have columns for the target of the block. This is because we cannot appropriately hide this data in the wiki replicas, as the store of which block is an autoblock is stored on another database.
We can safely not write to the column as it is only used in places where we could instead write to the gbw_id column to be the reference to the target (through a separate DB query to the globalblocks table).
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Restricted Task | |||||
| Resolved | kostajh | T294511 2021 Security Team wikireplicas audit | |||
| Declined | None | T284948 Raw IPs of logged-out users disclosed in wiki-replicas | |||
| Resolved | Niharika | T324492 Temporary accounts - MVP | |||
| Open | None | T326816 [Epic] Update features for temporary accounts | |||
| Open | None | T355286 [Epic] Globally blocking a temporary account should prevent further account creations | |||
| Resolved | Dreamy_Jazz | T368949 [Epic] Implement global autoblocks from global user blocks | |||
| Resolved | Dreamy_Jazz | T374937 Drop gbw_address and gbw_target_central_id from the global_block_whitelist table | |||
| Resolved | Dreamy_Jazz | T374945 Stop writing to gbw_address and gbw_target_central_id | |||
| Resolved | Dreamy_Jazz | T374941 Stop reading from the gbw_address and gbw_target_central_id columns | |||
| Resolved | Ladsgroup | T375184 Apply a default to gbw_address in the global_block_whitelist table |
Change #1073466 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/GlobalBlocking@master] Add a default value to gbw_address
Requesting DBA feedback on the attached patch. Would appreciate if this was done soon as this is a blocker.
Change #1073466 merged by jenkins-bot:
[mediawiki/extensions/GlobalBlocking@master] Add a default value to gbw_address
The patch was merged. If there are issues with the proposed approach, these could probably be discussed in the Schema-change-in-production ticket T375184.
Change #1075018 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/GlobalBlocking@master] Stop writing real data to gbw_address and gbw_target_central_id
Change #1075018 merged by jenkins-bot:
[mediawiki/extensions/GlobalBlocking@master] Stop writing real data to gbw_address and gbw_target_central_id
Change #1077455 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/GlobalBlocking@master] Stop writing to gbw_address and gbw_target_central_id
Change #1077455 merged by jenkins-bot:
[mediawiki/extensions/GlobalBlocking@master] Stop writing to gbw_address and gbw_target_central_id