Page MenuHomePhabricator
Create Task
Maniphest T375056

Automoderator should Rollback consecutive edits instead of Undoing a single edit
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Technical spike: T372299: [SPIKE]Investigate using Rollback instead of Undo for Automoderator reverts[16H]

Undoing single edits can cause headaches for patrollers to fix when a user had made multiple bad edits in a row. The typical actions users would take in this scenario is to Rollback - undoing all consecutive edits by the user in one go.

We received near unanimous support for moving to Rollback behaviour rather than Undoing single edits, so we should just change Automoderator's behaviour to this. If, in the future, there is some disagreement about this, we could add a configuration option to Rollback or Undo, but that seems unnecessarily complicated for the moment.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Automoderator should Rollback consecutive edits instead of Undoing a single editmediawiki/extensions/AutoModeratormaster+5 -5
Automoderator should Rollback consecutive edits instead of Undoing a single editmediawiki/extensions/AutoModeratormaster+1 K -109
Add specific rollback system messages for AutoModeratormediawiki/extensions/AutoModeratormaster+6 -0
Customize query in gerrit

Related Objects

Event Timeline

Samwalton9-WMF created this task.Sep 18 2024, 8:08 AM
Restricted Application added a project: Moderator-Tools-Team. · View Herald TranscriptSep 18 2024, 8:08 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Samwalton9-WMF moved this task from Inbox to Product backlog on the Moderator-Tools-Team board.Sep 18 2024, 8:09 AM
Samwalton9-WMF mentioned this in T372299: [SPIKE]Investigate using Rollback instead of Undo for Automoderator reverts[16H].
Samwalton9-WMF moved this task from Product backlog to Up next on the Moderator-Tools-Team board.Sep 30 2024, 4:26 PM
Samwalton9-WMF moved this task from Up next to To be estimated on the Moderator-Tools-Team board.
Samwalton9-WMF triaged this task as High priority.Sep 30 2024, 4:33 PM
Scardenasmolinar subscribed.Oct 1 2024, 3:10 PM

Maybe we could use https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AutoModerator/+/1064817 as a starting point.

Scardenasmolinar set the point value for this task to 3.Oct 1 2024, 3:10 PM
Scardenasmolinar moved this task from To be estimated to Up next on the Moderator-Tools-Team board.
jsn.sherman moved this task from Up next to Kanban on the Moderator-Tools-Team board.Oct 1 2024, 4:15 PM
jsn.sherman edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.
Kgraessle claimed this task.Oct 2 2024, 7:33 PM
Kgraessle moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
jsn.sherman subscribed.Oct 3 2024, 5:02 PM

@Kgraessle based on our conversation today, I suggest bumping this up to 5 points.

Kgraessle added a comment.Oct 3 2024, 5:05 PM
In T375056#10200211, @jsn.sherman wrote:

@Kgraessle based on our conversation today, I suggest bumping this up to 5 points.

Good call, I'll do that now.

Kgraessle changed the point value for this task from 3 to 5.Oct 3 2024, 5:05 PM
gerritbot added a comment.Oct 4 2024, 1:30 PM

Change #1064817 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/AutoModerator@master] Automoderator should Rollback consecutive edits instead of Undoing a single edit

https://gerrit.wikimedia.org/r/1064817

gerritbot added a project: Patch-For-Review.Oct 4 2024, 1:30 PM
Kgraessle moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Oct 4 2024, 1:47 PM
Kgraessle moved this task from Eng review to In Progress on the Moderator-Tools-Team (Kanban) board.Oct 4 2024, 1:51 PM
Kgraessle moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Oct 4 2024, 3:30 PM
jsn.sherman moved this task from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Oct 23 2024, 2:41 PM
Kgraessle moved this task from Reviewed (waiting for changes) to In Progress on the Moderator-Tools-Team (Kanban) board.Oct 25 2024, 1:32 PM
gerritbot added a comment.Oct 25 2024, 3:50 PM

Change #1083197 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/AutoModerator@master] Add specific rollback system messages for AutoModerator

https://gerrit.wikimedia.org/r/1083197

Kgraessle moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Oct 25 2024, 7:27 PM
Kgraessle moved this task from Eng review to In Progress on the Moderator-Tools-Team (Kanban) board.Oct 25 2024, 7:32 PM
Kgraessle moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.
gerritbot added a comment.Oct 28 2024, 7:12 PM

Change #1083197 merged by jenkins-bot:

[mediawiki/extensions/AutoModerator@master] Add specific rollback system messages for AutoModerator

https://gerrit.wikimedia.org/r/1083197

Kgraessle mentioned this in rEAMOd1a2c3399f03: Add specific rollback system messages for AutoModerator.Oct 28 2024, 7:12 PM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.1; 2024-10-29).Oct 28 2024, 8:00 PM
Scardenasmolinar mentioned this in T378343: Enable AutoModerator on Vietnamese Wikipedia (viwiki).Oct 29 2024, 4:12 PM
Scardenasmolinar moved this task from Eng review to QA on the Moderator-Tools-Team (Kanban) board.Nov 14 2024, 6:40 PM
Kgraessle moved this task from QA to In Progress on the Moderator-Tools-Team (Kanban) board.Nov 14 2024, 7:39 PM
Kgraessle moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Nov 14 2024, 7:59 PM
gerritbot added a comment.Nov 14 2024, 8:21 PM

Change #1064817 merged by jenkins-bot:

[mediawiki/extensions/AutoModerator@master] Automoderator should Rollback consecutive edits instead of Undoing a single edit

https://gerrit.wikimedia.org/r/1064817

Kgraessle mentioned this in rEAMOd5df10f2d1c9: Automoderator should Rollback consecutive edits instead of Undoing a single edit.Nov 14 2024, 8:23 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 14 2024, 8:30 PM
Scardenasmolinar moved this task from Eng review to QA on the Moderator-Tools-Team (Kanban) board.Nov 15 2024, 12:39 AM
Kgraessle moved this task from QA to In Progress on the Moderator-Tools-Team (Kanban) board.Nov 15 2024, 7:15 PM
gerritbot added a comment.Nov 15 2024, 7:17 PM

Change #1091804 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/AutoModerator@master] Automoderator should Rollback consecutive edits instead of Undoing a single edit

https://gerrit.wikimedia.org/r/1091804

gerritbot added a project: Patch-For-Review.Nov 15 2024, 7:17 PM
Kgraessle moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Nov 15 2024, 7:23 PM
gerritbot added a comment.Nov 15 2024, 7:57 PM

Change #1091804 merged by jenkins-bot:

[mediawiki/extensions/AutoModerator@master] Automoderator should Rollback consecutive edits instead of Undoing a single edit

https://gerrit.wikimedia.org/r/1091804

Kgraessle mentioned this in rEAMO03f45b2b5657: Automoderator should Rollback consecutive edits instead of Undoing a single edit.Nov 15 2024, 7:57 PM
ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.4; 2024-11-19); removed MW-1.44-notes (1.44.0-wmf.1; 2024-10-29).Nov 15 2024, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 15 2024, 8:30 PM
Kgraessle moved this task from Eng review to QA on the Moderator-Tools-Team (Kanban) board.Nov 19 2024, 6:53 PM
Rooiratel subscribed.Nov 23 2024, 8:24 AM
Kgraessle closed this task as Resolved.Dec 3 2024, 3:42 PM
Kgraessle moved this task from QA to Done on the Moderator-Tools-Team (Kanban) board.
Samwalton9-WMF mentioned this in T385875: Fix Automoderator using the wrong edit summary (individual edit instead of Rollback-style).Feb 7 2025, 1:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits