Page MenuHomePhabricator

Requestctl sync writes unchanged objects
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • upgrade python3-conftool-requestctl to 3.2.3
  • run requestctl sync -g <path> --interactive pattern

What happens?:
You get notified of changes even if nothing actually changed, and you're not requested to confirm the change

# requestctl sync --interactive -g .  pattern
2024-09-18 08:24:09,290 - reqctl (api:write:234) - INFO - Updating pattern req/get

What should have happened instead?:
No object should be updated, and if any has actually changed, a confirmation should be requested

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

3.2.3

Other information (browser name/version, screenshots, etc.):
Tested on puppetmaster2001

Details

Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Fix verification hooks in requestctl syncrepos/sre/conftool!32oblivianfix_verification_hookmain
Customize query in GitLab

Event Timeline

Joe triaged this task as High priority.Sep 18 2024, 8:33 AM
Joe updated the task description. (Show Details)

Setting to high and not UBN because we don't have this version installed anywhere.

Mentioned in SAL (#wikimedia-operations) [2024-09-18T15:03:58Z] <_joe_> uploading conftool 3.2.4 to apt T375059