Page MenuHomePhabricator

All AutoModerator Talk Page message headers change when a new message is sent
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Have AutoModerator Talk Page messages from previous months than the current month
  • Create an edit that will be reverted and a talk page message is sent

What happens?:
All AutoModerator Talk Page message headers change to the current month

What should have happened instead?:
The Talk Page message headers should have stayed the same

Event Timeline

This is because we're using {{CURRENTMONTHNAME}} {{CURRENTYEAR}}, which will always update to the current month/year. As discussed at RTL just now, could we simply substitute those templates? (e.g. {{subst:CURRENTMONTHNAME}})

From my testing, it looks like {{subst:CURRENTMONTH}} is being substituted by 09, the current month's number. This will not solve our problem because every time we add a new message, the magic word will be interpreted again (whether substituted or not).

Change #1074312 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/AutoModerator@master] Fix dynamic month in talk page message header

https://gerrit.wikimedia.org/r/1074312

From my testing, it looks like {{subst:CURRENTMONTH}} is being substituted by 09, the current month's number. This will not solve our problem because every time we add a new message, the magic word will be interpreted again (whether substituted or not).

I have seen the error of my ways (I tested on {{subst:CURRENTMONTH}} instead of {{subst:CURRENTMONTHNAME}}) and can now see that this is a great solution. Thanks, @Samwalton9-WMF! This is ready for review.

Change #1074312 merged by jenkins-bot:

[mediawiki/extensions/AutoModerator@master] Fix dynamic month in talk page message header

https://gerrit.wikimedia.org/r/1074312

Just noting that the last patch inadvertently caused the old message to break (showing the month where it used to show the username, because the definition of $1 changed) until the new translation is merged.

image.png (2,102×1,214 px, 321 KB)

noting that we're waiting on idwiki translations to be deployed.

I still see the old translated version of the talk page message header. I will check on Friday once the new translations are pushed.

note that idwiki still has versions from 2024-10-07

Scardenasmolinar moved this task from QA to Done on the Moderator-Tools-Team (Kanban) board.

Can confirm that the talk page message is now working! (see: https://id.wikipedia.org/wiki/Pembicaraan_Pengguna:120.188.65.176). Moving this to Done and resolving this ticket.

Just noting that the translation still needs fixing on Turkish Wikipedia (@Dogu) but should now work as expected on Ukrainian (@Renvoy).