As part of the SDS 2.1.3 goal in T360485: [EPIC] Newcomer homepage: Community updates module (FY23/24 WE1.3 / FY24/25 SDS2.1.3) it is desired to start using TestKitchen experiment variant assignment functionality instead of similar existing functionality in GrowthExperiments. The goal of this task is to define clear steps to dismantle the GrowthExperiments experiment management system.
Current status quo
ExperimentUserManager in GrowthExperiments is not "feature-flagged", that means that in practice any user interacting with GrowthExperiments features gets an experiment variant assigned. Even if there are no experiments in course, all users get the "control" variant assigned. In GrowthExperiments, being in the control group means getting all the enabled features for a given wiki.
GrowthExperiments assigns the experiment variant when a new local user is created. The variant is then stored in the user_property table, the relevant property is 'growthexperiments-homepage-variant'. The experiments run by Growth team across years have left a trace of variants across wikis.
Steps to dismantle the variant assignment
- Make GrowthExperiments not assign any experiment variant on account creation, T412942
- Lookup GrowthExperiments code checking for user to be in a variant, drop such logic, T416894
- Lookup GrowthExperiments code force setting a variant, drop such logic, T416894
- Lookup GrowthExperiments code expecting a variant to always be present (instrumentation at least), adapt such code to make the variant optional since only users part of an experiment will have one, T416894
- Lookup the rest of GrowthExperiments code depending on ExperimentUserManager and drop logic, T416894
- Remove 'growthexperiments-homepage-variant' user property from all wikis where it's present, T417621
- Remove Growth experiment management config variables: wgGEUserVariants, GEHomepageNewAccountVariantsByPlatform, T416894
- Lookup for CSS leftovers only applied to passed experiments, T416894
Affected files
- ExperimentUserManager.php
- VariantHooks.php
- Utils.js, (getUserVariant, isUserInVariant)
- ...