Page MenuHomePhabricator

Apply default styling for charts
Closed, InvalidPublic

Description

Background

Result of spike T369863. We would like to modify the appearance of charts and labels

User story

As a reader I want visual separation from charts and other content

Design

Title/description Tracked in T375575: Charts legend display incorrectly in RTL and T375235: Apply default styling for charts

  • Title should be aligned left for LTR languages and right for RTL languages
  • Title text should be font size 16
  • Title text color should be #101418 in light mode, #F8F9FA in dark mode
  • Title subtext should be font size 14
  • Title subtext color should be #54595D in light mode, #A2A9B1 in dark mode
  • Font weights can remain the defaults

Legend Tracked in T379183: Adjust styling of legend

  • Legend should be oriented vertical
  • The item gap should be 8
  • Legend should begin 16px beneath the Title
  • Legend text should be aligned left
  • Legend text color should be #202122 in light mode, #EAECF0 in dark mode
  • Font weights and sizes can remain the defaults

Axis/labels => T379184: Adjust styling of axis labels

  • Axis label text color should be #54595D in light mode, #A2A9B1 in dark mode
  • Axis baseline and ticks color can inherit text color of #54595D in light mode, #A2A9B1 in dark mode (which should happen by default)
  • Axis lines (except the baseline with the ticks) color should be #DADDE3 in light mode, #404244 in dark mode

Framing => T379185: Adjust styling of Chart frame

  • Charts should contain a frame by default
  • Frame should mimic that of images, using a border defined as 1px solid #C8CCD1 in light mode, 1px solid #54595D in dark mode
  • The frame should have an internal padding of 16px
  • For now we will not offer a frameless option

Tooltips

  • Post MVP

Emphasis

  • Post MVP

Acceptance criteria

  • Charts should have default design specifics according to the details listed above in the Design sections
  • These styles should not be made customizable by the editor

Details

Related Changes in Gerrit:
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Style chart title per design specificationrepos/mediawiki/services/chart-renderer!51jdlrobsonstyleTitlemain
Customize query in GitLab

Event Timeline

DTorsani-WMF renamed this task from Default styling for charts to Define default styling for charts.Sep 21 2024, 12:10 AM
DTorsani-WMF updated the task description. (Show Details)
DTorsani-WMF subscribed.
Jdlrobson lowered the priority of this task from High to Medium.Sep 23 2024, 6:25 PM
DTorsani-WMF edited projects, added Charts (Sprint 7); removed Charts.
DTorsani-WMF moved this task from Incoming to Ready for Signoff on the Charts (Sprint 7) board.
DTorsani-WMF moved this task from Ready for Signoff to Ready for Dev on the Charts (Sprint 7) board.
DTorsani-WMF moved this task from Sprint 7 to Backlog on the Charts board.
DTorsani-WMF edited projects, added Charts; removed Charts (Sprint 7).
CCiufo-WMF renamed this task from Define default styling for charts to Apply default styling for charts.Oct 1 2024, 3:08 PM
CCiufo-WMF removed DTorsani-WMF as the assignee of this task.
CCiufo-WMF updated the task description. (Show Details)

Change #1091341 had a related patch set uploaded (by Bvibber; author: Bvibber):

[operations/deployment-charts@master] Update charts-renderer service

https://gerrit.wikimedia.org/r/1091341

Change #1091341 merged by jenkins-bot:

[operations/deployment-charts@master] Update charts-renderer service

https://gerrit.wikimedia.org/r/1091341

Change #1091348 had a related patch set uploaded (by CDanis; author: CDanis):

[operations/deployment-charts@master] chart-renderer: use 'app' instead of old 'main_app'

https://gerrit.wikimedia.org/r/1091348

Change #1091348 merged by jenkins-bot:

[operations/deployment-charts@master] chart-renderer: use 'app' instead of old 'main_app'

https://gerrit.wikimedia.org/r/1091348