Page MenuHomePhabricator
Create Task
Maniphest T375246

Edit page should include Codex styles for message box
Closed, ResolvedPublicBUG REPORT
Actions

Description

The edit page uses Html::messageBox which currently spits out a hybrid of Codex's message box HTML and legacy message box HTML but it does not seem to load the associated Codex styles, instead expecting skins to load it.

Steps to replicate the issue (include links if applicable):

What happens?:

  • The message "Вы не представились системе" is styled as a legacy message box instead of a Codex message box.

What should have happened instead?:

  • The message should be styled by Codex.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add Codex message box style module to pages that need itmediawiki/coremaster+17 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Sep 19 2024, 10:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 19 2024, 10:57 PM
Jdlrobson mentioned this in T360668: Drop support for non-Codex message boxes (mw-message-box).Sep 19 2024, 10:58 PM
Aklapper added a project: MediaWiki-Page-editing.Sep 20 2024, 8:27 AM
gerritbot added a comment.Sep 20 2024, 4:16 PM

Change #1074471 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Style Codex message boxes on edit pages

https://gerrit.wikimedia.org/r/1074471

gerritbot added a project: Patch-For-Review.Sep 20 2024, 4:16 PM
Jdlrobson added a parent task: T373602: FlaggedRevs: Codex styles display unstyled in some conditions.Sep 20 2024, 4:27 PM
CCiufo-WMF updated the task description. (Show Details)Sep 20 2024, 5:01 PM
CCiufo-WMF mentioned this in T373602: FlaggedRevs: Codex styles display unstyled in some conditions.Sep 20 2024, 5:14 PM
CCiufo-WMF subscribed.Sep 20 2024, 5:17 PM
gerritbot added a comment.Sep 20 2024, 5:22 PM

Change #1074471 merged by jenkins-bot:

[mediawiki/core@master] Add Codex message box style module to pages that need it

https://gerrit.wikimedia.org/r/1074471

Maintenance_bot removed a project: Patch-For-Review.Sep 20 2024, 5:30 PM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.24; 2024-09-24).Sep 20 2024, 6:00 PM
Jdlrobson changed the task status from Open to Stalled.Sep 20 2024, 10:18 PM

Stalling until we have T375287 in place so can identify other pages.

Jdlrobson mentioned this in T374499: Final update: Support for styling message boxes using old markup is being removed.Sep 23 2024, 5:42 PM
Novem_Linguae subscribed.Sep 23 2024, 5:55 PM
ArthurTaylor mentioned this in T375486: Test failure: MediaWiki\Skins\Vector\Tests\Structure\PerformanceBudgetTest::testTotalModulesSize.Sep 25 2024, 9:15 AM
Jdlrobson closed this task as Resolved.Oct 3 2024, 2:53 PM
Jdlrobson claimed this task.

This one is fixed visually - I am seeing the inline Codex styles and block styles.
There is follow up work to not rely on Skin.php to load it - I'm going to resolve this and track that work in T375287.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits