Page MenuHomePhabricator

White shadow on page preview with dark theme due to blockquote in summary
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT

Description

Page previews for the same article are similarly odd on light theme. Strikingly similar to T365428.

QA steps

Steps to replicate the issue (include links if applicable):

image.png (1,366×768 px, 572 KB)

What happens?:

As the article trails off, there appears a strange white 'shadow' at the end of the paragraph.

image.png (1,366×768 px, 691 KB)

image.png (1,366×768 px, 354 KB)

What should have happened instead?:

  • A less grotesque shadowing is likely preferred by the Reader, whose views of Wiki{p/m}edia we hold most dearly.

As always, cheers and thanks for putting up with my oft-invalid tickets!

JayCubby

Derived Requirement

Ensure that page previews in both dark and light mode do not exhibit strange visual artifacts, such as white shadows at the end of paragraphs, when hovering over links to articles like [[Novitiate]]. The content should display cleanly without abrupt truncation or shadowing.

BDD

Feature: Consistent and clean page previews in dark and light modes

Scenario: Ensure no visual artifacts or truncation in page previews

Given a user is logged out and browsing in light or dark mode
When the user hovers over a link to [[Novitiate]] or a similar article
Then the page preview should display cleanly without abrupt truncation or strange shadowing
Test Steps

Test Case 1: Ensure page previews in dark mode do not exhibit visual artifacts

  1. Go to T375316 article.
  2. Enable dark mode.
  3. Hover over the links in the article.
  4. AC1: Confirm that the page preview does not truncate abruptly or display strange shadowing at the end of the paragraph.

Test Case 2: Ensure page previews in light mode do not exhibit visual artifacts

  1. Go to T375316 article.
  2. Enable light mode.
  3. Hover over the links in the article.
  4. AC2: Confirm that the page preview does not truncate abruptly or display strange shadowing at the end of the paragraph.

QA Results - Beta

ACStatusDetails
1T375316#10176501
2T375316#10176501

QA Results - Prod

ACStatusDetails
1T375316#10248975
2T375316#10248975

Event Timeline

bwang subscribed.

i can reproduce with novitiate link in https://en.wikipedia.org/wiki/Missionaries_of_La_Salette.
it seems to only happen in certain page preview cases. Unsure the extent of this issue in all previews in prod

@bwang --
Courtesy screenshots:

image.png (914×553 px, 274 KB)

image.png (914×553 px, 262 KB)

Jdlrobson renamed this task from White shadow on page preview w/ dark theme. Page previews for the same article are similarly odd on light theme. Strikingly similar to T365428. to White shadow on page preview with dark theme.Sep 23 2024, 9:03 PM
Jdlrobson updated the task description. (Show Details)

The issue seems to relate to a blockquote element inside the page preview.
According to https://www.mediawiki.org/wiki/Page_Previews/API_Specification blockquote should not be allowed in the preview, so this seems like an API issue more than a visual issue.

Interesting! I can't really think of an efficient way to search for pages using {{blockquote}} in the introduction, otherwise I'd try to replicate outside of the one case I have found.

Cheers!

Jdlrobson renamed this task from White shadow on page preview with dark theme to White shadow on page preview with dark theme due to blockquote in summary.Sep 23 2024, 10:24 PM
Jdlrobson set the point value for this task to 2.Sep 24 2024, 4:21 PM

We discussed this today and it seems there are reasonable use cases for blockquote e.g. T213107 so this may now be part of the spec.

Blockquotes are sometimes included in the lead paragraph that is pulled in for Popups, we had some CSS that was introduced with https://phabricator.wikimedia.org/T213107 that was causing this issue, it was applying an additional fade indicator even when the block quote isnt visible at all.

For this fix i removed that additional fade indicator and just updated the block quote spacing so that we could make use of the original fade indicator. This results in a visual change to page popups with a visible blockquote

Before:

Screenshot 2024-09-24 at 11.36.42 AM.png (1,034×562 px, 100 KB)

After:
Screenshot 2024-09-24 at 11.34.22 AM.png (766×428 px, 81 KB)

Change #1075302 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/extensions/Popups@master] Fix fade indicators when blockquotes are in popups

https://gerrit.wikimedia.org/r/1075302

Jdlrobson lowered the priority of this task from High to Medium.Sep 24 2024, 11:01 PM
GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF updated Other Assignee, added: Edtadros.
GMikesell-WMF added a subscriber: Edtadros.

Change #1075302 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Fix fade indicators when blockquotes are in popups

https://gerrit.wikimedia.org/r/1075302

@JayCubby Thanks for the details steps and screenshots along with having links to test for Beta & PROD!

@Jdlrobson White shadow does not appear in Beta as seen in the gifs below.

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma 15.0
Browser: Chrome 129
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure page previews in dark mode do not exhibit visual artifacts

Go to T375316 article.
Enable dark mode.
Hover over the links in the article.
✅ AC1: Confirm that the page preview does not truncate abruptly or display strange shadowing at the end of the paragraph.

Dark
2024-09-25_09-32-03.mp4.gif (890×626 px, 558 KB)

Test Case 2: Ensure page previews in light mode do not exhibit visual artifacts

Go to T375316 article.
Enable light mode.
Hover over the links in the article.
✅ AC2: Confirm that the page preview does not truncate abruptly or display strange shadowing at the end of the paragraph.

Light
2024-09-25_09-31-36.mp4.gif (916×630 px, 432 KB)
GMikesell-WMF assigned this task to ovasileva.
GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF updated Other Assignee, removed: Edtadros.
GMikesell-WMF subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: Prod
OS: macOS Sequoia
Browser: Chrome 129
Device: MS
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure page previews in dark mode do not exhibit visual artifacts

Go to T375316 article.
Enable dark mode.
Hover over the links in the article.
✅ AC1: Confirm that the page preview does not truncate abruptly or display strange shadowing at the end of the paragraph.

Dark
screenshot 111.png (1,025×812 px, 434 KB)

Test Case 2: Ensure page previews in light mode do not exhibit visual artifacts

Go to T375316 article.
Enable light mode.
Hover over the links in the article.
✅ AC2: Confirm that the page preview does not truncate abruptly or display strange shadowing at the end of the paragraph.

Light
screenshot 110.png (1,025×812 px, 420 KB)