Page MenuHomePhabricator

No way to mark merged commits as needing fixing
Closed, ResolvedPublic

Description

As with the fixme tags on CodeReview. Who should take care of those and how should they find them?


Version: unspecified
Severity: normal

Details

Reference
bz35535

Related Objects

StatusSubtypeAssignedTask
Resolved demon
ResolvedNone

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:19 AM
bzimport added a project: Gerrit.
bzimport set Reference to bz35535.
bzimport added a subscriber: Unknown Object (MLST).

We can mark a commit -1 or -2 to not have it submitted. Once submitted though we have no way to tag it in Gerrit.

Niklas had this exact same issue this morning. My recommendations were to either:

  • add a comment on the faulty change
  • open a bug report
  • drop a mail to original author and possibly developers

We should probably do all the above, the last step would be to add the authors as CC of the bug report.

Really, I think this would be solved with free-form tagging, so duping to bug 35534.

  • This bug has been marked as a duplicate of bug 35534 ***