Page MenuHomePhabricator

Unified Dashboard: Updating the source language inside confirmation step leads to error
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • 1. Select a section or a page suggestion to translate. This will lead you to the confirmation step.
  • 2. Inside the confirmation step, click on the source language and select a different language from the list.

What happens?:
An error is thrown at the console, suggestion information disappear from screen, and if the user clicks on the "Start Translation" page, they are navigated to a broken "Pick a sentence" step.

The error is different for page and section translations, but both cases are broken.

What should have happened instead?:

  • The source language should have been updated
  • The source article information inside the confirmation step should have been updated to reflect the new source article
  • Click on the "start translation" button should navigate to the next step properly without errors.

Screencasts from greek (el) production wiki

Page suggestion:

Section suggestion:

Derived Requirement

When a user selects a different source language during the confirmation step of a page or section translation, the application should correctly update the source language and corresponding article information. The "Start Translation" button should properly navigate the user to the next step without throwing errors or displaying broken screens.

BDD

Feature: Update Source Language in Translation Workflow

Scenario: Update source language and article information in the confirmation step

Given the user has selected a page or section to translate
And the user is on the confirmation step of the translation workflow
When the user selects a different source language
Then the source language should be updated
And the source article information should be updated to reflect the new source article
And clicking the "Start Translation" button should navigate the user to the next step without any errors
Test Steps

Test Case 1: Ensure Source Language and Article Update Correctly

  1. Select a section or page suggestion to translate, leading to the confirmation step.
  2. Inside the confirmation step, click on the source language and choose a different language from the list.
  3. ✅❓❌⬜ AC1: Confirm that the source language updates without throwing any console errors.
  4. ✅❓❌⬜ AC2: Verify that the source article information in the confirmation step is updated according to the newly selected source language.
  5. ✅❓❌⬜ AC3: Click the "Start Translation" button and confirm the user is navigated to the next step without errors and the "Pick a sentence" step works correctly.

QA Results - Test Mobile Special:ContentTranslation

ACStatusDetails
1T375410#10268920
2T375410#10268920
3T375410#10268920

Event Timeline

ngkountas changed the task status from Open to In Progress.Sep 23 2024, 5:43 PM
ngkountas claimed this task.
ngkountas triaged this task as Medium priority.
ngkountas added a project: SectionTranslation.
ngkountas added a subscriber: SBisson.

Change #1075059 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX confirmation step: Fix source language update issues

https://gerrit.wikimedia.org/r/1075059

Change #1075059 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX confirmation step: Fix source language update issues

https://gerrit.wikimedia.org/r/1075059

Change #1075231 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20240923

https://gerrit.wikimedia.org/r/1075231

Change #1075231 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20240925

https://gerrit.wikimedia.org/r/1075231

Change #1075567 had a related patch set uploaded (by Sbisson; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@wmf/1.43.0-wmf.24] CX3 Build 0.2.0+20240925

https://gerrit.wikimedia.org/r/1075567

Change #1075567 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@wmf/1.43.0-wmf.24] CX3 Build 0.2.0+20240925

https://gerrit.wikimedia.org/r/1075567

Mentioned in SAL (#wikimedia-operations) [2024-09-25T14:22:59Z] <kartik@deploy1003> Finished scap sync-world: Backport for [[gerrit:1075567|CX3 Build 0.2.0+20240925 (T374387 T370746 T368422 T374567 T355780 T374559 T374886 T375410)]] (duration: 14m 06s)

@ngkountas Can you please review the gif for the Page? Unlike Section, I'm receiving errors when I go through the steps with Page. Thanks!

Status: ❌ FAIL
Environment: Test Mobile Special:ContentTranslation
OS: macOS Sonoma 15.0
Browser: Chrome 129
Device: MBA
Emulated Device: NA

Test Artifact(s):

https://test.m.wikipedia.org/w/index.php?title=Special:ContentTranslation&active-list=suggestions&from=nl&to=el&page=Koninkrijk%20Itali%C3%AB%20(774-962)#/sx?eventSource=direct_preselect

Test Steps

Test Case 1: Ensure Source Language and Article Update Correctly

  1. Select a section or page suggestion to translate, leading to the confirmation step.
  2. Inside the confirmation step, click on the source language and choose a different language from the list.
  3. ❌ AC1: Confirm that the source language updates without throwing any console errors.
❌ Page✅Section
2024-10-15_13-29-31.mp4.gif (1×1 px, 2 MB)
2024-10-15_13-34-02.mp4.gif (1×1 px, 1 MB)
  1. ❌ AC2: Verify that the source article information in the confirmation step is updated according to the newly selected source language.

See AC1

  1. ❌ AC3: Click the "Start Translation" button and confirm the user is navigated to the next step without errors and the "Pick a sentence" step works correctly.

See AC1

Change #1081092 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX Confirmation step: Fetch source page upon source language update

https://gerrit.wikimedia.org/r/1081092

Change #1081092 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX Confirmation step: Fetch source page upon source language update

https://gerrit.wikimedia.org/r/1081092

Change #1079550 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20241018

https://gerrit.wikimedia.org/r/1079550

Change #1079550 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20241018

https://gerrit.wikimedia.org/r/1079550

Status: ✅ PASS
Environment: Test Mobile Special:ContentTranslation
OS: macOS Sonoma 15.0
Browser: Chrome 129
Device: MBA
Emulated Device: NA

Test Artifact(s):

https://test.m.wikipedia.org/w/index.php?title=Special:ContentTranslation&active-list=suggestions&from=nl&to=el&page=Koninkrijk%20Itali%C3%AB%20(774-962)#/sx?eventSource=direct_preselect

Test Steps

Test Case 1: Ensure Source Language and Article Update Correctly

  1. Select a section or page suggestion to translate, leading to the confirmation step.
  2. Inside the confirmation step, click on the source language and choose a different language from the list.
  3. ✅ AC1: Confirm that the source language updates without throwing any console errors.
✅ Page✅Section
2024-10-28_09-37-41.mp4.gif (1×996 px, 2 MB)
2024-10-28_09-38-49.mp4.gif (1×992 px, 2 MB)
  1. ✅ AC2: Verify that the source article information in the confirmation step is updated according to the newly selected source language.

See AC1

  1. ✅ AC3: Click the "Start Translation" button and confirm the user is navigated to the next step without errors and the "Pick a sentence" step works correctly.

See AC1

Issue?

@ngkountas Not sure if this is an issue or not, but anytime I select a suggestion from page, I get the 404 error, as seen in the screenshot below. I don't get it when I click one from sections.

2024-10-28_09-40-35.png (543×945 px, 260 KB)

@GMikesell-WMF The 404 error (failed request to cxserver) is perfectly OK. This is a request to fetch section suggestions for the given page and language pair, but since there is no target page, cxserver returns 404.