Page MenuHomePhabricator

Improve paragraph spacing in Vector/Minerva using :has() selector
Open, MediumPublic

Description

Background

Follow up to T366389
After T366389, @Od1n identified an issue with empty paragraph elements, and suggested a solution using the new :has() selector, which basically allows us to get a previous sibling selector. This solution would also allow us to avoid the negative top margin on inline elements.

Once the vector solution is updated, we should ensure Minerva gets the same treatment

User story

  • Add a reader I want consistent and readable paragraph spacing. As a wiki editor I want spacing to be easily understood and consistent so I can create readable content

Requirements

  • Update Vector with :has() selector solution
  • Update Minerva with :has() selector solution
  • Update pixel content test page with empty paragraph test case
  • Create a patchdemo or beta test page for QA to use

Design

No visual changes in Vector, some changes in Minerva
See T366389

Acceptance criteria

  • Minerva and Vector have consistent spacing solutions, where paragraphs are separated by 1em, and 0.5em in between inline elements

Communication criteria - does this need an announcement or discussion?

no

Event Timeline

bwang triaged this task as Medium priority.Sep 24 2024, 6:58 PM

Assuming this lingering task with no active project tags is about the Vector 2022 codebase. Please add codebase project tags to tasks.