Test failure: Wikibase\Repo\Tests\Hooks\Helpers\OutputPageEditabilityTest::testGivenPageIsEditable_returnsTrue
Open, Needs TriagePublic
Actions

Description

21:09:04 There were 3 failures:
21:09:04 
21:09:04 1) Wikibase\Repo\Tests\Hooks\Helpers\OutputPageEditabilityTest::testGivenPageIsEditable_returnsTrue with data set #0 (MediaWiki\Output\OutputPage Object (...))
21:09:04 Failed asserting that false is true.
21:09:04 
21:09:04 /workspace/src/extensions/Wikibase/repo/tests/phpunit/includes/Hooks/Helpers/OutputPageEditabilityTest.php:88
21:09:04 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:106
Logs generated by test

Show Details
21:09:04 
21:09:04 2) Wikibase\Repo\Tests\Hooks\Helpers\OutputPageEditabilityTest::testGivenPageIsEditable_returnsTrue with data set #1 (MediaWiki\Output\OutputPage Object (...))
21:09:04 Failed asserting that false is true.
21:09:04 
21:09:04 /workspace/src/extensions/Wikibase/repo/tests/phpunit/includes/Hooks/Helpers/OutputPageEditabilityTest.php:88
21:09:04 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:106
Logs generated by test

Show Details
21:09:04 
21:09:04 3) Wikibase\Repo\Tests\Hooks\Helpers\OutputPageEditabilityTest::testGivenPageIsEditable_returnsTrue with data set #2 (MediaWiki\Output\OutputPage Object (...))
21:09:04 Failed asserting that false is true.
21:09:04 
21:09:04 /workspace/src/extensions/Wikibase/repo/tests/phpunit/includes/Hooks/Helpers/OutputPageEditabilityTest.php:88
21:09:04 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:106

Seen on https://integration.wikimedia.org/ci/job/integration-quibble-fullrun-extensions-phpunit/607/console from https://gerrit.wikimedia.org/r/c/integration/quibble/+/1075303, which set WikiLambda as the extension under test.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Use non-main namespace for three tests	mediawiki/extensions/Wikibase	master	+3 -3

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T225730 Reduce runtime of MW shared gate Jenkins jobs to 5 min
Open	None	T50217 Speed up MediaWiki PHPUnit build by running integration tests in parallel
Open	None	T375558 Test failure: Wikibase\Repo\Tests\Hooks\Helpers\OutputPageEditabilityTest::testGivenPageIsEditable_returnsTrue

Event Timeline

kostajh created this task.Sep 24 2024, 8:16 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 24 2024, 8:16 PM

Maintenance_bot added a project: Wikidata.Sep 24 2024, 8:30 PM

All three failing tests use an NS_MAIN title, so at a guess, WikiLambda probably changes the interpretation of that namespace?

Change #1075511 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use non-main namespace for three tests

https://gerrit.wikimedia.org/r/1075511

gerritbot added a project: Patch-For-Review.Sep 25 2024, 9:00 AM

Can we see if ^ helps? Would Depends-On on the Quibble change work?

Let's find out... https://gerrit.wikimedia.org/r/c/integration/quibble/+/1075303/2

I see:

11:56:20 INFO:zuul.Cloner.mediawiki/extensions/Wikibase:Prepared mediawiki/extensions/Wikibase repo with commit e6ca7bf55df64a37c2ed9b2ccceaa994626cee4c

in the log, so I assume it pulled in the change. But it doesn't seem to have resolved the issue.

Hm, but I don’t see any OutputPageEditabilityTest errors in the CI output of PS2 there? It looks like a bunch of other errors now? (At least some of which, like “Requested page AbuseFilter testing page isn't in the wikitext content model”, feel like they might also be due to the main namespace no longer being wikitext.)

Assuming that I understand the problems in this task correctly – that various tests get confused when, due to WikiLambda being installed, ns0 is no longer a wikitext namespace – I think this task could be considered part of T289741: Explore impact of adding WikiLambda to the general MediaWiki CI gate (or even a duplicate of it).

The WikiLambda jobs take less than 10 mins to run in linear mode, just because there aren't so many dependencies. Considering this and T375551 are potentially our only remaining issues for parallel testing, and since WikiLambda testing anyway seems to be a thorny topic, I would suggest we just exclude this extension from parallel testing and move forward.

ArthurTaylor mentioned this in T375551: Test failure: WikiLambda ContentHandlerFunctionalTest::testGetParserOutput.Oct 11 2024, 10:43 AM

In T375558#10220946, @ArthurTaylor wrote:

The WikiLambda jobs take less than 10 mins to run in linear mode, just because there aren't so many dependencies. Considering this and T375551 are potentially our only remaining issues for parallel testing, and since WikiLambda testing anyway seems to be a thorny topic, I would suggest we just exclude this extension from parallel testing and move forward.

That seems reasonable to me. Although if T289741: Explore impact of adding WikiLambda to the general MediaWiki CI gate goes through, we'd encounter the errors again if/when we enable parallel testing for MW core patches and gate-and-submit.

In T375558#10210981, @Lucas_Werkmeister_WMDE wrote:

Assuming that I understand the problems in this task correctly – that various tests get confused when, due to WikiLambda being installed, ns0 is no longer a wikitext namespace – I think this task could be considered part of T289741: Explore impact of adding WikiLambda to the general MediaWiki CI gate (or even a duplicate of it).

Tagging WikiLambda per the comment above.

Maintenance_bot added a project: Abstract Wikipedia team.Oct 11 2024, 11:30 AM

Jdforrester-WMF moved this task from To Triage to No current plans / External on the Abstract Wikipedia team board.Oct 16 2024, 4:33 PM

Change #1075511 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use non-main namespace for three tests

https://gerrit.wikimedia.org/r/1075511

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.28; 2024-10-22).Oct 18 2024, 10:00 AM

Maintenance_bot removed a project: Patch-For-Review.Oct 18 2024, 10:31 AM