Page MenuHomePhabricator

Migrate EventLogging to use DefaultEventSubmitter
Open, LowPublic3 Estimated Story Points

Description

In https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EventLogging/+/1070992, we added the EventSubmitter class, which adapts the current background queue provided by EventLogging to work with the JS Metrics Platform Client (JS MPC).

However, the JS MPC, contains the DefaultEventSubmitter class, which can be used in place of the background queue in EventLogging. DefaultEventSubmitter also batches events to send to the event intake service, which EventLogging doesn't do.

This task covers migrating EventLogging to use DefaultEventSubmitter.

Update

DefaultEventSubmitter is in use in the xLab SDK for all experiments. That is, DefaultEventSubmitter has been proven to work in production and at scale.

AC

  • DefaultEventSubmitter is updated to accept a variable timeout
    • The current timeout is 5 seconds and isn't configurable
  • The MetricsClient instance in EventLogging uses an instance of DefaultEventSubmitter
  • EventSubmitter in EventLogging is removed

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
cjming set the point value for this task to 3.
cjming moved this task from Incoming to BACKLOG on the Test Kitchen board.
phuedx moved this task from READY TO GROOM to Backlog on the Test Kitchen board.