VisualEditor don't pass)
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Jdforrester-WMF
	Sep 27 2024, 3:48 PM

Project Tags

Referenced Files

None

Subscribers

Jdforrester-WMF

matmarex

Mgagat

Description

Before:

"projects": [
        "mediawiki/core",
        "mediawiki/extensions/EventBus",
        "mediawiki/extensions/EventLogging",
        "mediawiki/extensions/EventStreamConfig",
        "mediawiki/extensions/UniversalLanguageSelector",
        "mediawiki/extensions/WikiLambda",
        "mediawiki/extensions/WikimediaMessages",
        "mediawiki/skins/Vector",
        "mediawiki/vendor"
    ]

After:

"projects": [
        "mediawiki/core",
        "mediawiki/extensions/AbuseFilter",
        "mediawiki/extensions/AntiSpoof",
        "mediawiki/extensions/BetaFeatures",
        "mediawiki/extensions/CentralAuth",
        "mediawiki/extensions/CheckUser",
        "mediawiki/extensions/Cite",
        "mediawiki/extensions/CodeEditor",
        "mediawiki/extensions/ConfirmEdit",
        "mediawiki/extensions/DiscussionTools",
        "mediawiki/extensions/Echo",
        "mediawiki/extensions/EventBus",
        "mediawiki/extensions/EventLogging",
        "mediawiki/extensions/EventStreamConfig",
        "mediawiki/extensions/FlaggedRevs",
        "mediawiki/extensions/Flow",
        "mediawiki/extensions/Gadgets",
        "mediawiki/extensions/GlobalBlocking",
        "mediawiki/extensions/GuidedTour",
        "mediawiki/extensions/Linter",
        "mediawiki/extensions/MobileApp",
        "mediawiki/extensions/MobileFrontend",
        "mediawiki/extensions/PageImages",
        "mediawiki/extensions/ParserFunctions",
        "mediawiki/extensions/Popups",
        "mediawiki/extensions/Renameuser",
        "mediawiki/extensions/Scribunto",
        "mediawiki/extensions/SecurePoll",
        "mediawiki/extensions/SyntaxHighlight_GeSHi",
        "mediawiki/extensions/TemplateData",
        "mediawiki/extensions/TextExtracts",
        "mediawiki/extensions/Thanks",
        "mediawiki/extensions/TorBlock",
        "mediawiki/extensions/UniversalLanguageSelector",
        "mediawiki/extensions/VisualEditor",
        "mediawiki/extensions/WikiEditor",
        "mediawiki/extensions/WikiLambda",
        "mediawiki/extensions/WikimediaEvents",
        "mediawiki/extensions/WikimediaMessages",
        "mediawiki/skins/MinervaNeue",
        "mediawiki/skins/Vector",
        "mediawiki/vendor"
    ]

Last successful merge was 1072803 (CI log) at 2024-09-24 Z 20:30.

First visible CI failure was on 1017875,4 (CI log) at 2024-09-26 Z 17:52.

Almost certainly caused by 1075543, adding MobileFrontend to WikimediaMessages and thus the endless gated-sub-sub-dependencies of MF to WikiLambda, deployed at 2024-09-25 Z 23:46. :-(

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	tests: Make HooksTest pass without MobileFrontend installed	Bartosz Dziewoński	mediawiki/extensions/WikimediaMessages	master	+2 -2
	Zuul: [mediawiki/extensions/WikimediaMessages] Drop MobileFrontend dependency	Jforrester	integration/config	master	+0 -3

Customize query in gerrit

Event Timeline

CCing @matmarex for visibility.

Options:

Drop MF from WikimediaMessages's dependencies (but not phan-dependencies). Pros: Very quick and easy. Cons: Could break some tests (do we have any real ones?).
Quickly fix all the repos' tests to disable themselves with WikiLambda loaded. Pros: Pretty quick. Cons: Potentially hides actual breakage, we probably won't remember to fix them later.
Quickly fix all the repos' tests to not pass with WikiLambda loaded. Pros: What we should do eventually. Cons: Slow, complicated.

Change #1076223 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [mediawiki/extensions/WikimediaMessages] Drop MobileFrontend dependency

https://gerrit.wikimedia.org/r/1076223

gerritbot added a project: Patch-For-Review.Sep 27 2024, 3:55 PM

Change #1076223 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/WikimediaMessages] Drop MobileFrontend dependency

https://gerrit.wikimedia.org/r/1076223

Mentioned in SAL (#wikimedia-releng) [2024-09-27T16:24:00Z] <James_F> Zuul: [mediawiki/extensions/WikimediaMessages] Drop MobileFrontend dependency for now, for T375894

Maintenance_bot removed a project: Patch-For-Review.Sep 27 2024, 4:30 PM

Change #1076230 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/WikimediaMessages@master] tests: Make HooksTest pass without MobileFrontend installed

https://gerrit.wikimedia.org/r/1076230

gerritbot added a project: Patch-For-Review.Sep 27 2024, 4:31 PM

Change #1076230 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] tests: Make HooksTest pass without MobileFrontend installed

https://gerrit.wikimedia.org/r/1076230

matmarex closed this task as Resolved.Sep 27 2024, 6:00 PM

matmarex removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.25; 2024-10-01).Sep 27 2024, 6:00 PM

Mgagat subscribed.Sep 28 2024, 11:35 AM

Dependency list for WikiLambda has suddenly expanded, including gate which doesn't pass (AbuseFilter/CheckUser/Flow/Linter/Echo/Thank/VisualEditor don't pass)Closed, ResolvedPublicActions

Description

Details

Event Timeline

Dependency list for WikiLambda has suddenly expanded, including gate which doesn't pass (AbuseFilter/CheckUser/Flow/Linter/Echo/Thank/VisualEditor don't pass)
Closed, ResolvedPublic
Actions