[S] Create a shouldShowYearInReviewProfileItem method in data controller
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	HNordeenWMF
	Sep 30 2024, 3:34 PM

Description

Background

The Apps team plans to explore if a personalized Wikipedia Year in Review feature that displays insights about a user's reading history, editing history, and donation history is engaging for App users, and inspires them to make a donation to the Wikimedia Foundation.

Tasks

Create a shouldShowYearInReviewProfileItem method in data controller. Within this, check developer settings feature flag, check remote config logic before moving to next bullet point (country code, kill switch, primary app language wiki. Note both country code and primary app language wiki must match. AND, not OR).
Then check persisted report model from T376041 and return yes if one or more personalized slides are set as evaluated=yes, display=yes, and they do not have a slide-specific kill switch in the remote config.
Add Wikipedia Year in Review entry point to profile view if data controller shouldShowYearInReviewProfileItem returns true.
Do not add badge here yet.

QA Notes

Install app
Ensure device region in iOS settings is set to Mexico or Italy
Ensure primary app language is set to Spanish, Italian or English
At this stage, do at least one of these things: Build up a rabbit hole so the History tab shows 6+ articles OR log into an account with 1+ edits in 2024.
Enable year in review feature flag in app developer settings menu
Background / foreground the app to trigger report creation.
Year in Review entry point should appear in Profile menu
Fresh install app, repeat steps. At fourth bullet point, keep History tab lower than 5 articles and ensure you are logged out or logged into an account with zero edits. Ensure you do NOT see entry point in Profile.

Related Objects
Search...

Status	Assigned	Task
Resolved	HNordeenWMF	T371946 [Epic] Wikipedia Year in Review on iOS App
Resolved	None	T376037 [Engineering Epic] Wikipedia Year in Review V1 Main Flow & Actions
Resolved	None	T376041 [L] Initial data set-up for YiR
Resolved	None	T376042 [S] Create a shouldShowYearInReviewProfileItem method in data controller

Event Timeline

HNordeenWMF created this task.Sep 30 2024, 3:34 PM

HNordeenWMF triaged this task as Medium priority.

HNordeenWMF moved this task from Tasks from Product Backlog to Needs Eng Sync or Estimation on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

HNordeenWMF mentioned this in T376037: [Engineering Epic] Wikipedia Year in Review V1 Main Flow & Actions.Sep 30 2024, 3:38 PM

Tsevener renamed this task from Create a shouldShowWikipediaInReviewProfileItem method in data controller to [S] Create a shouldShowWikipediaInReviewProfileItem method in data controller.Oct 1 2024, 6:36 PM

Tsevener moved this task from Needs Eng Sync or Estimation to Current Sprint Work on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Oct 1 2024, 7:28 PM

HNordeenWMF updated the task description. (Show Details)Oct 1 2024, 9:09 PM

Tsevener updated the task description. (Show Details)Oct 1 2024, 9:10 PM

Tsevener updated the task description. (Show Details)

Tsevener updated the task description. (Show Details)Oct 2 2024, 3:29 AM

Tsevener updated the task description. (Show Details)Oct 2 2024, 3:58 AM

Tsevener updated the task description. (Show Details)

Tsevener mentioned this in T376044: [M] Present paging components when tapping Profile item.Oct 2 2024, 4:11 AM

Tsevener updated the task description. (Show Details)Oct 3 2024, 12:52 PM

Tsevener mentioned this in T376310: [S] Allow users to hide Year in Review.Oct 3 2024, 1:52 PM

Tsevener mentioned this in T376312: [S] Update profile button to badge state if Year in Review is ready.Oct 3 2024, 1:56 PM

Tsevener mentioned this in T376316: [M] Year in Review new feature announcement.Oct 3 2024, 2:26 PM

HNordeenWMF renamed this task from [S] Create a shouldShowWikipediaInReviewProfileItem method in data controller to [S] Create a shouldShowYearInReviewProfileItem method in data controller.Oct 4 2024, 3:16 PM

HNordeenWMF updated the task description. (Show Details)

Tsevener mentioned this in T376313: [S] Add/update profile view year in review item + badge state.Oct 4 2024, 4:27 PM

HNordeenWMF updated the task description. (Show Details)Oct 7 2024, 7:34 PM

Tsevener claimed this task.Oct 7 2024, 10:23 PM

Tsevener moved this task from Current Sprint Work to Doing on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

tonisevener opened https://github.com/wikimedia/wikipedia-ios/pull/5010

Draft PR is up with my progress. There's a couple of blockers here until I can fully wrap this up (T376041 and T376040), so moving this to Blocked for now.

Tsevener moved this task from Doing to Blocked or Waiting on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Oct 8 2024, 11:14 PM

Marking this as a "Part 1" PR, ready for code review.

A part 2 PR will need to get in later after one of the personalized slides (T376066 or T376320) is complete, so that the "one or more personalized slides" requirement can be tested. For now the entry point is displaying when a user passes these requirements:

Device country code in France or Italy
Primary app language wiki in French or Italian
Developer Settings feature flag is on

Tsevener moved this task from Blocked or Waiting to Needs Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Oct 10 2024, 9:44 PM

Tsevener mentioned this in T376040: [M] Create remote config for YiR.Oct 15 2024, 12:50 PM

Tsevener mentioned this in T375566: [L] Year in Review - Build initial paging UI component.Oct 15 2024, 12:57 PM

tonisevener closed https://github.com/wikimedia/wikipedia-ios/pull/5010

Tsevener moved this task from Needs Code Review to Waiting for Build on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Oct 15 2024, 4:46 PM

Tsevener moved this task from Waiting for Build to Needs QA signoff on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Oct 16 2024, 2:37 PM

Tsevener moved this task from Needs QA signoff to Waiting for Build on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

Tsevener moved this task from Waiting for Build to Blocked or Waiting on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

Moving to Blocked / Waiting until we finish one of the personalized slides, so we can test this part of the requirements:

Then check persisted report model from T376041 and return yes if one or more personalized slides are set as evaluated=yes, display=yes, and they do not have a slide-specific kill switch in the remote config.