Build #173

l-olson1214 opened https://github.com/wikimedia/wikipedia-ios/pull/5015

Heads up on this @HNordeenWMF. For now the collective slide text that contains numbers are NOT localized, so translators won't see it pop up yet. After thinking about it, we think it's best if translators translate the entire string ("Wikipedia had 63.59 million articles..." once with the final numbers, with the formatting of their choosing. Our other alternatives were:

1. Inject a spelled out number (because the system can do that part of the translation for us), so that it looks like:

"Wikipedia had six million three hundred thousand five hundred etc. articles...". Then when we get the final number, we only change the number, and the system injects a new spelled-out translation.

2. We could have them translate the entire preliminary string now, but then they would have to repeat the work once the final numbers are in.

So the plan is to convert these into localized strings only once the final numbers are ready. The lift to manually add the FR and IT translations in T376417 at that point will still be small.

thanks @Tsevener
Could there be a 3rd option where the source text goes into translate wiki with something like % million (knowing that the word million will not change, and can get translated already, and % is a variable that we define somewhere as the correct number), similar to this one.

Can be tested in 7.6.1 (4246)

@HNordeenWMF I'm unsure of how different languages communicate larger short-form numbers like that. For example, google translate suggests "3.6 million" is "360万" in Simplified Chinese. So it may not be wise at this stage to build in that assumption that there is an equivalent standalone "million" for every language, and adjusting the number later on will still make sense. Tagging @cooltey in case he has thoughts here!

Another part of our hesitation was not knowing if references to "million" or "billion" were static, or if even that could change with the final numbers. So if you're sure those will remain unchanged that leaves less up in the air.

In T376044#10229089, @Tsevener wrote:

@HNordeenWMF I'm unsure of how different languages communicate larger short-form numbers like that. For example, google translate suggests "3.6 million" is "360万" in Simplified Chinese. So it may not be wise at this stage to build in that assumption that there is an equivalent standalone "million" for every language, and adjusting the number later on will still make sense. Tagging @cooltey in case he has thoughts here!

Another part of our hesitation was not knowing if references to "million" or "billion" were static, or if even that could change with the final numbers. So if you're sure those will remain unchanged that leaves less up in the air.

Hi @Tsevener

We have a function from the Android library that handles this case, please see https://github.com/wikimedia/apps-android-wikipedia/blob/55f6631148303250d6d431c38fb8fbdf6e861bf2/app/src/main/java/org/wikipedia/util/StringUtil.kt#L216-L220

It is only available in a newer version of the Android.

and it's based on the device's language, you can see the differences below:

315k = 32 萬, which is not a super accurate but acceptable result.

Sounds good, thanks @cooltey!

@HNordeenWMF @scblr
I made an attempt to localize all the base slide text in my PR for T376066: [M] Article total personalized slide: You read 350 articles (which also displays uses collective base numbers). Once that is in that part of this task will be done ("Use variables for source text of translations"). None of it will be user-facing until translations come through, so T376066 shouldn't block design review on this task.

Quick question @HNordeenWMF:

With these requirements:

Present "Base flow - No reading or Editing History" slides from collective flow in Figma
Only users who are eligible for more 1 or more personalized slide should see the entry point

So far in our latest builds, the base flow is available to see intact for design review / QA. But eventually (once we get personalized slides in), for a user with no personalized data, they will never see the base flow because the entry point will be gone. Is that correct / expected?

@Tsevener yes - that sounds correct. We need to see the base flow right now for testing/QA, but for release users should only be able to see the entry point if they are eligible for at least one personalized slide,

Looks good on 7.6.2 (4337)

Looks good - some copy has changed since was made (in 2 places, noted in this task: T377899)