FilterNotFoundException: Filter 1 does not exist
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Oct 1 2024, 12:22 AM

Description

https://integration.wikimedia.org/ci/job/quibble-composer-mysql-php74-noselenium/8017/console

01:14:47 1) MediaWiki\Extension\AbuseFilter\Tests\Integration\Api\QueryAbuseLogTest::testConstruct
01:14:47 MediaWiki\Extension\AbuseFilter\Filter\FilterNotFoundException: Filter 1 does not exist
01:14:47 
01:14:47 /workspace/src/extensions/AbuseFilter/includes/FilterLookup.php:123
01:14:47 /workspace/src/extensions/AbuseFilter/includes/Api/QueryAbuseLog.php:281
01:14:47 /workspace/src/includes/api/ApiQuery.php:695
01:14:47 /workspace/src/includes/api/ApiMain.php:1935
01:14:47 /workspace/src/includes/api/ApiMain.php:881
01:14:47 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:169
01:14:47 /workspace/src/extensions/AbuseFilter/tests/phpunit/integration/Api/QueryAbuseLogTest.php:20
01:14:47 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:322
01:14:47 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	tests: Set $tablesUsed in CheckMatchTest	mediawiki/extensions/AbuseFilter	REL1_41	+3 -0
	tests: Set $tablesUsed in CheckMatchTest	mediawiki/extensions/AbuseFilter	REL1_39	+3 -0

Customize query in gerrit

Related Objects

Mentioned In: T378263: MediaWiki\Extension\DiscussionTools\Tests\LanguageDataTest::testGetLocalData with data set #4
Mentioned Here: rEABFd0c3001c626e: SECURITY: abusefiltercheckmatch: Check if user can see log details
T342301: Remove MediaWikiIntegrationTestCase::$tablesUsed in favour of automatic query tracking

Event Timeline

Reedy created this task.Oct 1 2024, 12:22 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 1 2024, 12:22 AM

Reedy updated the task description. (Show Details)Oct 1 2024, 12:22 AM

ABreault-WMF subscribed.Oct 18 2024, 12:00 AM

Umherirrender mentioned this in T378263: MediaWiki\Extension\DiscussionTools\Tests\LanguageDataTest::testGetLocalData with data set #4.Oct 26 2024, 3:25 PM

Change #1083329 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AbuseFilter@REL1_41] tests: Set $tablesUsed in CheckMatchTest

https://gerrit.wikimedia.org/r/1083329

gerritbot added a project: Patch-For-Review.Oct 26 2024, 4:32 PM

The patch before d0c3001c626ef1db6239f369db432a9246b53021 works while this security patch set was forced merged in AbuseFilter extension.

Backporting a database test is the reason for the failure, because the phpunit enviroment has changed (T342301: Remove MediaWikiIntegrationTestCase::$tablesUsed in favour of automatic query tracking) for database tests in newer releases.
The clean up of used table is better in newer release, so this old release needs a $tablesUsed hint to clean up correctly the newly added test.

Change #1083331 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AbuseFilter@REL1_39] tests: Set $tablesUsed in CheckMatchTest

https://gerrit.wikimedia.org/r/1083331

Change #1083331 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@REL1_39] tests: Set $tablesUsed in CheckMatchTest

https://gerrit.wikimedia.org/r/1083331

Change #1083329 merged by jenkins-bot: