Make ToolIcon compatible for special directories and hovering
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	Scardenasmolinar
	Oct 1 2024, 4:03 AM

Description

The initial migration to Vue for the toolbar only affected the next and minimize options. When working on T349388, it was discovered that the Vue ToolIcon component was incompatible with the other toolbar options, like Mark as reviewed, Tags, Delete, etc.

A fix has already been implemented in the Gerrit patch. The objective of this task is to extract the relevant code from that patch and create a new patch with that fix only.

Acceptance Criteria:

ToolIcons use the resource loader appropriately.
There are no errors/changes in the toolbar.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Add useSpecialIcon prop to ToolIcon Vue component	mediawiki/extensions/PageTriage	master	+92 -27

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T335074 Rewrite PageTriage front-end in Vue.js
Open	None	T340117 PageTriage: Implement Curation Toolbar in Vue.js
Resolved	Scardenasmolinar	T376101 Make ToolIcon compatible for special directories and hovering

Event Timeline

Scardenasmolinar created this task.Oct 1 2024, 4:03 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 1 2024, 4:03 AM

Scardenasmolinar moved this task from Backlog to Vue migration rewrites on the PageTriage board.Oct 1 2024, 4:21 AM

jsn.sherman added a parent task: T340117: PageTriage: Implement Curation Toolbar in Vue.js.Oct 1 2024, 2:32 PM

jsn.sherman mentioned this in T349386: Curation toolbar: Convert Article Info component to Vue.js.Oct 1 2024, 2:47 PM

jsn.sherman added projects: Vue.js, Technical-Debt.Oct 1 2024, 2:49 PM

jsn.sherman mentioned this in T349387: Curation toolbar: Convert Wikilove component to Vue.js.Oct 1 2024, 5:20 PM

jsn.sherman mentioned this in T349389: Curation toolbar: Convert Tag component to Vue.js.Oct 1 2024, 5:24 PM

jsn.sherman mentioned this in T349390: Curation toolbar: Convert Mark for Deletion component to Vue.js.Oct 1 2024, 5:26 PM

jsn.sherman set the point value for this task to 3.Oct 2 2024, 5:12 PM

jsn.sherman mentioned this in T349388: Curation toolbar: Convert Mark as Reviewed component to Vue.js.Oct 4 2024, 4:23 PM

jsn.sherman moved this task from To be estimated to Up next on the Moderator-Tools-Team board.Oct 9 2024, 5:53 PM

Samwalton9-WMF moved this task from Up next to Estimated on the Moderator-Tools-Team board.Oct 28 2024, 5:14 PM

Scardenasmolinar triaged this task as Low priority.Nov 26 2024, 5:09 PM

Scardenasmolinar moved this task from Estimated to Kanban on the Moderator-Tools-Team board.

Scardenasmolinar edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.

Scardenasmolinar changed the task status from Open to In Progress.Dec 5 2024, 1:26 AM

Scardenasmolinar claimed this task.

Scardenasmolinar moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.

Change #1101131 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/PageTriage@master] Add specialDir prop to ToolIcon vue component

https://gerrit.wikimedia.org/r/1101131

gerritbot added a project: Patch-For-Review.Dec 7 2024, 1:41 AM

Scardenasmolinar moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Dec 9 2024, 10:58 PM

Switching out image paths on mouseenter/mouseleave to change icons is a somewhat outdated way of achieving hover and other icon states.

The standard way to do this in MW would be to define a ResourceLoader module with icon variants, and switch them out using CSS classes, and :hover for the hover states.

Thanks for the feedback! I'll do that.

Scardenasmolinar moved this task from Eng review to In Progress on the Moderator-Tools-Team (Kanban) board.Dec 10 2024, 7:02 PM

jsn.sherman mentioned this in T376104: [SPIKE]: Curation Toolbar Vue Migration - Investigate Changes in Codex Components [16HRS].Jan 8 2025, 6:27 PM

Scardenasmolinar moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Jan 14 2025, 4:44 AM

Change #1101131 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Add useSpecialIcon prop to ToolIcon Vue component

https://gerrit.wikimedia.org/r/1101131

jsn.sherman moved this task from Eng review to QA on the Moderator-Tools-Team (Kanban) board.Jan 15 2025, 4:09 PM

jsn.sherman updated the task description. (Show Details)

Maintenance_bot removed a project: Patch-For-Review.Jan 15 2025, 4:31 PM

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.13; 2025-01-21).Jan 15 2025, 5:00 PM