Page MenuHomePhabricator

Curation Toolbar: Separate and remove unnecessary flyout code from Mark and Reviewed WIP patch
Closed, ResolvedPublic3 Estimated Story Points

Description

In T353569, we created some Flyout components in anticipation of working on T349388 and thinking we would need them. Once the actual work started on the Mark as Reviewed patch, we discovered that some of the created components were not needed.

In this task, we should separate and remove the unnecessary flyout code and see if there is code in the ToolFlyout.vue file that can be separated from the Mark as reviewed patch that will be useful for all future Vue migrations.

Acceptance criteria:

  • The unnecessary Vue files are deleted.
  • Slots are added to ToolFlyout.vue the same way they are in the Mark as reviewed patch.
  • These changes should not affect any of the current functionality of the curation toolbar.

Event Timeline

Scardenasmolinar renamed this task from C to Curation Toolbar: Separate and remove unnecessary flyout code from Mark and Reviewed WIP patch.Oct 1 2024, 4:19 AM
Scardenasmolinar updated the task description. (Show Details)
Scardenasmolinar moved this task from Backlog to Vue migration rewrites on the PageTriage board.
jsn.sherman set the point value for this task to 3.Oct 2 2024, 5:14 PM

Change #1120687 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/PageTriage@master] Separate and remove unnecessary Flyout code

https://gerrit.wikimedia.org/r/1120687

Change #1120687 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Separate and remove unnecessary Flyout code

https://gerrit.wikimedia.org/r/1120687