Page MenuHomePhabricator
Create Task
Maniphest T376104

[SPIKE]: Curation Toolbar Vue Migration - Investigate Changes in Codex Components [16HRS]
Closed, ResolvedPublicSpike
Actions

Description

When work started on T349388, Codex work was ongoing for some components that could be of use to our migration efforts but maybe weren't ready yet. This task is to investigate if any new Codex components can/will be of use to the migration of the curation toolbar modules to Vue.

Questions to be answered:

  • Are there any new components that can/should be used for the Flyouts?
  • Are there any new components that can be of use in any of the un-migrated toolbar modules, like Tags, Mark as Reviewed, Delete, etc.?

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
[SPIKE]: Curation Toolbar Vue Migration - Investigate Changes in Codex Components - Alters icons on page triage bar to use codex iconsmediawiki/extensions/PageTriagemaster+719 -97
[SPIKE]: Curation Toolbar Vue Migration - Investigate Changes in Codex Component Adds an example of radio inputs Adds an example of checkboxes Adds an example of FlyoutLink component Adds an example of using codex tabs Spikes out the article info flyout and tags flyout using codex.mediawiki/extensions/PageTriagemaster+1 K -84
Customize query in gerrit

Related Objects
Search...

Event Timeline

Scardenasmolinar created this task.Oct 1 2024, 4:28 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 1 2024, 4:28 AM
jsn.sherman added a parent task: T340117: PageTriage: Implement Curation Toolbar in Vue.js.Oct 1 2024, 2:31 PM
jsn.sherman added projects: Vue.js, Technical-Debt.Oct 1 2024, 2:50 PM
jsn.sherman renamed this task from SPIKE: Curation Toolbar Vue Migration - Investigate Changes in Codex Components to [SPIKE]: Curation Toolbar Vue Migration - Investigate Changes in Codex Components [16HRS].Oct 2 2024, 5:16 PM
jsn.sherman added a project: Spike.
Restricted Application changed the subtype of this task from "Task" to "Spike". · View Herald TranscriptOct 2 2024, 5:16 PM
jsn.sherman moved this task from To be estimated to Up next on the Moderator-Tools-Team board.Oct 9 2024, 5:53 PM
Samwalton9-WMF moved this task from Up next to Estimated on the Moderator-Tools-Team board.Oct 28 2024, 5:14 PM
jsn.sherman triaged this task as Medium priority.Oct 29 2024, 5:26 PM
jsn.sherman moved this task from Estimated to Kanban on the Moderator-Tools-Team board.
jsn.sherman edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.
• Kgraessle claimed this task.Oct 30 2024, 3:19 PM
• Kgraessle moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
• Kgraessle added a comment.Nov 1 2024, 4:08 PM
Are there any new components that can/should be used for the Flyouts?

Not really, there's some minor html elements (links, icons) but updating these would change the design of the current interface, so I'm not sure if want to do that?

FlyoutHeader.vue
All
Are there any new components that can be of use in any of the un-migrated toolbar modules, like Tags, Mark as Reviewed, Delete, etc.?
Article Info:
Mark As Reviewed:
Tags:
Mark as Deleted:
WikiLove:

Pull request spike patches to follow for some of these components. I also refactored the toolbar to use codex icons in a WIP patch in case we wanted to see what that looks like.

gerritbot added a comment.Nov 1 2024, 4:14 PM

Change #1085614 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/PageTriage@master] [SPIKE]: Curation Toolbar Vue Migration - Investigate Changes in Codex Components - Alters icons on page triage bar to use codex icons

https://gerrit.wikimedia.org/r/1085614

gerritbot added a project: Patch-For-Review.Nov 1 2024, 4:14 PM
gerritbot added a comment.Nov 8 2024, 7:55 PM

Change #1088618 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/PageTriage@master] [SPIKE]: Curation Toolbar Vue Migration - Investigate Changes in Codex Component Adds an example of radio inputs Adds an example of checkboxes Adds an example of FlyoutLink component Adds an example of using codex tabs Spikes out the article info flyout and tags flyout using codex.

https://gerrit.wikimedia.org/r/1088618

• Kgraessle moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Nov 8 2024, 8:03 PM
jsn.sherman subscribed.Jan 8 2025, 5:48 PM

We talked about this in moderator tools engineering:

  • all of the invisible changes can/should be made as time allows
  • any changes that require a design update need to be discussed with the NPP community and perhaps left for them to implement.
jsn.sherman moved this task from Eng review to Done on the Moderator-Tools-Team (Kanban) board.Jan 8 2025, 5:48 PM
jsn.sherman added a comment.EditedJan 8 2025, 6:27 PM
In T376104#10284434, @Kgraessle wrote:
All

Noting some previous discussions on this topic:
T342051#9064115
T127202

And the in progress patch to improve the technical approach to using the current icons:
T376101

• Kgraessle added a comment.Jan 8 2025, 7:27 PM

Providing a final writeup of the components we discussed creating stories for. For the time being they are components that do not require design updates.

Are there any new components that can/should be used for the Flyouts?

Yes.

FlyoutHeader.vue
Are there any new components that can be of use in any of the un-migrated toolbar modules, like Tags, Mark as Reviewed, Delete, etc.?
Article Info:
Mark As Reviewed:
Tags:
Mark as Deleted:
WikiLove:

Note there are spike patches above for example implementations.

jsn.sherman closed this task as Resolved.Jan 15 2025, 3:42 PM
jsn.sherman mentioned this in T383791: Curation Toolbar: Implement additional codex components that don't change the design.
gerritbot added a comment.Fri, May 15, 7:44 AM

Change #1088618 abandoned by Kgraessle:

[mediawiki/extensions/PageTriage@master] [SPIKE]: Curation Toolbar Vue Migration - Investigate Changes in Codex Component Adds an example of radio inputs Adds an example of checkboxes Adds an example of FlyoutLink component Adds an example of using codex tabs Spikes out the article info flyout and tags flyout using codex.

Reason:

N/A

https://gerrit.wikimedia.org/r/1088618

gerritbot added a comment.Fri, May 15, 7:45 AM

Change #1085614 abandoned by Kgraessle:

[mediawiki/extensions/PageTriage@master] [SPIKE]: Curation Toolbar Vue Migration - Investigate Changes in Codex Components - Alters icons on page triage bar to use codex icons

Reason:

N/A

https://gerrit.wikimedia.org/r/1085614

Maintenance_bot removed a project: Patch-For-Review.Fri, May 15, 8:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits