Page MenuHomePhabricator

[SPIKE]: Curation Toolbar Vue Migration - Investigate Changes in Codex Components [16HRS]
Closed, ResolvedPublicSpike

Description

When work started on T349388, Codex work was ongoing for some components that could be of use to our migration efforts but maybe weren't ready yet. This task is to investigate if any new Codex components can/will be of use to the migration of the curation toolbar modules to Vue.

Questions to be answered:

  • Are there any new components that can/should be used for the Flyouts?
  • Are there any new components that can be of use in any of the un-migrated toolbar modules, like Tags, Mark as Reviewed, Delete, etc.?

Event Timeline

jsn.sherman renamed this task from SPIKE: Curation Toolbar Vue Migration - Investigate Changes in Codex Components to [SPIKE]: Curation Toolbar Vue Migration - Investigate Changes in Codex Components [16HRS].Oct 2 2024, 5:16 PM
jsn.sherman added a project: Spike.
Restricted Application changed the subtype of this task from "Task" to "Spike". · View Herald TranscriptOct 2 2024, 5:16 PM
jsn.sherman moved this task from Estimated to Kanban on the Moderator-Tools-Team board.
Are there any new components that can/should be used for the Flyouts?

Not really, there's some minor html elements (links, icons) but updating these would change the design of the current interface, so I'm not sure if want to do that?

FlyoutHeader.vue
All
Are there any new components that can be of use in any of the un-migrated toolbar modules, like Tags, Mark as Reviewed, Delete, etc.?
Article Info:
Mark As Reviewed:
Tags:
Mark as Deleted:
WikiLove:

Pull request spike patches to follow for some of these components. I also refactored the toolbar to use codex icons in a WIP patch in case we wanted to see what that looks like.

Change #1085614 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/PageTriage@master] [SPIKE]: Curation Toolbar Vue Migration - Investigate Changes in Codex Components - Alters icons on page triage bar to use codex icons

https://gerrit.wikimedia.org/r/1085614

Change #1088618 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/PageTriage@master] [SPIKE]: Curation Toolbar Vue Migration - Investigate Changes in Codex Component Adds an example of radio inputs Adds an example of checkboxes Adds an example of FlyoutLink component Adds an example of using codex tabs Spikes out the article info flyout and tags flyout using codex.

https://gerrit.wikimedia.org/r/1088618

We talked about this in moderator tools engineering:

  • all of the invisible changes can/should be made as time allows
  • any changes that require a design update need to be discussed with the NPP community and perhaps left for them to implement.
All

Noting some previous discussions on this topic:
T342051#9064115
T127202

And the in progress patch to improve the technical approach to using the current icons:
T376101

Providing a final writeup of the components we discussed creating stories for. For the time being they are components that do not require design updates.

Are there any new components that can/should be used for the Flyouts?

Yes.

FlyoutHeader.vue
Are there any new components that can be of use in any of the un-migrated toolbar modules, like Tags, Mark as Reviewed, Delete, etc.?
Article Info:
Mark As Reviewed:
Tags:
Mark as Deleted:
WikiLove:

Note there are spike patches above for example implementations.

Change #1088618 abandoned by Kgraessle:

[mediawiki/extensions/PageTriage@master] [SPIKE]: Curation Toolbar Vue Migration - Investigate Changes in Codex Component Adds an example of radio inputs Adds an example of checkboxes Adds an example of FlyoutLink component Adds an example of using codex tabs Spikes out the article info flyout and tags flyout using codex.

Reason:

N/A

https://gerrit.wikimedia.org/r/1088618

Change #1085614 abandoned by Kgraessle:

[mediawiki/extensions/PageTriage@master] [SPIKE]: Curation Toolbar Vue Migration - Investigate Changes in Codex Components - Alters icons on page triage bar to use codex icons

Reason:

N/A

https://gerrit.wikimedia.org/r/1085614