Page MenuHomePhabricator

[S] Allow users to hide Year in Review
Closed, ResolvedPublic

Assigned To
None
Authored By
HNordeenWMF
Oct 2 2024, 4:38 PM
Referenced Files
F57689530: Screenshot 2024-11-08 at 10.31.36 AM
Nov 8 2024, 4:31 PM
F57689473: Settings.jpeg
Nov 8 2024, 3:25 PM
F57663892: image.png
Oct 31 2024, 3:17 PM
F57660048: image.png
Oct 30 2024, 4:52 PM
F57660046: image.png
Oct 30 2024, 4:52 PM
F57613369: image.png
Oct 14 2024, 4:12 PM
F57613372: image.png
Oct 14 2024, 4:12 PM
F57613365: image.png
Oct 14 2024, 4:12 PM

Description

Background

The Apps team plans to explore if a personalized Wikipedia Year in Review feature that displays insights about a user's reading history, editing history, and donation history is engaging for App users, and inspires them to make a donation to the Wikimedia Foundation. Users can clear their reading history in the app, but we will also allow users to turn off and clear their Year in Review.

Requirements
  • Add toggle into Settings called "Year in Review" that is automatically on. It can be added below "Explore feed" within Settings. Use SF symbol: timelapse. Reference for toggle → iOS Date & Time.
  • If the toggle is turned off by the user:
    • Clear any year in review reports that have been calculated
    • Remove Year in Review entry point from Profile
    • Do not show tooltip (will be done in T376317)
    • Do not show new feature announcement (will be done in T376316)
  • The toggle should remain in the app for target markets even when Year in Review feature has been disabled from the Config, so that for next year we can use the toggle as an "opt-out" mechanism
  • Change "Hide this feature" from intro slide T376071 to "Learn more", and point to safari view, in users's language of https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/iOS/Personalized_Wikipedia_Year_in_Review/How_your_data_is_used, so users can find instructions on how to clear their Year in Review
Designs
image.png (1×786 px, 607 KB)
image.png (1×786 px, 159 KB)
image.png (1×786 px, 69 KB)
Engineering Notes
  • Update intro slide copy from "hide this feature" to "Learn more"
  • Kick user out to Safari when when "Learn more" is tapped. (Note: in YiR coordinator, we can call navigationController.navigate(to: {url}, useSafari: true))
  • Create new user defaults flag in WMFYearInReviewDataController (similar to how hasPresentedYiRSurvey works) for whether user is hiding feature or not
  • Reference this flag in all the "should` WMFYearInReviewDataController methods (data population, entry point showing, feature announcement showing). Exit early if flag is turned on.
  • Add toggle row in Settings, update user defaults flag when toggle pressed
  • When toggle is turned on: Call a new YiR method that "clears out" their reports. Fetch all YiR report core data objects, clear out each slide's "data" field, and set each slide's evaluated = false and display = false.

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Tsevener updated the task description. (Show Details)
HNordeenWMF renamed this task from Allow users to hide Wikipedia in Review to Allow users to hide Year in Review.Oct 4 2024, 3:23 PM
HNordeenWMF updated the task description. (Show Details)

@scblr

Add toggle into Settings called "Year in Review" that is automatically on. It can be added below "Explore feed" within Settings. Use SF symbol: timelapse. Reference for toggle → iOS Date & Time.

Can you add a quick mock for this? Thanks.

@HNordeenWMF

If a user does not confirm, or chooses "Keep", they should continue on with the first screen and the toggle should remain on

So if they tap Disable > intro screen dismisses and Alert view presents > Tap Keep enabled > Intro screen presents again?

Tsevener renamed this task from Allow users to hide Year in Review to [M] Allow users to hide Year in Review.Oct 4 2024, 4:35 PM
Tsevener updated the task description. (Show Details)

@Tsevener I know it's not shown this way in the designs, but I think it would make most sense if

  • Intro screen is active
  • User chooses "Hide this feature"
  • Alert appears on top of intro screen
    • Keep enabled dismisses alert and they are back on the intro screen
    • Hide > dismisses alert, and intro screen

Is that more straightforward? or more complicated

@Tsevener

Add toggle into Settings called "Year in Review" that is automatically on. It can be added below "Explore feed" within Settings. Use SF symbol: timelapse. Reference for toggle → iOS Date & Time.

Can you add a quick mock for this? Thanks.

image.png (1×786 px, 159 KB)
image.png (1×786 px, 69 KB)
  • Reuses copy from the bottom sheet
  • Reuses the designs from the push notifications section within Settings:
image.png (1×786 px, 159 KB)

@Tsevener I know it's not shown this way in the designs, but I think it would make most sense if

  • Intro screen is active
  • User chooses "Hide this feature"
  • Alert appears on top of intro screen
    • Keep enabled dismisses alert and they are back on the intro screen
    • Hide > dismisses alert, and intro screen

Is that more straightforward? or more complicated

This sounds good to me 👍

HNordeenWMF renamed this task from [M] Allow users to hide Year in Review to [M] Allow users to hide and clear Year in Review.Oct 18 2024, 6:58 PM
HNordeenWMF updated the task description. (Show Details)

@HNordeenWMF

If a user clears their in-app history from the History Tab, clear out the any report object's readCount value

Just a heads up, potentially this could cause the entire YiR entry point to disappear, let me know if that's expected. If the entry point is set up to display only if they have one or more personalized slides to show, and this disables their one personalized slide (because it displays only if 6+ articles have been counted), then the entry point will disappear.

Yes - that's ok & expected for V1.

Tsevener updated the task description. (Show Details)

@Tsevener Legal & Privacy are ok with us removing the "hide this feature" element and toggle, and simply allowing users to clear the data from their Year in Review. I'll split this into 2 tasks, and we can just pick up the "Clear year in review" task for V1: T378196

HNordeenWMF renamed this task from [M] Allow users to hide and clear Year in Review to [M] Allow users to hide Year in Review.Oct 25 2024, 5:02 PM
HNordeenWMF updated the task description. (Show Details)
HNordeenWMF updated the task description. (Show Details)
Tsevener updated the task description. (Show Details)
Tsevener renamed this task from [M] Allow users to hide Year in Review to Allow users to hide Year in Review.Oct 31 2024, 6:16 PM

Removing estimate in title for now until we officially re-estimate.

Tsevener renamed this task from Allow users to hide Year in Review to [S] Allow users to hide Year in Review.Nov 1 2024, 4:32 PM
Tsevener updated the task description. (Show Details)

@HNordeenWMF

We have a few options on these in-app web view links:

  1. We could tack on the device language code to the end of the url.
  2. We could tack on the primary app language code to the end of the url.
  3. We could navigate to https://www.mediawiki.org/wiki/Special:MyLanguage/Wikimedia_Apps/Team/iOS/Personalized_Wikipedia_Year_in_Review/How_your_data_is_used, and the interface language they have chosen in web preferences will be used. (Inspired by https://phabricator.wikimedia.org/T377887#10254625).

So far we have been going with #2, but just let us know if you'd rather us change that.

Thanks @Tsevener, fine with #1 or #2. The language that YiR is presented in looks like it's based on device language, so I think #1 would make slightly more sense if it's not too hard to update.

Settings.jpeg (2×1 px, 164 KB)

It looks good/works well, @Tsevener, but please update this copy to:

Turning off Year in Review will clear all stored personalized insights and hide the Year in Review.

See Figma.