Page MenuHomePhabricator

[M] Edit views personalized slide: “Your edits were viewed 7,000 times”
Closed, ResolvedPublic

Assigned To
None
Authored By
HNordeenWMF
Oct 2 2024, 10:45 PM
Referenced Files
F58029599: image.png
Dec 19 2024, 11:11 AM
F58029602: image.png
Dec 19 2024, 11:11 AM
F57584136: image.png
Oct 2 2024, 10:45 PM
F57584134: image.png
Oct 2 2024, 10:45 PM

Description

Background

The Apps team plans to explore if a personalized Wikipedia in Review feature that displays insights about a user's reading history, editing history, and donation history is engaging for App users, and inspires them to make a donation to the Wikimedia Foundation.

Requirements
  • Display only if a user has edited one or more articles. If they don't meet this criteria, show the collective version.
  • Show a total pageview count from the GrowthImpactAPI for the language the user has set as primary in the app

Nice-to-have

  • List titles of top articles (up to 3) with their view counts

If nice-to-have is not included, copy should read

Your edits have been viewed more than XXX times recently
Readers around the world appreciate your contributions. In the last 2 months, articles you've edited have received xxx total views. Thanks to editors like you, Wikipedia is a steadily improving, fact-based, and reliable knowledge resource for to the world

Designs
image.png (786×1,704 px, 121 KB)
image.png (786×1,704 px, 114 KB)
PersonalizedCollective
Engineering Notes
  • (data half) Upon app resume, pull persisted slide item object for this slide identifier. If evaluated = no and they are logged in, and remote config does not have a personalized slide kill switch (viewCount), fetch their viewed counts from the growth user impact module endpoint (example, using userID as a parameter). Collect relevant viewed counts, persist as metadata in slide object. Set evaluated = yes. Set display = yes if numbers > 0.
  • (UI half) Ensure that when we create the view models before presenting slides (see T376044), fetch the persisted model from previous bullet point. If display = yes, build a slide view model for this data (using the report model's metadata). Ensure slide view model is inserted into the correct order, and that associated collective "fallback" slide is NOT inserted.

Event Timeline

Tsevener renamed this task from Edit views personalized slide: “Your edits were viewed 7,000 times” to [M] Edit views personalized slide: “Your edits were viewed 7,000 times”.Oct 4 2024, 3:24 PM
Tsevener subscribed.

@HNordeenWMF

Open question: Is this easiest to limit to the language that they have set as primary in the app)

Yes, that would be easier, I don't see a way to fetch these numbers globally through the growth API.

Estimating assuming it's just for the primary language in the app.

HNordeenWMF updated the task description. (Show Details)

Data-side can be started using old designs as reference. Move to blocked and waiting once ready for updated illustrations.

I spotted a minor copy difference @Tsevener

DesignvsImplementation
Your edits have been viewed more than XXX times recentlyYour edits were viewed more than XXX times recently

@GOlson-WMF I happened to notice a few things on this slide (feel free to wait to work on them until @scblr has done full design review tho)

  • the Donation button is missing from the top left.
  • The number isn't formatted with commas/periods for my device country, for example as a user in the US, 52,394 is more readable than 52294.

@GOlson-WMF I happened to notice a few things on this slide (feel free to wait to work on them until @scblr has done full design review tho)

  • the Donation button is missing from the top left.
  • The number isn't formatted with commas/periods for my device country, for example as a user in the US, 52,394 is more readable than 52294.

+1 to Haley’s comments (missing donate button + number formatting)

I see 2781 — it should be 2'781. My Language & Region settings are below.

image.png (1,179×2,556 px, 721 KB)
image.png (1,179×2,556 px, 225 KB)

Other than that — great work @GOlson-WMF!

Can be reviewed again in TestFlight 7.6.3 (4669).

@Tsevener @GOlson-WMF someting is happening with this slide, where it doesn't seem the reports are clearing with log-in/log-out like the other slides (https://phabricator.wikimedia.org/T378135). let me know if you need access to my test accounts to reproduce.

Scenario 1

  • Steps
    • Log into account with 0 edits
    • Observe this slide is not displayed (as expected)
    • Log into an account with edits
    • Observe this slide is not displayed
  • Expected behavior:
    • This slide is displayed when logged-into an account with edits

Scenario 2

  • Steps
    • Log into account with edits
    • Observe this slide is displayed (as expected)
    • Log into an account with 0 edits
    • Observe this slide is still displayed
  • Expected behavior:
    • This slide is not displayed when logged-into an account with 0 edits