Page MenuHomePhabricator

Build summary UI for browser extension
Open, HighPublic3 Estimated Story Points

Description

Background

  • After testing the design and validating that summaries have potential as web team feature, we would like to proceed with building out the prototype for the summary feature to be used in the browser extension

User story

  • As a Wikipedia browser extension user, I would like to be shown the summary feature so that I can gain more knowledge from Wikipedia quickly
  • As a product team, we would like to learn about usage patterns of the new summary feature so that we can determine whether

Requirements

  • Summary opens through user actions (i.e. user opens accordion)
  • If no summary is available, the element does not show on page
  • If summary does not load, an error state is displayed: "We could not load the summary for this page"
  • Summaries would only show on English Wikipedia
  • Buttons: upon clicking button would show in selected state. No other system feedback will be provided. Button can only be clicked once per page. Buttons are in Codex.

BDD

  • For QA engineer to fill out

Test Steps

  • For QA engineer to fill out

Design

closed

image.png (2×2 px, 752 KB)

open
image.png (2×2 px, 706 KB)

Toggle button on
image.png (2×2 px, 707 KB)

Acceptance criteria

  • This ticket is to build out the code for the summary UI NOT for deploying the experiment
  • Build out experiment as per requirmenets above

Communication criteria - does this need an announcement or discussion?

  • N/A

Rollback plan

  • N/A

This task was created by Version 1.2.0 of the Web team task template using phabulous

Event Timeline

ovasileva removed NBaca-WMF as the assignee of this task.
ovasileva triaged this task as High priority.

Current FPO designs:
closed (default):

image.png (2×2 px, 752 KB)

expanded:
image.png (2×2 px, 706 KB)

expanded, toggle button selected:
image.png (2×2 px, 707 KB)

Note from grooming:
Do we need a loading state for the accordion? Probably not, but if there is one from the accordion component itself maybe we can use that

ovasileva updated the task description. (Show Details)

@JScherer-WMF I was looking at the feedback (yes/no) buttons at the bottom, I'm assuming they should stay "pressed" after clicking right? So is this essentially a ToggleButton from codex? Also do you have the link to the figma so i can get more exact values?

@JScherer-WMF Can you paste the full text for "How was this made" with the links?

@JScherer-WMF I was looking at the feedback (yes/no) buttons at the bottom, I'm assuming they should stay "pressed" after clicking right? So is this essentially a ToggleButton from codex? Also do you have the link to the figma so i can get more exact values?

That's right. I assumed we'd use the toggle buttons from codex. Here's the Figma File

Here's the How this was made text:

This summary was machine-generated by the Wikimedia Foundation using a large language model called Aya on <date>. This is an experimental feature that does not follow Wikipedia’s accepted editorial process. This summary has not been checked for verifiable accuracy or a neutral point of view.

Jdlrobson added a subscriber: Jdrewniak.

Justin is currently QAing this

Screenshot 2024-11-01 at 11.43.04 AM.png (1×3 px, 510 KB)
Screenshot 2024-11-01 at 12.01.07 PM.png (1×1 px, 331 KB)

Bugs - closed state:

  • Not all articles on the article spreadsheet load simple summaries. @Jdrewniak thinks this is because of spaces or other special characters in the titles.
  • Simple summary accordion should adopt the horizontal constraints of the first paragraph (usually this means it will get "squished" by an infobox)
  • Simple summary should appear below all the hatnote content, directly above the first article paragraph
  • Vertical spacing should be 12 px above the "View simple summary" title and 2px between title and subtitle
  • View simple summary title and "Unverified" tag should be vertically centre aligned.
  • subtitle should be subtle colour
  • Title should read "View simple summary" not "summaries"
  • "Machine generated" should read "Machine-generated" It's missing a hyphen.
  • accordion should have a border-subtle bottom border.
  • Cursor should change to "pointer" on hover

Open state:

  • Subtitles should be color-subtle
  • body paragraphs should be color-base
  • toggle button icons should be color-subtle
  • yes/no buttons should have 8px horizontal spacing between them.

I was under the assumption that most/all of these styles would be baked into codex, so i'm not sure if the styles are loading properly.
Here's the dev-mode Figma link for reference.

Passing back to you @bwang and placing in Needs more work. Let me know if you have any questions :)

Also a tiny tweak: I switched the icons in the toggle buttons to be more consistent with other flows.

Screenshot 2024-11-01 at 12.11.32 PM.png (202×502 px, 14 KB)

Also, we're using the wrong logo for the extension. It should be the Wikipedia "W" logo.

bwang removed bwang as the assignee of this task.Nov 4 2024, 4:38 PM
bwang claimed this task.

Couple small things:

  • The toggle button's on-state isn't accessible because the icon colour doesn't change to accommodate the dark blue background. The icon colour should change on the dark background.
    Screenshot 2024-11-07 at 11.03.46 AM.png (344×576 px, 44 KB)
  • The link for "neutral point of view" in the disclaimer is pointing to the wrong place. It should point to https://en.wikipedia.org/wiki/Wikipedia:Neutral_point_of_view.
  • The info chip looks wrong. I brought it up with DST in Slack and cc'd you @bwang
  • 2 typos in the disclaimer: "This simple summaries" should be "This simple summary" and "This summaries" in the last paragraph should be "This summary"

Moving back to needs more work and assigning to you @bwang to clean up these little bugs. Otherwise it's looking really good!

Couple small things:

  • The toggle button's on-state isn't accessible because the icon colour doesn't change to accommodate the dark blue background. The icon colour should change on the dark background.
    Screenshot 2024-11-07 at 11.03.46 AM.png (344×576 px, 44 KB)
  • The link for "neutral point of view" in the disclaimer is pointing to the wrong place. It should point to https://en.wikipedia.org/wiki/Wikipedia:Neutral_point_of_view.
  • The info chip looks wrong. I brought it up with DST in Slack and cc'd you @bwang
  • 2 typos in the disclaimer: "This simple summaries" should be "This simple summary" and "This summaries" in the last paragraph should be "This summary"

DST has confirmed that the infochip should look like this

Screenshot 2024-11-07 at 11.34.11 AM.png (160×308 px, 9 KB)

So that's a bug, too.

The follow-up has been merged, when it’s been reviewed this can be signed off

@JScherer-WMF here's a build with the latest changes. Looks like the verbage and button icons have been fixed. I looked into the infoChip color and I'm not sure why it doesn't get the yellow background, we're using the same code that's described in the docs:

<CdxInfoChip class="summary-prompt-chip" status="warning">
	{{ i18n.summariesChip }}
</CdxInfoChip>

Oh, looks like I just needed to update my version of Codex via npm update looks better in the following build.