Background
In [https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/1071207 this patch] logic was added to Minerva to change the location of the "Data item" link prior to rendering.
While we have done this historically, it has led to confusion as it requires referencing multiple extensions to understand logic; it creates unclear who is accountable for the code when it breaks as the code operates in multiple boundaries; and it adds constraints to skin developers who may need to make rendering changes
It is proposed that this logic is moved into Wikibase at the time the link is inserted into the menu.
BDD
- For QA engineer to fill out
Test Steps
- For QA engineer to fill out
Acceptance criteria
- There should be no logic in Minerva for relocating the wikibase link.
- The wikibase link should appear in the toolbox on Minerva
- The wikibase link should appear in "Other projects" on other skins
Why this is important
- For skins we have been working towards migrating all menu manipulation towards the https://www.mediawiki.org/wiki/Manual:Hooks/SkinTemplateNavigation::Universal hook. In future we hope this would replace SidebarBeforeOutput hook for menu manipulation. We already moved categories there for example.
- We have been slowly making Minerva compatible with all desktop menus and hooks. In future, as written it's possible that when Minerva supports sidebar, you'd have two links in 2 different places.
This task was created by Version 1.2.0 of the Web team task template using phabulous