Page MenuHomePhabricator
Create Task
Maniphest T37642

[SF] User must be prevented from uploading until JavaScript finishes loading
Closed, ResolvedPublicBUG REPORT
Actions

Description

video of clicking the upload link before JS loads in Opera

If the user tries to upload a file before SF's JavaScript fully loads, the upload will succeed, but the uploaded file will be "lost", as described here:

http://www.mediawiki.org/wiki/Extension_talk:Semantic_Forms#Upload_not_inserting_images_into_forms

In short, semantic data can't be applied if the user clicks the upload link before the JavaScript fully loads, because the upload popup displays full-page instead of as a popup.

The solution to Bug 32424 might also solve this problem. Basically, the upload field and link should only be shown in certain circumstances. By using JS to display the link, the user will have to wait for the JS to load before they can use it.

I tested this bug in Opera and Google Chrome. I was able to duplicate it in Opera, but not in Chrome. A short video screen capture is attached.

Version: unspecified
Severity: normal

Attached:

semantic_forms_2.4.2_file_upload_before_JS_loads_popup_Video_2012-04-01_201626.wmv149 KBDownload

Details

Reference
bz35642

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:17 AM
• bzimport added a project: MediaWiki-extensions-Page_Forms.
• bzimport set Reference to bz35642.
Badon created this task.Apr 2 2012, 2:19 AM
Aklapper removed Yaron_Koren as the assignee of this task.Sep 2 2015, 3:54 PM
Restricted Application added subscribers: Steinsplitter, Aklapper. · View Herald TranscriptSep 2 2015, 3:54 PM
Himanshuc3 subscribed.EditedJan 23 2018, 9:22 AM

I propose that the Upload button should be disabled by default and enabled for working at the end of Javascript file.

Edit: Nevermind, it was already solved I guess.

Aklapper triaged this task as Low priority.Feb 4 2022, 8:07 PM
Aklapper changed the subtype of this task from "Task" to "Bug Report".
Yaron_Koren closed this task as Resolved.Apr 25 2023, 11:35 PM
Yaron_Koren claimed this task.
Yaron_Koren subscribed.

I think this is fixed...

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL