⚓ T376488 Implement SUL3 central login for temp users

Subject	Repo	Branch	Lines +/-
Trigger edge-login for newly created temporary accounts	mediawiki/extensions/CentralAuth	master	+5 -2
CentralAuthSessionProvider: Fix race condition in central login	mediawiki/extensions/CentralAuth	master	+10 -2
Special: Add support for central autologin in SUL3 mode	mediawiki/extensions/CentralAuth	master	+374 -114

Status	Assigned	Task
Open	None	T345245 Mitigate phase-out of third-party cookies in Wikimedia production
Resolved	• Tgr	T345249 Mitigate phase-out of third-party cookies in CentralAuth
Resolved	OWresch-WMF	T348388 SUL3: Use a dedicated domain for login and account creation
Resolved	• Tgr	T362713 Implement the new login process which redirects to the central login wiki for showing the login/signup form
Resolved	DAlangi_WMF	T376488 Implement SUL3 central login for temp users
Open	None	T377561 "Keep me logged in" flag unreliable on the central domain

• Tgr created this task.Oct 4 2024, 4:48 PM

Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptOct 4 2024, 4:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• Tgr added a parent task: T362713: Implement the new login process which redirects to the central login wiki for showing the login/signup form.Oct 4 2024, 4:48 PM

• Tgr moved this task from Backlog to Ready on the SUL3 board.Oct 14 2024, 7:15 PM

kostajh moved this task from Inbox to Backlog on the Temporary accounts board.Oct 15 2024, 8:24 AM

• Tgr merged a task: T377141: Enable SUL3 central login for temporary accounts.Oct 15 2024, 9:42 AM

• Tgr moved this task from Inbox, needs triage to Needs refinement on the MediaWiki-Platform-Team board.Oct 15 2024, 10:02 AM

Change #1078400 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/CentralAuth@master] Special: Add support for central auto login in SUL3 mode

https://gerrit.wikimedia.org/r/1078400

gerritbot added a project: Patch-For-Review.Oct 16 2024, 12:42 PM

Krinkle renamed this task from Implement SUL3 central login to Implement SUL3 central login for temp users.Oct 16 2024, 2:41 PM

kostajh subscribed.Oct 18 2024, 9:18 AM

Assigning to @DAlangi_WMF since the patch he is working on is covering this as well.

• Tgr moved this task from Ready to In progress on the SUL3 board.Oct 20 2024, 3:22 PM

• Tgr mentioned this in T378722: Application Security Review Request : SUL3.Oct 31 2024, 8:52 PM

DAlangi_WMF changed the task status from Open to In Progress.Nov 19 2024, 9:50 AM

Change #1078400 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Special: Add support for central autologin in SUL3 mode

https://gerrit.wikimedia.org/r/1078400

Maintenance_bot removed a project: Patch-For-Review.Dec 1 2024, 7:30 PM

DAlangi_WMF added a parent task: T377561: "Keep me logged in" flag unreliable on the central domain.Dec 16 2024, 9:29 AM

DAlangi_WMF removed a parent task: T377561: "Keep me logged in" flag unreliable on the central domain.

DAlangi_WMF added a subtask: T377561: "Keep me logged in" flag unreliable on the central domain.

Restricted Application added a project: Trust and Safety Product Team. · View Herald TranscriptDec 16 2024, 9:30 AM

@Tgr, with https://gerrit.wikimedia.org/r/c/1078400 merged, temp account central login for the shared domain works but is still sometimes affected by T377561: "Keep me logged in" flag unreliable on the central domain sometimes.

Technically speaking, this is done, maybe we should resolve this task and continue work on T377561: "Keep me logged in" flag unreliable on the central domain instead?

Change #1104635 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/CentralAuth@master] Trigger edge-login for temporary accounts in SUL3 mode

https://gerrit.wikimedia.org/r/1104635

gerritbot added a project: Patch-For-Review.Dec 16 2024, 1:26 PM

DAlangi_WMF triaged this task as Low priority.Dec 16 2024, 1:27 PM

DAlangi_WMF changed the status of subtask T377561: "Keep me logged in" flag unreliable on the central domain from Open to In Progress.

Change #1104619 had a related patch set uploaded (by Gergő Tisza; author: Derick Alangi):

[mediawiki/extensions/CentralAuth@master] CentralAuthSessionProvider: Fix race condition in central login

https://gerrit.wikimedia.org/r/1104619

Yeah I think this is done. I'm not sure the problem you are running into is the same as T377561 (which is about the browser preventing a request), but either way, it doesn't seem specific to SUL3. T377561 is definitely happening in production today.

DAlangi_WMF closed this task as Resolved.Dec 17 2024, 8:37 AM

Change #1104619 abandoned by D3r1ck01:

[mediawiki/extensions/CentralAuth@master] CentralAuthSessionProvider: Fix race condition in central login

Reason:

MediaWiki CLI's `mysql-replica` service (even with containers not running - stopped) seems to have caused this someone. Destroying the service entirely seems to have resolved this issue for me locally.

https://gerrit.wikimedia.org/r/1104619

Change #1104635 abandoned by D3r1ck01:

[mediawiki/extensions/CentralAuth@master] Trigger edge-login for newly created temporary accounts

https://gerrit.wikimedia.org/r/1104635

DAlangi_WMF changed the status of subtask T377561: "Keep me logged in" flag unreliable on the central domain from In Progress to Open.Jan 7 2025, 3:56 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 7 2025, 4:31 PM

• Tgr mentioned this in T377140: Adapt user experience to expose the progressive rollout with a fallback link.Jan 22 2025, 2:50 PM