Page MenuHomePhabricator

Fix support for supplying patchset IDs when passing a change ID to Quibble
Closed, ResolvedPublic

Description

Quibble supports a --change argument that allows users to supply a change ID. This is helpful for testing patches locally (environments where git://contint1002.wikimedia.org is not available).

The implementation in util.py supports fetching patchsets (e.g. FetchInfo.change(12345, 42)), but the code that calls it (cmd.py#L197) only ever calls FetchInfo.change with a single argument. This fails with an HTTP 400 error in the case that the --change argument is, for example, 12345,42.

Enhance the current implementation in cmd.py so that patchset arguments can be processed.

When this support is added, the corresponding code in jenkins-run-analysis can be updated to also process / handle patchsets.

Event Timeline

Change #1078610 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[integration/quibble@master] Add support for specifying patchsets with `--change` CLI argument

https://gerrit.wikimedia.org/r/1078610

Change #1078610 merged by jenkins-bot:

[integration/quibble@master] Add support for specifying patchsets with `--change` CLI argument

https://gerrit.wikimedia.org/r/1078610

Change #1085417 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] dockerfiles: update Quibble to 1.11.0

https://gerrit.wikimedia.org/r/1085417

Change #1085417 merged by jenkins-bot:

[integration/config@master] dockerfiles: update Quibble to 1.11.0

https://gerrit.wikimedia.org/r/1085417

Change #1085426 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] jjb: switch jobs to Quibble 1.11.0

https://gerrit.wikimedia.org/r/1085426

Change #1085426 merged by jenkins-bot:

[integration/config@master] jjb: switch jobs to Quibble 1.11.0

https://gerrit.wikimedia.org/r/1085426