Page MenuHomePhabricator

PHP Notice: Undefined index: gettoken in includes/api/ApiMain.php on line 598
Closed, ResolvedPublic

Description

PHP Notice: Undefined index: gettoken in /www/w/includes/api/ApiMain.php on line 598

Probable cause is https://gerrit.wikimedia.org/r/#change,3434


Version: 1.20.x
Severity: normal

Details

Reference
bz35671
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Sync up DagProperties of dumps_merge_events_to_wikitext_raw_daily with overrides.repos/data-engineering/airflow-dags!906xcollazoupdate-dag-propertiesmain
Go back to copy-on-write for MERGE INTOs and DELETEs.repos/data-engineering/mediawiki-content-pipelines!43xcollazogo-back-to-copy-on-writemain
builds-builder: add script to migrate pipelineruns from v1beta1 to v1repos/cloud/toolforge/toolforge-deploy!554dcaroadd_pr_v1_migration_scriptmain
d/changelog: bump to 1.6.4repos/cloud/toolforge/toolforge-weld!61dcarobump_toolforge-weldmain
d/changelog: bump to 1.6.4repos/cloud/toolforge/toolforge-weld!60dcarobump_versionmain
api_client: increase timeout to 20srepos/cloud/toolforge/toolforge-weld!59dcaroincrease_timeoutmain
Customize query in GitLab

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 12:19 AM
bzimport set Reference to bz35671.

Yay to whoever added gettoken only on few modules

if ( $salt !== false && !$moduleParams['gettoken'] ) {

to

if ( $salt !== false && isset( $moduleParams['gettoken'] ) && !$moduleParams['gettoken'] ) {

I guess...

comment 1 would bring back bug 34212

See commit message of https://gerrit.wikimedia.org/r/#change,4159

(In reply to comment #2)

comment 1 would bring back bug 34212

See commit message of https://gerrit.wikimedia.org/r/#change,4159

We're still doing the check on the value, but only if we have that parameter set, and hence something to check the value of...

I just tested it, that fix works fine, and doesn't regress on bug 34212