As seen in this comment: https://w.wiki/BTde our query runner doesn't offer the possibility to escape double quotes at query time, this was used in clone.py, and might be needed elsewhere.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| mysql_legacy: double quote escape in run_query | operations/software/spicerack | master | +20 -8 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Unknown Object (Task) | |||||
| Resolved | Jhancock.wm | T342174 Q1:rack/setup/install db21[88-95] | |||
| Resolved | ABran-WMF | T343674 Productionize db21[88-95] | |||
| Resolved | Volans | T362893 Spicerack support for dbctl | |||
| Resolved | ABran-WMF | T368881 Make sre.mysql.clone handling pooling/depooling | |||
| In Progress | FCeratto-WMF | T384810 MariaDB lifetime management system | |||
| In Progress | FCeratto-WMF | T239814 Automate DB upgrades | |||
| Resolved | None | T374191 upgrade clone cookbook | |||
| Declined | ABran-WMF | T376712 mysql_legacy: SQL query quote escape |
Event Timeline
Comment Actions
Change #1078658 had a related patch set uploaded (by Arnaudb; author: Arnaudb):
[operations/software/spicerack@master] mysql_legacy: double quote escape in run_query
Comment Actions
Change #1078658 abandoned by Arnaudb:
[operations/software/spicerack@master] mysql_legacy: double quote escape in run_query
Reason:
https://gerrit.wikimedia.org/r/c/operations/software/spicerack/+/1078658/comments/575e98e0_c38ec8c5