Clean up UserrightsPage::userCanChangeRights
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Krenair
	Apr 3 2012, 4:51 PM

Description

UserrightsPage::userCanChangeRights's return statement is virtually impossible to try to understand and modify.

Version: unspecified
Severity: trivial

Details

Reference: bz35674

	Subject	Repo	Branch	Lines +/-
	SpecialUserrights: Improve ::userCanChangeRights() method logic	mediawiki/core	master	+14 -6

Customize query in gerrit

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 12:19 AM

• bzimport added a project: MediaWiki-Special-pages.

• bzimport set Reference to bz35674.

• bzimport added a subscriber: Unknown Object (MLST).

Krenair created this task.Apr 3 2012, 4:51 PM

Krinkle added a project: Technical-Debt.Dec 10 2014, 2:10 PM

Krinkle set Security to None.

Krinkle removed a subscriber: Unknown Object (MLST).

• Reguyla moved this task from To triage to User/User rights on the MediaWiki-Special-pages board.May 26 2015, 11:59 AM

Danny_B moved this task from Unsorted to Cleanup on the Technical-Debt board.Jan 22 2016, 11:37 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 22 2016, 11:37 PM

Krinkle edited projects, added MediaWiki-User-management; removed MediaWiki-Special-pages.May 8 2017, 12:00 AM

Krinkle moved this task from Backlog to User rights on the MediaWiki-User-management board.May 8 2017, 12:01 AM

Change 498639 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/core@master] SpecialUserrights: Improve ::userCanChangeRights() method logic

https://gerrit.wikimedia.org/r/498639

gerritbot added a project: Patch-For-Review.Mar 23 2019, 1:04 PM

xSavitar claimed this task.Apr 28 2019, 10:00 PM

Restricted Application added a project: User-xSavitar. · View Herald TranscriptApr 28 2019, 10:00 PM

xSavitar moved this task from Backlog to Doing [WIP] on the User-xSavitar board.Apr 28 2019, 10:00 PM

Change 498639 merged by jenkins-bot:
[mediawiki/core@master] SpecialUserrights: Improve ::userCanChangeRights() method logic

https://gerrit.wikimedia.org/r/498639

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 29 2019, 1:00 AM

xSavitar closed this task as Resolved.Apr 29 2019, 8:28 AM

xSavitar moved this task from Doing [WIP] to Reviewed/Resolved on the User-xSavitar board.

Clean up UserrightsPage::userCanChangeRightsClosed, ResolvedPublicActions

Description

Details

Event Timeline

Clean up UserrightsPage::userCanChangeRights
Closed, ResolvedPublic
Actions