Configure the CampaignEvents extension to use the event-organizer group by default
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Daimona
	Oct 9 2024, 4:18 PM

Description

The extension's default configuration (in extension.json) is that every user gets all the organizer rights. However, in WMF wikis, the default is only used in test wikis (and beta). With the extension being enabled on more and more wikis, it might make sense to have the event-organizer group by default, either in the extension config, or WMF config. This way, we wouldn't have to add all the boilerplate that is currently required when enabling the extension on a new wiki (see e.g. T376786).

Acceptance criteria

The event-organizer group is defined by default in the CampaignEvents extension
All the individual wiki definitions of the event-organizer group are removed from WMF config
Overall, no visible changes to the permission setup in WMF wikis

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Let sysops add/remove the event-organizer group by default	operations/mediawiki-config	master	+2 -0
test(2)wiki: Re-assign event organizer rights to all users	operations/mediawiki-config	master	+6 -0
core-Permissions: drop redundant CampaignEvents right assignments	operations/mediawiki-config	master	+4 -208
Create event organizer group by default	mediawiki/extensions/CampaignEvents	master	+53 -21
build: Update wdio-mediawiki to 2.7.0	mediawiki/extensions/CampaignEvents	master	+8 -8
selenium: Add `api.addUserToGroup()` to add user to a user group	mediawiki/core	master	+38 -0
test(2)wiki: Explicitly assign event organizer rights to all users	operations/mediawiki-config	master	+6 -0

Customize query in gerrit

Related Objects

Mentioned In: T389863: api-testing CI failure: Timeout of 5000ms exceeded in "before all" hook in "POST /campaignevents/v0/event_registration"
T387943: Disable the event-organizer group in officewiki
T386738: Consider removal of $wgAddGroups and $wgRemoveGroups added for the event-organizer group in WMF config
T386622: Release CampaignEvents extension to French Wikipedia
T381423: Remove feature flag for event topics
T380076: Remove feature flag for event wikis
T383154: Release CampaignEvents extension to Indonesian, Italian, Malay, and Polish Wikipedia
Mentioned Here: T386210: Setting wgAddGroups and wgRemoveGroups in extension.json is not supported
T380076: Remove feature flag for event wikis
T381423: Remove feature flag for event topics
T376786: Release CampaignEvents extension to Spanish Wikipedia [Oct 22, 14:00 UTC]

Event Timeline

Daimona created this task.Oct 9 2024, 4:18 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 9 2024, 4:18 PM

ifried set the point value for this task to 2.Jan 13 2025, 5:13 PM

ifried edited projects, added Connection-Team (Connection-Current-Sprint); removed Connection-Team.

ifried moved this task from Upcoming / refining 💡 to Ready for development on the Connection-Team (Connection-Current-Sprint) board.

Change #1111224 had a related patch set uploaded (by Mhorsey; author: Mhorsey):

[mediawiki/extensions/CampaignEvents@master] set sensible defaults for permission in the extension config.

https://gerrit.wikimedia.org/r/1111224

gerritbot added a project: Patch-For-Review.Jan 14 2025, 1:44 PM

Change #1111227 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[operations/mediawiki-config@master] test(2)wiki: Explicitly assign event organizer rights to all users

https://gerrit.wikimedia.org/r/1111227

Change #1111227 merged by jenkins-bot:

[operations/mediawiki-config@master] test(2)wiki: Explicitly assign event organizer rights to all users

https://gerrit.wikimedia.org/r/1111227

Mentioned in SAL (#wikimedia-operations) [2025-01-14T14:31:21Z] <lucaswerkmeister-wmde@deploy2002> Started scap sync-world: Backport for [[gerrit:1111227|test(2)wiki: Explicitly assign event organizer rights to all users (T376822)]]

Lucas_Werkmeister_WMDE awarded a token.Jan 14 2025, 2:31 PM

Mentioned in SAL (#wikimedia-operations) [2025-01-14T14:37:47Z] <lucaswerkmeister-wmde@deploy2002> daimona, lucaswerkmeister-wmde: Backport for [[gerrit:1111227|test(2)wiki: Explicitly assign event organizer rights to all users (T376822)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2025-01-14T14:53:47Z] <lucaswerkmeister-wmde@deploy2002> Finished scap sync-world: Backport for [[gerrit:1111227|test(2)wiki: Explicitly assign event organizer rights to all users (T376822)]] (duration: 22m 26s)

Daimona moved this task from Ready for development to Code Review 💬 on the Connection-Team (Connection-Current-Sprint) board.Jan 14 2025, 6:41 PM

Daimona updated the task description. (Show Details)

Daimona mentioned this in T383154: Release CampaignEvents extension to Indonesian, Italian, Malay, and Polish Wikipedia.Jan 17 2025, 2:28 PM

MHorsey-WMF claimed this task.Jan 20 2025, 10:42 AM

Change #1008074 had a related patch set uploaded (by Mhorsey; author: Vaughn Walters):

[mediawiki/core@master] selenium: Add `api.addUserToGroup()` to add user to a user group

https://gerrit.wikimedia.org/r/1008074

Change #1113491 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] [WIP] build: Update wdio-mediawiki to 2.7.0

https://gerrit.wikimedia.org/r/1113491

Change #1008074 merged by jenkins-bot:

[mediawiki/core@master] selenium: Add `api.addUserToGroup()` to add user to a user group

https://gerrit.wikimedia.org/r/1008074

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.15; 2025-02-04).Jan 29 2025, 12:00 PM

Change #1113491 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] build: Update wdio-mediawiki to 2.7.0

https://gerrit.wikimedia.org/r/1113491

Change #1111224 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Create event organizer group by default

https://gerrit.wikimedia.org/r/1111224

Maintenance_bot removed a project: Patch-For-Review.Feb 3 2025, 4:30 PM

Change #1116834 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[operations/mediawiki-config@master] core-Permissions: drop redundant CampaignEvents right assignments

https://gerrit.wikimedia.org/r/1116834

gerritbot added a project: Patch-For-Review.Feb 3 2025, 4:42 PM

Only thing left to do is cleaning up the WMF config, which needs to wait for r1111224 to reach production.

Daimona moved this task from Blocked ⛔ to Development In Progress 💻 on the Connection-Team (Connection-Current-Sprint) board.Feb 10 2025, 5:39 PM

Scheduled for tomorrow 2025-02-11 14:00 UTC.

Change #1116834 merged by jenkins-bot:

[operations/mediawiki-config@master] core-Permissions: drop redundant CampaignEvents right assignments

https://gerrit.wikimedia.org/r/1116834

Mentioned in SAL (#wikimedia-operations) [2025-02-11T14:05:22Z] <urbanecm@deploy2002> Started scap sync-world: Backport for [[gerrit:1118604|Drop obsolete CampaignEvents config flags (T380076 T381423)]], [[gerrit:1116834|core-Permissions: drop redundant CampaignEvents right assignments (T376822)]]

Stashbot mentioned this in T381423: Remove feature flag for event topics.Feb 11 2025, 2:05 PM

Mentioned in SAL (#wikimedia-operations) [2025-02-11T14:09:55Z] <urbanecm@deploy2002> daimona, urbanecm: Backport for [[gerrit:1118604|Drop obsolete CampaignEvents config flags (T380076 T381423)]], [[gerrit:1116834|core-Permissions: drop redundant CampaignEvents right assignments (T376822)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2025-02-11T14:19:34Z] <urbanecm@deploy2002> Finished scap sync-world: Backport for [[gerrit:1118604|Drop obsolete CampaignEvents config flags (T380076 T381423)]], [[gerrit:1116834|core-Permissions: drop redundant CampaignEvents right assignments (T376822)]] (duration: 14m 11s)

Maintenance_bot removed a project: Patch-For-Review.Feb 11 2025, 2:31 PM

Change #1118820 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[operations/mediawiki-config@master] test(2)wiki: Re-assign event organizer rights to all users

https://gerrit.wikimedia.org/r/1118820

Change #1118820 merged by jenkins-bot:

[operations/mediawiki-config@master] test(2)wiki: Re-assign event organizer rights to all users

https://gerrit.wikimedia.org/r/1118820

Mentioned in SAL (#wikimedia-operations) [2025-02-11T14:35:59Z] <urbanecm@deploy2002> Started scap sync-world: Backport for [[gerrit:1118820|test(2)wiki: Re-assign event organizer rights to all users (T376822)]]

Mentioned in SAL (#wikimedia-operations) [2025-02-11T14:40:39Z] <urbanecm@deploy2002> urbanecm, daimona: Backport for [[gerrit:1118820|test(2)wiki: Re-assign event organizer rights to all users (T376822)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2025-02-11T14:48:19Z] <urbanecm@deploy2002> Finished scap sync-world: Backport for [[gerrit:1118820|test(2)wiki: Re-assign event organizer rights to all users (T376822)]] (duration: 12m 20s)

Daimona moved this task from Development In Progress 💻 to QA 🐛 on the Connection-Team (Connection-Current-Sprint) board.Feb 11 2025, 2:49 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 11 2025, 3:32 PM

Hi Devs, Administrators and Bureaucrats on Wikidata and Meta-Wiki are not able to assign or remove the event-organizer permission anymore. I assume this is a mistake? Can someone have a look into that? I think that change is related to this Ticket.

In T376822#10542726, @TenWhile6 wrote:

Hi Devs, Administrators and Bureaucrats on Wikidata and Meta-Wiki are not able to assign or remove the event-organizer permission anymore. I assume this is a mistake? Can someone have a look into that? I think that change is related to this Ticket.

Ugh, yeah that's unexpected. Sorry about that! I'll try to get this fixed in the upcoming deployment window (14:00 UTC, in 50 minutes).

I see what happened. With r1111224, the CampaignEvents extension by default allows admins to add/remove the event-organizer group. However, for reasons that I don't fully grasp, our production config sets a different default for wgAddGroups, effectively erasing any defaults set by extensions. The only reason why I can see this being the case is that $wgAddGroups is empty by default in MediaWiki core, so whoever added the default probably 20 years ago thought it wouldn't make any difference. After all, there are only a few extensions that change this.

However:

In T376822#10542726, @TenWhile6 wrote:

Administrators and Bureaucrats on Wikidata and Meta-Wiki are not able to assign or remove the event-organizer permission anymore.

While administrators are definitely affected (I can confirm this myself on itwiki), can you double-check that bureaucrats also can't add users to the group? This should not be the case, as we only removed overrides for sysops, not bureaucrats.

Daimona moved this task from QA 🐛 to Development In Progress 💻 on the Connection-Team (Connection-Current-Sprint) board.Feb 12 2025, 1:41 PM

Change #1119136 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[operations/mediawiki-config@master] Let sysop add/remove the event-organizer group by default

https://gerrit.wikimedia.org/r/1119136

gerritbot added a project: Patch-For-Review.Feb 12 2025, 2:50 PM

Change #1119136 merged by jenkins-bot:

[operations/mediawiki-config@master] Let sysops add/remove the event-organizer group by default

https://gerrit.wikimedia.org/r/1119136

Mentioned in SAL (#wikimedia-operations) [2025-02-12T15:04:04Z] <lucaswerkmeister-wmde@deploy2002> Started scap sync-world: Backport for [[gerrit:1119136|Let sysops add/remove the event-organizer group by default (T376822)]]

Mentioned in SAL (#wikimedia-operations) [2025-02-12T15:06:59Z] <lucaswerkmeister-wmde@deploy2002> daimona, lucaswerkmeister-wmde: Backport for [[gerrit:1119136|Let sysops add/remove the event-organizer group by default (T376822)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2025-02-12T15:16:58Z] <lucaswerkmeister-wmde@deploy2002> Finished scap sync-world: Backport for [[gerrit:1119136|Let sysops add/remove the event-organizer group by default (T376822)]] (duration: 12m 53s)

The issue with group management should be fixed now. I also filed T386210 for a related bug I found while testing locally.

Maintenance_bot removed a project: Patch-For-Review.Feb 12 2025, 3:31 PM

Thanks for fixing it, assignment-option is "back again" on both metawiki and wikidatawiki :)

In T376822#10544346, @Daimona wrote:

While administrators are definitely affected (I can confirm this myself on itwiki), can you double-check that bureaucrats also can't add users to the group? This should not be the case, as we only removed overrides for sysops, not bureaucrats.

I didn't ask anyone and I am not a crat on meta/wikidata, I was just looking at Special:ListGroupRights where event-organizer-assignment was missing everywhere, also at the crat-permission-list.

LD mentioned this in T386622: Release CampaignEvents extension to French Wikipedia.Feb 17 2025, 4:29 PM

Event-organizer group displaying, as well as the list of users with event-organizer right. sending to product sign off

pl wiki	pl wiki list of users with event organizer right	ar wiki	ar wiki list of users with event org rights

Daimona mentioned this in T386738: Consider removal of $wgAddGroups and $wgRemoveGroups added for the event-organizer group in WMF config.Feb 18 2025, 7:04 PM

Daimona mentioned this in T387943: Disable the event-organizer group in officewiki.Mar 5 2025, 12:13 AM

ifried closed this task as Resolved.Mar 10 2025, 9:53 PM

ifried moved this task from Product sign-off 🖌️ to Done 🏁 on the Connection-Team (Connection-Current-Sprint) board.

Daimona mentioned this in T389863: api-testing CI failure: Timeout of 5000ms exceeded in "before all" hook in "POST /campaignevents/v0/event_registration".Mar 24 2025, 11:24 PM

	F58413705: Screenshot 2025-02-17 at 3.35.11 PM.png
	Feb 18 2025, 2:46 AM

	F58413701: Screenshot 2025-02-17 at 3.34.31 PM.png
	Feb 18 2025, 2:46 AM

	F58400586: Screenshot 2025-02-14 at 5.31.35 PM.png
	Feb 18 2025, 2:46 AM

	F58400540: Screenshot 2025-02-14 at 5.09.09 PM.png
	Feb 18 2025, 2:46 AM

Configure the CampaignEvents extension to use the event-organizer group by defaultClosed, ResolvedPublic2 Estimated Story PointsActions