Page MenuHomePhabricator
Create Task
Maniphest T376930

remove $wgSecurePollSingleTransferableVoteEnabled?
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

What

  • remove $wgSecurePollSingleTransferableVoteEnabled from SecurePoll code, and replace it with always on behavior
  • remove $wgSecurePollSingleTransferableVoteEnabled from InitializeSettings.php

Why

  • easier for new devs working on SecurePoll who don't have to remember to turn this on when wanting to work on tickets related to STV
  • seems harmless to have this extra poll type displayed all the time in Special:SecurePoll/create. are there any wiki farms that have this poll type turned off or have a compelling reason to have this turned off?

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove flag wgSecurePollSingleTransferableVoteEnabledoperations/mediawiki-configmaster+0 -11
Remove flag $wgSecurePollSingleTransferableVoteEnabledmediawiki/extensions/SecurePollwmf/1.44.0-wmf.14+0 -8
Remove flag $wgSecurePollSingleTransferableVoteEnabledmediawiki/extensions/SecurePollwmf/1.44.0-wmf.15+0 -8
Remove flag $wgSecurePollSingleTransferableVoteEnabledmediawiki/extensions/SecurePollmaster+0 -8
Customize query in gerrit

Related Objects

Event Timeline

Novem_Linguae created this task.Oct 10 2024, 6:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 10 2024, 6:18 PM
Novem_Linguae set the point value for this task to 1.Oct 10 2024, 6:20 PM
Reedy subscribed.Oct 10 2024, 6:25 PM

T282013: Introduce a feature flag for SecurePoll work on Single Transferable Vote [XS]

I'm guessing it was mostly introduced as a feature flag until it was deemed stable/whatever.

Doing this seems to go along with the general idea we have of trying to have "sensible" defaults.

Certainly could change the default, and then look to remove it in a later MW release, if it is deemed to have some use longer term...

Novem_Linguae updated the task description. (Show Details)Oct 10 2024, 6:34 PM
kostajh moved this task from Backlog to Ready for development on the MediaWiki-extensions-SecurePoll board.Jan 28 2025, 8:02 PM
Restricted Application added a project: Trust and Safety Product Team. · View Herald TranscriptJan 28 2025, 8:02 PM
Mimurawil claimed this task.Jan 31 2025, 12:17 AM
gerritbot added a comment.Jan 31 2025, 6:45 PM

Change #1115911 had a related patch set uploaded (by Mimurawil; author: Mimurawil):

[mediawiki/extensions/SecurePoll@master] Remove flag $wgSecurePollSingleTransferableVoteEnabled

https://gerrit.wikimedia.org/r/1115911

gerritbot added a project: Patch-For-Review.Jan 31 2025, 6:45 PM
gerritbot added a comment.Jan 31 2025, 6:56 PM

Change #1115917 had a related patch set uploaded (by Mimurawil; author: Mimurawil):

[operations/mediawiki-config@master] Remove flag wgSecurePollSingleTransferableVoteEnabled

https://gerrit.wikimedia.org/r/1115917

Mimurawil changed the task status from Open to In Progress.Feb 1 2025, 1:04 AM
Mimurawil moved this task from Ready for development to Actively working on the MediaWiki-extensions-SecurePoll board.Feb 3 2025, 5:26 PM
gerritbot added a comment.Feb 4 2025, 11:41 AM

Change #1115911 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] Remove flag $wgSecurePollSingleTransferableVoteEnabled

https://gerrit.wikimedia.org/r/1115911

gerritbot added a comment.Feb 4 2025, 11:53 AM

Change #1117171 had a related patch set uploaded (by Máté Szabó; author: Mimurawil):

[mediawiki/extensions/SecurePoll@wmf/1.44.0-wmf.14] Remove flag $wgSecurePollSingleTransferableVoteEnabled

https://gerrit.wikimedia.org/r/1117171

gerritbot added a comment.Feb 4 2025, 11:54 AM

Change #1117172 had a related patch set uploaded (by Máté Szabó; author: Mimurawil):

[mediawiki/extensions/SecurePoll@wmf/1.44.0-wmf.15] Remove flag $wgSecurePollSingleTransferableVoteEnabled

https://gerrit.wikimedia.org/r/1117172

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.16; 2025-02-11).Feb 4 2025, 12:00 PM
gerritbot added a comment.Feb 4 2025, 3:14 PM

Change #1117172 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@wmf/1.44.0-wmf.15] Remove flag $wgSecurePollSingleTransferableVoteEnabled

https://gerrit.wikimedia.org/r/1117172

gerritbot added a comment.Feb 4 2025, 3:15 PM

Change #1117171 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@wmf/1.44.0-wmf.14] Remove flag $wgSecurePollSingleTransferableVoteEnabled

https://gerrit.wikimedia.org/r/1117171

Stashbot added a comment.Feb 4 2025, 3:16 PM

Mentioned in SAL (#wikimedia-operations) [2025-02-04T15:15:59Z] <mszabo@deploy2002> Started scap sync-world: Backport for [[gerrit:1117172|Remove flag $wgSecurePollSingleTransferableVoteEnabled (T376930)]], [[gerrit:1117171|Remove flag $wgSecurePollSingleTransferableVoteEnabled (T376930)]]

Stashbot added a comment.Feb 4 2025, 3:20 PM

Mentioned in SAL (#wikimedia-operations) [2025-02-04T15:20:52Z] <mszabo@deploy2002> mszabo: Backport for [[gerrit:1117172|Remove flag $wgSecurePollSingleTransferableVoteEnabled (T376930)]], [[gerrit:1117171|Remove flag $wgSecurePollSingleTransferableVoteEnabled (T376930)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Feb 4 2025, 3:29 PM

Mentioned in SAL (#wikimedia-operations) [2025-02-04T15:29:45Z] <mszabo@deploy2002> Finished scap sync-world: Backport for [[gerrit:1117172|Remove flag $wgSecurePollSingleTransferableVoteEnabled (T376930)]], [[gerrit:1117171|Remove flag $wgSecurePollSingleTransferableVoteEnabled (T376930)]] (duration: 13m 46s)

gerritbot added a comment.Feb 4 2025, 3:32 PM

Change #1115917 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove flag wgSecurePollSingleTransferableVoteEnabled

https://gerrit.wikimedia.org/r/1115917

Stashbot added a comment.Feb 4 2025, 3:33 PM

Mentioned in SAL (#wikimedia-operations) [2025-02-04T15:33:15Z] <mszabo@deploy2002> Started scap sync-world: Backport for [[gerrit:1115917|Remove flag wgSecurePollSingleTransferableVoteEnabled (T376930)]]

Stashbot added a comment.Feb 4 2025, 3:36 PM

Mentioned in SAL (#wikimedia-operations) [2025-02-04T15:36:54Z] <mszabo@deploy2002> mimurawil, mszabo: Backport for [[gerrit:1115917|Remove flag wgSecurePollSingleTransferableVoteEnabled (T376930)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Feb 4 2025, 3:44 PM

Mentioned in SAL (#wikimedia-operations) [2025-02-04T15:44:36Z] <mszabo@deploy2002> Finished scap sync-world: Backport for [[gerrit:1115917|Remove flag wgSecurePollSingleTransferableVoteEnabled (T376930)]] (duration: 11m 21s)

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.15; 2025-02-04); removed MW-1.44-notes (1.44.0-wmf.16; 2025-02-11).Feb 4 2025, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 4 2025, 4:31 PM
Novem_Linguae closed this task as Resolved.Jul 11 2025, 1:03 PM
Novem_Linguae updated the task description. (Show Details)

Nothing is showing up in CodeSearch. I think this ticket is complete.

OKryva-WMF added a project: Essential-Work.Oct 3 2025, 3:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits