Page MenuHomePhabricator

Do not consider dynamic defaults for emergency defaults
Closed, ResolvedPublic

Description

Emergency defaults exist to kick in when CommunityConfiguration cannot be used (T367516). Their values is calculated automatically by a maintenance script based on the config schemas. As of now, that logic evaluates dynamic defaults (as on whatever wiki the script was used on, likely developer's local). This doesn't seem like a good idea for several reasons:

  • the value of that dynamic default would be based on the developer's local environment, which doesn't need to be appropriate in production,
  • dynamic default might evaluate differently in CI and on local, causing the tests we're adding (T374428) to fail.

We should probably exclude dynamic default evaluation when calculating emergency defaults.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1079513 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/CommunityConfiguration@master] Emergency defaults: Ignore dynamic defaults

https://gerrit.wikimedia.org/r/1079513

Urbanecm_WMF triaged this task as Medium priority.
Urbanecm_WMF edited projects, added Growth-Team (Current Sprint); removed Growth-Team.
Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Current Sprint) board.

Change #1079513 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] Emergency defaults: Ignore dynamic defaults

https://gerrit.wikimedia.org/r/1079513