Page MenuHomePhabricator

Remove datatextend.py from scripts package with Pywikibot 10
Closed, ResolvedPublic

Description

Status

dataextend.py originally written by Andre_Engels was added 4 years ago wit Pywikibot 7.2 but I am unsure whether this is ever used and overall it is hardly maintainable:

  • it is not maintained by the original author, see also https://github.com/andreengels/dataextend
  • the script contains 18'000 lines of code in one single file
  • most of the code is not documented, it is unclear how to use it and how it works
  • function results are not consistent
  • most data is rertrieved via screen scraping and it is unsure whether it still works
  • there are no tests implemented
  • setting files are not included
  • ...

Proposal

I propose to remove dataextend.py from Pywikibot scripts package.
After adding the code entry point for foreign scripts in Pywikibot 9.4 the script can be published as a separate Pywikibot package like pywikibot-scripts either by the Pywikibot maintainers or the original author.

Event Timeline

Xqt renamed this task from Remove datatextend.py from scripts package. to Remove datatextend.py from scripts package.Oct 12 2024, 4:30 PM
Xqt removed Andre_Engels as the assignee of this task.
Xqt added a subscriber: Andre_Engels.

Change #1084740 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [scripts] remove dataextend script from repository

https://gerrit.wikimedia.org/r/1084740

Postponed to Pywikibot 10.

Xqt renamed this task from Remove datatextend.py from scripts package to Remove datatextend.py from scripts package with Pywikibot 10.Nov 3 2024, 2:56 PM

Change #1086534 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] Deprecate dataextend.py script

https://gerrit.wikimedia.org/r/1086534

Change #1086534 merged by jenkins-bot:

[pywikibot/core@master] Deprecate dataextend.py script

https://gerrit.wikimedia.org/r/1086534

Xqt claimed this task.

Change #1084740 merged by jenkins-bot:

[pywikibot/core@master] [scripts] remove dataextend script from repository

https://gerrit.wikimedia.org/r/1084740

Change #1219669 had a related patch set uploaded (by Meno25; author: Meno25):

[pywikibot/core@master] The script "dataextend.py" was removed rom Pywikibot

https://gerrit.wikimedia.org/r/1219669

Change #1219669 merged by jenkins-bot:

[pywikibot/core@master] The script "dataextend.py" was removed from Pywikibot

https://gerrit.wikimedia.org/r/1219669