Groth has adapted their scripts to use the new WeightedTagsUpdater now we have to enable it, so it actually pipes changes through event gate.
AC
- CirrusSearchEnableEventBusWeightedTags is enabled
Description
Description
Details
Details
Related Changes in Gerrit:
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | pfischer | T366253 Create a generic stream to populate CirrusSearch weighted_tags | |||
| Resolved | pfischer | T372904 Use page_weighted_tags_changed stream | |||
| Resolved | pfischer | T377150 Config: enable CirrusSearchEnableEventBusWeightedTags |
Event Timeline
Comment Actions
Change #1084729 had a related patch set uploaded (by Peter Fischer; author: Peter Fischer):
[operations/mediawiki-config@master] CirrusSearch: Enable offloading weighted tags via EventBus
Comment Actions
Change #1084729 merged by jenkins-bot:
[operations/mediawiki-config@master] CirrusSearch: Enable offloading weighted tags via EventBus
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2024-10-30T13:50:52Z] <urbanecm@deploy2002> Started scap sync-world: Backport for [[gerrit:1084762|[BlockManager] Don't assume autoblocks have ::getParentBlockId (T378563)]], [[gerrit:1084729|CirrusSearch: Enable offloading weighted tags via EventBus (T377150)]], [[gerrit:1084779|cswiki: Add celebration logo (T378597)]]
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2024-10-30T13:53:20Z] <urbanecm@deploy2002> dreamyjazz, pfischer, urbanecm: Backport for [[gerrit:1084762|[BlockManager] Don't assume autoblocks have ::getParentBlockId (T378563)]], [[gerrit:1084729|CirrusSearch: Enable offloading weighted tags via EventBus (T377150)]], [[gerrit:1084779|cswiki: Add celebration logo (T378597)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2024-10-30T14:06:22Z] <urbanecm@deploy2002> Finished scap sync-world: Backport for [[gerrit:1084762|[BlockManager] Don't assume autoblocks have ::getParentBlockId (T378563)]], [[gerrit:1084729|CirrusSearch: Enable offloading weighted tags via EventBus (T377150)]], [[gerrit:1084779|cswiki: Add celebration logo (T378597)]] (duration: 15m 30s)
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2024-10-30T14:11:36Z] <urbanecm> mwmaint2002: kill all running instances of refreshLinkRecommendations.php (T377150)
Comment Actions
Change #1087407 had a related patch set uploaded (by Urbanecm; author: Urbanecm):
[operations/mediawiki-config@master] CirrusSearch: Disable updating weighted tags via EventBus
Comment Actions
Change #1087407 merged by jenkins-bot:
[operations/mediawiki-config@master] CirrusSearch: Disable updating weighted tags via EventBus
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2024-11-05T12:16:09Z] <urbanecm@deploy2002> Started scap sync-world: Backport for [[gerrit:1087407|CirrusSearch: Disable updating weighted tags via EventBus (T378983 T377150)]]
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2024-11-05T12:23:49Z] <urbanecm@deploy2002> Finished scap sync-world: Backport for [[gerrit:1087407|CirrusSearch: Disable updating weighted tags via EventBus (T378983 T377150)]] (duration: 07m 39s)
Comment Actions
@pfischer and I attempted to redeploy the EventBus approach. For some unknown reasons, new recommendations were not ingested (they ended up in Kafka, but never got processed to a state where they would be queriable via Special:Search). IRC transcript:
09:43 <urbanecm> pfischer: there should be an addition now 09:43 <urbanecm> (testwiki, Apollo_11, id 160445) 09:43 <pfischer> urbanecm: yes, confirmed 09:44 <urbanecm> great! progress :). let me try to trigger a removal now 09:44 <urbanecm> pfischer: we should now have a removal 09:45 <urbanecm> (testwiki, Nobelium, 119493) 09:45 <pfischer> urbanecm: ✅ 09:46 <urbanecm> that sounds like it works now! i don't think there are any other operations besides those two, are there? 09:46 <pfischer> urbanecm: No, I’ll just check if our update pipeline ingested those two as expected. 09:49 <urbanecm> i do not see them processed when running queries via `Special:Search`, but that might very well be OK 09:53 <pfischer> urbanecm: I can’t find them in the inter-update-pipeline-topic either, but the app keeps running, so obviously no crashes are caused and we do get the kafka records now 09:54 <pfischer> so even if we have to fix sth. in our app, you should be fine 09:56 <pfischer> urbanecm: found the events in the intermediate topic now, didn’t went back far enough. 09:57 <pfischer> urbanecm: …and forgot about the 10min delay 09:57 <urbanecm> it's 10 mins now since the addition though? 09:57 <urbanecm> according to IRC, the event was emitted at :43, now it's :57, so by now, it should be ingested? 09:58 <pfischer> Yes, and they were marked as rev_based 09:59 <pfischer> urbanecm: can you query the results now via Special:Search? 10:00 <urbanecm> pfischer: yes, removal was processed correctly, but the addition is not visible 10:00 <urbanecm> which is what is confusing me, because as far as i understand this, both SHOULD be visible by now 10:01 <urbanecm> `pageid:160445 hasrecommendation:link` and `pageid:119493 hasrecommendation:link` are the queries i'm using 10:10 <pfischer> urbanecm: hm, I tried to find sth. in the logs but couldn’t, our app runs without crashes so it no obvious bug. Sure, let’s revert and investigate, at least we have some reproducers now.
Patches
Comment Actions
I re-tested the behaviour at testwiki (once EventBus was re-deployed there), see my notes at T378983. It now appears to consistently work, so we must've run into a transient error during the deployment. As far as I can see, this should mean EventBus can be enabled everywhere again, hopefully with no follow-up this time.
Comment Actions
Change #1092258 had a related patch set uploaded (by Urbanecm; author: Peter Fischer):
[operations/mediawiki-config@master] CirrusSearch: enable offloading weighted tags via EventBus
Comment Actions
Change #1092258 merged by jenkins-bot:
[operations/mediawiki-config@master] CirrusSearch: enable offloading weighted tags via EventBus
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2024-11-19T08:04:34Z] <urbanecm@deploy2002> Started scap sync-world: Backport for [[gerrit:1082726|Translate Event Logging: Enable using $wgTranslateEnableEventLogging (T364460)]], [[gerrit:1092258|CirrusSearch: enable offloading weighted tags via EventBus (T378983 T377150)]], [[gerrit:1091197|[GrowthExperiments] Add virtual domain config (T354939)]]
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2024-11-19T08:12:12Z] <urbanecm@deploy2002> urbanecm, wangombe, pfischer: Backport for [[gerrit:1082726|Translate Event Logging: Enable using $wgTranslateEnableEventLogging (T364460)]], [[gerrit:1092258|CirrusSearch: enable offloading weighted tags via EventBus (T378983 T377150)]], [[gerrit:1091197|[GrowthExperiments] Add virtual domain config (T354939)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2024-11-19T08:29:16Z] <urbanecm@deploy2002> Finished scap sync-world: Backport for [[gerrit:1082726|Translate Event Logging: Enable using $wgTranslateEnableEventLogging (T364460)]], [[gerrit:1092258|CirrusSearch: enable offloading weighted tags via EventBus (T378983 T377150)]], [[gerrit:1091197|[GrowthExperiments] Add virtual domain config (T354939)]] (duration: 24m 42s)