Page MenuHomePhabricator

👷️ Implement top-level field validation
Closed, ResolvedPublic

Description

  • check top level field types.
  • check that the data_type field is present.
  • consider implementing this as a regular use case validator instead of creating a RequestValidatingDeserializer, because the RequestValidatingDeserializer would only be usable for this one use case.

Event Timeline

Change #1081408 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Add CreatePropertyValidator

https://gerrit.wikimedia.org/r/1081408

Change #1081409 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Validate new property field types and required field

https://gerrit.wikimedia.org/r/1081409

Change #1081408 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Add CreatePropertyValidator

https://gerrit.wikimedia.org/r/1081408

Change #1081409 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Validate new property field types and required field

https://gerrit.wikimedia.org/r/1081409