Page MenuHomePhabricator
Create Task
Maniphest T377226

Remove LabelCountField from WikibaseCirrusSearch
Closed, ResolvedPublic
Actions

Description

As described in T376250#10228472 and confirmed in T376250#10229167, this field was added to WikibaseCirrusSearch to potentially help with scoring / ranking (see T110648#1811494), but was never actually used. Let’s drop it before we start to reuse these fields in EntitySchema.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
cirrus: cleanup removed label_count field on next re-indexoperations/mediawiki-configmaster+1 -5
Drop label_count field (LabelCountField)mediawiki/extensions/WikibaseMediaInfowmf/1.43.0-wmf.26+0 -2
Drop label_count field (LabelCountField)mediawiki/extensions/WikibaseMediaInfowmf/1.43.0-wmf.27+0 -2
Remove LabelCountFieldmediawiki/extensions/WikibaseCirrusSearchwmf/1.43.0-wmf.26+2 -85
Remove LabelCountFieldmediawiki/extensions/WikibaseCirrusSearchwmf/1.43.0-wmf.27+2 -85
Hard-code LabelCountField::NAMEmediawiki/extensions/WikibaseMediaInfowmf/1.43.0-wmf.27+1 -2
Hard-code LabelCountField::NAMEmediawiki/extensions/WikibaseMediaInfowmf/1.43.0-wmf.26+1 -2
Drop label_count field (LabelCountField)mediawiki/extensions/WikibaseMediaInfomaster+0 -2
Remove LabelCountFieldmediawiki/extensions/WikibaseCirrusSearchmaster+2 -85
Hard-code LabelCountField::NAMEmediawiki/extensions/WikibaseMediaInfomaster+1 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Oct 15 2024, 2:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 15 2024, 2:39 PM
Lucas_Werkmeister_WMDE claimed this task.Oct 15 2024, 2:40 PM
Lucas_Werkmeister_WMDE moved this task from In Task Breakdown to In Development on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.
Lucas_Werkmeister_WMDE mentioned this in T376250: [ES-M3]: Create search fields like Wikibase's labels and labels_all all for ES and expose them via content handler.
gerritbot added a comment.Oct 15 2024, 2:52 PM

Change #1080307 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseMediaInfo@master] Hard-code LabelCountField::NAME

https://gerrit.wikimedia.org/r/1080307

gerritbot added a project: Patch-For-Review.Oct 15 2024, 2:52 PM

Change #1080308 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseCirrusSearch@master] Remove LabelCountField

https://gerrit.wikimedia.org/r/1080308

gerritbot added a comment.Oct 15 2024, 2:52 PM

Change #1080309 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseMediaInfo@master] Drop label_count field (LabelCountField)

https://gerrit.wikimedia.org/r/1080309

Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.Oct 15 2024, 3:57 PM
Lucas_Werkmeister_WMDE moved this task from In Development to Ready for Peer Review on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.
gerritbot added a comment.Oct 15 2024, 5:23 PM

Change #1080332 had a related patch set uploaded (by DCausse; author: DCausse):

[operations/mediawiki-config@master] cirrus: cleanup removed label_count field on next re-index

https://gerrit.wikimedia.org/r/1080332

gerritbot added a comment.Oct 15 2024, 5:55 PM

Change #1080307 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Hard-code LabelCountField::NAME

https://gerrit.wikimedia.org/r/1080307

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.28; 2024-10-22).Oct 15 2024, 6:00 PM
gerritbot added a comment.Oct 15 2024, 7:51 PM

Change #1080308 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@master] Remove LabelCountField

https://gerrit.wikimedia.org/r/1080308

gerritbot added a comment.Oct 15 2024, 8:24 PM

Change #1080309 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Drop label_count field (LabelCountField)

https://gerrit.wikimedia.org/r/1080309

gerritbot added a comment.Oct 16 2024, 12:43 PM

Change #1080669 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseMediaInfo@wmf/1.43.0-wmf.27] Hard-code LabelCountField::NAME

https://gerrit.wikimedia.org/r/1080669

gerritbot added a comment.Oct 16 2024, 12:43 PM

Change #1080670 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseCirrusSearch@wmf/1.43.0-wmf.27] Remove LabelCountField

https://gerrit.wikimedia.org/r/1080670

gerritbot added a comment.Oct 16 2024, 12:44 PM

Change #1080671 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseMediaInfo@wmf/1.43.0-wmf.27] Drop label_count field (LabelCountField)

https://gerrit.wikimedia.org/r/1080671

gerritbot added a comment.Oct 16 2024, 12:44 PM

Change #1080673 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseMediaInfo@wmf/1.43.0-wmf.26] Hard-code LabelCountField::NAME

https://gerrit.wikimedia.org/r/1080673

gerritbot added a comment.Oct 16 2024, 12:45 PM

Change #1080674 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseCirrusSearch@wmf/1.43.0-wmf.26] Remove LabelCountField

https://gerrit.wikimedia.org/r/1080674

gerritbot added a comment.Oct 16 2024, 12:45 PM

Change #1080676 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseMediaInfo@wmf/1.43.0-wmf.26] Drop label_count field (LabelCountField)

https://gerrit.wikimedia.org/r/1080676

gerritbot added a comment.Oct 16 2024, 1:46 PM

Change #1080673 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@wmf/1.43.0-wmf.26] Hard-code LabelCountField::NAME

https://gerrit.wikimedia.org/r/1080673

gerritbot added a comment.Oct 16 2024, 1:48 PM

Change #1080669 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@wmf/1.43.0-wmf.27] Hard-code LabelCountField::NAME

https://gerrit.wikimedia.org/r/1080669

gerritbot added a comment.Oct 16 2024, 1:49 PM

Change #1080674 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@wmf/1.43.0-wmf.26] Remove LabelCountField

https://gerrit.wikimedia.org/r/1080674

gerritbot added a comment.Oct 16 2024, 1:49 PM

Change #1080670 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@wmf/1.43.0-wmf.27] Remove LabelCountField

https://gerrit.wikimedia.org/r/1080670

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.26; 2024-10-08); removed MW-1.43-notes (1.43.0-wmf.28; 2024-10-22).Oct 16 2024, 2:00 PM
gerritbot added a comment.Oct 16 2024, 2:12 PM

Change #1080671 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@wmf/1.43.0-wmf.27] Drop label_count field (LabelCountField)

https://gerrit.wikimedia.org/r/1080671

gerritbot added a comment.Oct 16 2024, 2:12 PM

Change #1080676 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@wmf/1.43.0-wmf.26] Drop label_count field (LabelCountField)

https://gerrit.wikimedia.org/r/1080676

Stashbot added a comment.Oct 16 2024, 2:13 PM

Mentioned in SAL (#wikimedia-operations) [2024-10-16T14:13:04Z] <lucaswerkmeister-wmde@deploy2002> Started scap sync-world: Backport for [[gerrit:1080702|Tests: Skip testViewForExistingGlobalTemporaryAccount (T377197)]], [[gerrit:1080669|Hard-code LabelCountField::NAME (T377226)]], [[gerrit:1080670|Remove LabelCountField (T377226)]], [[gerrit:1080671|Drop label_count field (LabelCountField) (T377226)]], [[gerrit:1080703|Tests: Skip testViewForExistingGlobalTemporaryAccount (T377197

Stashbot mentioned this in T377197: SpecialCentralAuthTest fails when run in a suite with AccountCreationDetailsLookupTest.Oct 16 2024, 2:13 PM

Mentioned in SAL (#wikimedia-operations) [2024-10-16T14:13:31Z] <Lucas_WMDE> [cont.] )]], [[gerrit:1080673|Hard-code LabelCountField::NAME (T377226)]], [[gerrit:1080674|Remove LabelCountField (T377226)]], [[gerrit:1080676|Drop label_count field (LabelCountField) (T377226)]]

Stashbot added a comment.Oct 16 2024, 2:15 PM

Mentioned in SAL (#wikimedia-operations) [2024-10-16T14:15:18Z] <lucaswerkmeister-wmde@deploy2002> lucaswerkmeister-wmde: Backport for [[gerrit:1080702|Tests: Skip testViewForExistingGlobalTemporaryAccount (T377197)]], [[gerrit:1080669|Hard-code LabelCountField::NAME (T377226)]], [[gerrit:1080670|Remove LabelCountField (T377226)]], [[gerrit:1080671|Drop label_count field (LabelCountField) (T377226)]], [[gerrit:1080703|Tests: Skip testViewForExistingGlobalTemporaryAccount (T377197)]

Stashbot added a comment.Oct 16 2024, 2:15 PM

Mentioned in SAL (#wikimedia-operations) [2024-10-16T14:15:48Z] <Lucas_WMDE> [cont.] ], [[gerrit:1080673|Hard-code LabelCountField::NAME (T377226)]], [[gerrit:1080674|Remove LabelCountField (T377226)]], [[gerrit:1080676|Drop label_count field (LabelCountField) (T377226)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Oct 16 2024, 2:24 PM

Mentioned in SAL (#wikimedia-operations) [2024-10-16T14:24:41Z] <lucaswerkmeister-wmde@deploy2002> Finished scap sync-world: Backport for [[gerrit:1080702|Tests: Skip testViewForExistingGlobalTemporaryAccount (T377197)]], [[gerrit:1080669|Hard-code LabelCountField::NAME (T377226)]], [[gerrit:1080670|Remove LabelCountField (T377226)]], [[gerrit:1080671|Drop label_count field (LabelCountField) (T377226)]], [[gerrit:1080703|Tests: Skip testViewForExistingGlobalTemporaryAccount (T37719

Stashbot mentioned this in T37719: API: list=search&srwhat=nearmatch doesn't work for titles with namespace prefix.Oct 16 2024, 2:24 PM

Mentioned in SAL (#wikimedia-operations) [2024-10-16T14:24:59Z] <Lucas_WMDE> [cont.] 7)]], [[gerrit:1080673|Hard-code LabelCountField::NAME (T377226)]], [[gerrit:1080674|Remove LabelCountField (T377226)]], [[gerrit:1080676|Drop label_count field (LabelCountField) (T377226)]] (duration: 11m 36s)

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.27; 2024-10-15); removed MW-1.43-notes (1.43.0-wmf.26; 2024-10-08).Oct 16 2024, 3:00 PM
Lucas_Werkmeister_WMDE moved this task from Ready for Peer Review to Waiting for Deployment Window on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.Oct 16 2024, 3:19 PM
gerritbot added a comment.Oct 17 2024, 7:07 AM

Change #1080332 merged by jenkins-bot:

[operations/mediawiki-config@master] cirrus: cleanup removed label_count field on next re-index

https://gerrit.wikimedia.org/r/1080332

Stashbot added a comment.Oct 17 2024, 7:08 AM

Mentioned in SAL (#wikimedia-operations) [2024-10-17T07:08:47Z] <dcausse@deploy2002> Started scap sync-world: Backport for [[gerrit:1080332|cirrus: cleanup removed label_count field on next re-index (T377226)]]

Stashbot added a comment.Oct 17 2024, 7:13 AM

Mentioned in SAL (#wikimedia-operations) [2024-10-17T07:13:23Z] <dcausse@deploy2002> dcausse: Backport for [[gerrit:1080332|cirrus: cleanup removed label_count field on next re-index (T377226)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Oct 17 2024, 7:19 AM

Mentioned in SAL (#wikimedia-operations) [2024-10-17T07:19:28Z] <dcausse@deploy2002> Finished scap sync-world: Backport for [[gerrit:1080332|cirrus: cleanup removed label_count field on next re-index (T377226)]] (duration: 10m 40s)

Maintenance_bot removed a project: Patch-For-Review.Oct 17 2024, 7:30 AM
dcausse mentioned this in T147505: [tracking] CirrusSearch: what is updated during re-indexing.Oct 17 2024, 8:05 AM

AFAICT everything's merged & deployed, the label_count should no longer be populated from CirrusSearch. The data itself will stay in the search index until we run a re-index which is tracked in a separate ticket at T147505.

Lucas_Werkmeister_WMDE moved this task from Waiting for Deployment Window to Done on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.Oct 18 2024, 9:06 AM

I think this is done from our side, then; do you want to leave the task open until the next reindex or just close it?

dcausse closed this task as Resolved.Oct 18 2024, 9:47 AM
dcausse assigned this task to Lucas_Werkmeister_WMDE.
In T377226#10241049, @Lucas_Werkmeister_WMDE wrote:

I think this is done from our side, then; do you want to leave the task open until the next reindex or just close it?

we can close it, the reindex is tracked separately.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits