Implement DomainEventDispatcher (baseline)
Closed, ResolvedPublic
Actions

Description

The DomainEventDispatcher class should provide a mechanism to register listeners, and to send events to these listeners. Events are transaction-bound, and will be delivered only after successful completion of the current transaction round.

DomainEventDispatcher will implement separate interfaces for registering listeners and for sending events, which will be exposed through MediaWikiServices for use in service wiring.

Details

Subject	Repo	Branch	Lines +/-
DomainEventDispatcher: rename concepts	mediawiki/core	master	+188 -188
Introduce DomainEventDispatcher	mediawiki/core	master	+850 -124
PageUpdater: move LogEntry back to main transaction.	mediawiki/core	master	+26 -68

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
In Progress	daniel	T376063 Hypothesis WE5.2.3 (Q2 FY24/25): Introduce a system of events and listeners into MediaWiki core
Open	None	T378927 Add support for wiring files for domain events
Open	None	T378934 Define domain events for page deletion and undeletion
Open	daniel	T378936 Use the PageUpdatedEvent to trigger relevant updates in MediaWiki core
In Progress	aaron	T378937 Port Linter extension to PageUpdated event
In Progress	daniel	T378931 Allow extensions to register listeners for domain events
Resolved	daniel	T377229 Implement DomainEventDispatcher (baseline)

Event Timeline

daniel created this task.Oct 15 2024, 2:53 PM

Change #1069665 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] Introduce DomainEventDispatcher

https://gerrit.wikimedia.org/r/1069665

gerritbot added a project: Patch-For-Review.Oct 15 2024, 2:53 PM

daniel moved this task from Incoming (Needs Triage) to In Progress on the MW-Interfaces-Team board.Oct 15 2024, 2:58 PM

Ottomata subscribed.Oct 16 2024, 5:39 PM

Ottomata added projects: Data-Engineering, Event-Platform.Oct 16 2024, 5:45 PM

Ottomata added subscribers: gmodena, tchin, Milimetric, JAllemandou.

Ahoelzl moved this task from Incoming (new tickets) to Radar (External Teams) on the Data-Engineering board.Oct 23 2024, 9:00 PM

Ottomata moved this task from Backlog to Stream Data Products on the Event-Platform board.Oct 25 2024, 1:21 PM

Change #1069665 merged by jenkins-bot:

[mediawiki/core@master] Introduce DomainEventDispatcher

https://gerrit.wikimedia.org/r/1069665

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.2; 2024-11-05).Oct 29 2024, 9:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 29 2024, 9:30 PM

Change #1085458 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] PageUpdater: move LogEntry back to main transaction.

https://gerrit.wikimedia.org/r/1085458

gerritbot added a project: Patch-For-Review.Thu, Oct 31, 6:10 PM

Change #1085458 merged by jenkins-bot:

[mediawiki/core@master] PageUpdater: move LogEntry back to main transaction.

https://gerrit.wikimedia.org/r/1085458

Maintenance_bot removed a project: Patch-For-Review.Fri, Nov 1, 8:30 PM

daniel added a subtask: T378927: Add support for wiring files for domain events.Mon, Nov 4, 9:51 AM

daniel added a parent task: T378931: Allow extensions to register listeners for domain events.Mon, Nov 4, 9:56 AM

daniel removed a subtask: T378927: Add support for wiring files for domain events.

daniel added a parent task: T378927: Add support for wiring files for domain events.

daniel added a parent task: T378934: Define domain events for page deletion and undeletion.Mon, Nov 4, 10:14 AM

daniel added a parent task: T378936: Use the PageUpdatedEvent to trigger relevant updates in MediaWiki core.Mon, Nov 4, 10:22 AM

daniel closed this task as Resolved.Mon, Nov 4, 10:26 AM

Bawolff mentioned this in T379152: RevisionFromEditComplete hook no longer allows you to modify tags.Wed, Nov 6, 1:25 PM

A_smart_kitten mentioned this in T379380: Moving a page generates an unneeded page creation log entry.Sat, Nov 9, 12:45 PM

I think https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1069665/29/includes/page/MovePage.php might be causing creation log entries to be generated when moving pages, when such log entries weren't previously generated (see T379380: Moving a page generates an unneeded page creation log entry). I'm not sure whether or not this change was intentional - at an admittedly quick search, I can't find any comments to indicate it would be.

A_smart_kitten mentioned this in T375661: 1.44.0-wmf.2 deployment blockers.Sat, Nov 9, 1:10 PM

Wargo mentioned this in T379218: New pages are not autoreviewed despite creator having autoreview right.Sun, Nov 10, 11:57 AM

Ammarpad mentioned this in T379534: Page creation log inserted even if $wgPageCreationLog is false.Mon, Nov 11, 11:22 PM

Ottomata mentioned this in T379959: Design and document new Domain Events feature in MediaWiki core.Thu, Nov 14, 7:09 PM

Change #1092772 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] DomainEventDispatcher: rename concepts

https://gerrit.wikimedia.org/r/1092772

gerritbot added a project: Patch-For-Review.Tue, Nov 19, 9:38 AM

Change #1092772 merged by jenkins-bot:

[mediawiki/core@master] DomainEventDispatcher: rename concepts

https://gerrit.wikimedia.org/r/1092772

Maintenance_bot removed a project: Patch-For-Review.Tue, Nov 19, 5:30 PM