Page MenuHomePhabricator

FlaggedRevs double-counts revertedEdits param when rejecting revisions
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue:

  • On a wiki with FlaggedRevs, reject a revision authored by a named user.
  • Inspect the result of FRUserCounters::getParams( $author ); via shell.php, where $author is the author of the revision that was reverted.

What happens?:

  • The revertedEdits param will have been incremented by 2, rather than 1.

What should have happened instead?:

  • The revertedEdits param should have been incremented by 1.

Event Timeline

Found while working on T326934—will fix separately.

Change #1080376 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/FlaggedRevs@master] RevisionReviewForm: Avoid double-counting "revertedEdits"

https://gerrit.wikimedia.org/r/1080376

Change #1080376 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] RevisionReviewForm: Avoid double-counting "revertedEdits"

https://gerrit.wikimedia.org/r/1080376

matmarex assigned this task to mszabo.
matmarex removed a project: Patch-For-Review.
matmarex subscribed.