Page MenuHomePhabricator

Update the 'globalblock' API to allow enabling global autoblocking for global user blocks
Closed, ResolvedPublic1 Estimated Story Points

Description

The globalblock API needs to be updated to support callers to enable and disable autoblocking for a global block on a user.

Acceptance criteria
  • The globalblock API can be used to enable and disable autoblocking for a global block on a user

Event Timeline

Change #1080807 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Update the 'globalblock' API for global autoblocks

https://gerrit.wikimedia.org/r/1080807

Change #1080807 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Update the 'globalblock' API for global autoblocks

https://gerrit.wikimedia.org/r/1080807

dom_walden subscribed.

I wrote a script to create a number of global blocks with different block params and checking that an autoblock is always created (with exceptions that are consistent with local autoblocks).

One way it is inconsistent with local autoblocks is if I modify a global block which has autoblock enabled, the autoblock will have its expiry updated to 24 hours, regardless if the expiry of the parent block is less than 24 hours. I will raise a separate bug (done: T378353).

I also confirmed that when I modify a block to disable autoblocks all of its autoblocks are removed.

Test environment: local docker GlobalBlocking – (5808f91) 17:49, 25 October 2024 (last tested version).

Thanks for the QA and finding that bug.