Talk page sections "freeze" and don't open up on Android when JS doesn't load correctly
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	SonjaPerry
	Oct 16 2024, 8:23 PM

Description

Steps to replicate the issue (include links if applicable):

Verified for Firefox, but unsure what other browsers are impacted as well. To replicate go to talk page sections on Android mobile web, using MinervaNeue.

What happens?:
Talk page sections "freeze" and don't open up on Android mobile web, using MinervaNeue.

See more details in this discussion: https://en.wikipedia.org/wiki/Wikipedia_talk:Mobile_communication_bugs#Some_observations

What should have happened instead?: Talk page sections should not freeze and they should always open up

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia): Android mobile web, using MinervaNeue.

Other information (browser name/version, screenshots, etc.): Verified for Firefox, but unsure what other browsers are impacted as well.

QA steps

In network tab set connection speed to 3g.
Visit https://en.m.wikipedia.org/wiki/Talk:Tony_Hawk%27s_Underground
As soon as the page has rendered switch to offline
Try to expand a section

Description Text

Requirement

Ensure that talk page sections on Android mobile web, using MinervaNeue, do not freeze and can be opened even when JavaScript doesn’t load correctly.

BDD

Feature: Talk page section behavior on Android mobile web

  Scenario: Expand talk page sections when JavaScript doesn't load correctly
    Given the user is on Android mobile web using the MinervaNeue skin
    And the connection speed is limited to 3G
    When the user visits a talk page
    And the page is switched to offline mode after rendering
    Then the user can expand a section without it freezing

Test Steps

Test Case 1: Verify Talk Page Sections Expand Without Freezing

Open the browser developer tools and go to the Network tab.
Set the connection speed to 3G.
Navigate to the talk page: Talk:Tony Hawk’s Underground.
Wait for the page to render completely.
Switch the browser to offline mode.
Attempt to expand a talk page section.
AC1: Confirm that the section expands without freezing or any errors.

QA Results - Beta

AC	Status	Details
1	✅	T377389#10362636

QA Results - Prod

AC	Status	Details
1	❓	T377389#10396266

Details

	Subject	Repo	Branch	Lines +/-
	Restore styles to support "interim toggling"	mediawiki/extensions/MobileFrontend	master	+6 -0

Customize query in gerrit

Related Objects

Mentioned In: T382025: Cannot collapse MobileFrontend sections once open on slow/unstable connections
T381658: Section content is briefly visible (FOUC) in template-generated sections in parsoid read views
T381355: Verify 1.44.0-wmf.6 deployment

Event Timeline

SonjaPerry created this task.Oct 16 2024, 8:23 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 16 2024, 8:23 PM

SonjaPerry updated the task description. (Show Details)Oct 16 2024, 8:24 PM

using Vector 2022 with MinervaNeue

This just doesn’t make sense: both Vector 2022 and MinervaNeue are skins, you can use only one or the other at a time. If I understand the discussion correctly, the report is only about MinervaNeue – the only way Vector 2022 is connected to this story is that the reporter set that in their preferences, but the MobileFrontend extension ignores that, forcing one to use MinervaNeue instead.

Do you only see this problem on talk pages? I've experienced something similar with articles, where if my mobile connection is poor, the article sections sometimes don't expand.

Thanks for calling this out @Tacsipacsi - ticket updated to only include mention of MinervaNeue to avoid confusion.

matmarex edited projects, added MobileFrontend; removed DiscussionTools.Nov 7 2024, 12:48 PM

Change #1088287 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/MobileFrontend@master] Restore styles to support "interim toggling"

https://gerrit.wikimedia.org/r/1088287

gerritbot added a project: Patch-For-Review.Nov 7 2024, 12:48 PM

That fixes the problem I encountered. I hope it's the same as yours.

In T377389#10299319, @matmarex wrote:

That fixes the problem I encountered. I hope it's the same as yours.

Thank you, BD.

Jdlrobson added a project: Web-Team-Backlog (FY2024-25 Q2 Sprint 4).Nov 8 2024, 4:05 PM

@SonjaPerry in description it says you were able to verify this on Firefox. Was this Firefox mobile or on your laptop? Could you provide some URLs where you were seeing this behaviour?

Web team can take a look at this next week.

Jdlrobson triaged this task as Medium priority.Nov 8 2024, 4:13 PM

Jdlrobson added a project: Web Team Essential Work 2024.

Jdlrobson moved this task from Backlog to Volunteer patches / Team requests on the Web Team Essential Work 2024 board.Nov 8 2024, 4:37 PM

Jdlrobson moved this task from Needs analysis to Ready for estimation on the Web-Team-Backlog (FY2024-25 Q2 Sprint 4) board.Nov 8 2024, 7:06 PM

NBaca-WMF added a project: Web-Team.Wed, Nov 13, 2:54 PM

@Jdlrobson I didn't attempt to reproduce this, but went with what User:andrybak and User:Clovermoss posted here: https://en.wikipedia.org/wiki/Wikipedia_talk:Mobile_communication_bugs#Some_observations

Jdlrobson moved this task from Product Backlog to Sprint Backlog on the Web-Team board.Wed, Nov 13, 11:19 PM

Jdlrobson renamed this task from Talk page sections "freeze" and don't open up on Android to Talk page sections "freeze" and don't open up on Android when JS doesn't load correctly.Wed, Nov 13, 11:33 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson set the point value for this task to 2.

Jdlrobson moved this task from Sprint Backlog to Product Backlog on the Web-Team board.Wed, Nov 13, 11:57 PM

Jdlrobson moved this task from Product Backlog to Sprint Backlog on the Web-Team board.Thu, Nov 14, 11:37 PM

ovasileva moved this task from Sprint Backlog to Product Backlog on the Web-Team board.Mon, Nov 18, 4:07 PM

ovasileva moved this task from Product Backlog to Sprint Backlog on the Web-Team board.

Change #1088287 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Restore styles to support "interim toggling"

https://gerrit.wikimedia.org/r/1088287

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.6; 2024-12-03).Wed, Nov 27, 12:00 AM

Jdlrobson reassigned this task from matmarex to Edtadros.Wed, Nov 27, 12:01 AM

Jdlrobson edited projects, added Web-Team (FY2024-25 Q2 Sprint 4 (Nov 13 - Nov 26, 2024)); removed Web-Team.

Jdlrobson moved this task from Ready for Development to In Progress on the Web-Team (FY2024-25 Q2 Sprint 4 (Nov 13 - Nov 26, 2024)) board.

Maintenance_bot removed a project: Patch-For-Review.Wed, Nov 27, 12:30 AM

Edtadros updated the task description. (Show Details)Wed, Nov 27, 4:48 PM

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: Android
Browser: Firefox
Device: Mobile
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify Talk Page Sections Expand Without Freezing

Open the browser developer tools and go to the Network tab.
Set the connection speed to 3G.
Navigate to the talk page: Talk:Tony Hawk’s Underground.
Wait for the page to render completely.
Switch the browser to offline mode.
Attempt to expand a talk page section.
✅ AC1: Confirm that the section expands without freezing or any errors.

Edtadros updated the task description. (Show Details)Wed, Nov 27, 5:01 PM

Resolving this! @SonjaPerry - feel free to reopen if there's anything missing!

GMikesell-WMF mentioned this in T381355: Verify 1.44.0-wmf.6 deployment.Wed, Dec 4, 6:17 PM

Jdlrobson mentioned this in T381658: Section content is briefly visible (FOUC) in template-generated sections in parsoid read views.Fri, Dec 6, 6:10 PM

Test Result - Prod

Status: ❓ Need more info
Environment: enwiki
OS: Android
Browser: Chrome
Device: MS
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify Talk Page Sections Expand Without Freezing

Open the browser developer tools and go to the Network tab.
Set the connection speed to 3G.
Navigate to the talk page: Talk:Tony Hawk’s Underground.
Wait for the page to render completely.
Switch the browser to offline mode.
Attempt to expand a talk page section.
❓ AC1: Confirm that the section expands without freezing or any errors.

@Jdlrobson, I'm not sure if this is a pass/fail. I would assume fail because I see errors in the console.

Edtadros updated the task description. (Show Details)Wed, Dec 11, 9:50 AM

It looks like it's working to me.

Side note: In your video it looks like you switch to offline too late. It needs to happen the instant the page renders. You can ignore the console "errors" those are due to HTTP requests to images that cannot be requested when you are offline and unrelated.

Testing this it seems I can only expand the sections in this situation. Once they are open they cannot be closed again... the handler seems to continuously add open-section the section elements.

Jdlrobson mentioned this in T382025: Cannot collapse MobileFrontend sections once open on slow/unstable connections.Wed, Dec 11, 6:42 PM

Test Result - Prod

Status: ✅ Need more info
Environment: enwiki
OS: Android
Browser: Chrome
Device: MS
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify Talk Page Sections Expand Without Freezing

Open the browser developer tools and go to the Network tab.
Set the connection speed to 3G.
Navigate to the talk page: Talk:Tony Hawk’s Underground.
Wait for the page to render completely.
Switch the browser to offline mode.
Attempt to expand a talk page section.
✅ AC1: Confirm that the section expands without freezing or any errors.

Per T377389#10398549, this is a pass

	F57800794: screenshot 52.mov.gif
	Wed, Dec 11, 11:09 PM

	F57698830: slow3g.gif
	Wed, Nov 13, 11:33 PM

	F57698825: slow3g.gif
	Wed, Nov 13, 11:33 PM

Talk page sections "freeze" and don't open up on Android when JS doesn't load correctlyClosed, ResolvedPublic2 Estimated Story PointsBUG REPORTActions

Description

QA steps

Requirement

BDD

Test Steps

QA Results - Beta

QA Results - Prod

Details

Related Objects

Event Timeline

Test Steps

Test Steps

Test Steps

Talk page sections "freeze" and don't open up on Android when JS doesn't load correctly
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions