Page MenuHomePhabricator

Replace template search with new TemplateSearchWidget in VisualEditor
Closed, ResolvedPublic5 Estimated Story Points

Description

Replace the existing template search field (in the template insertion dialog) with the new TemplateSearchWidget, behind the $wgTemplateDataEnableDiscovery flag. This is a step in unifying the template search and recall feature in TemplateWizard and VisualEditor.

The new widget should behave in (almost) exactly the same way as the existing template search feature, including the optional dependency on CirrusSearch to improve the search behaviour.

This could either be done in an optional way, in which case VE would still have to have its own template-search feature, or it could introduce a new dependency of VisualEditor upon TemplateData. The latter is preferred, but a decision has not yet been made.

Event Timeline

Change #1120698 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/VisualEditor@master] Optionally use new TemplateSearchLayout from TemplateData

https://gerrit.wikimedia.org/r/1120698

KSiebert set the point value for this task to 5.

Patch looks good to me! Only thing I'm thinking is can we add any tests for ensuring it loads correctly in ve when the config is/isn't set?

Change #1125660 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/TemplateData@master] Add templateDiscovery module as a VE plugin module

https://gerrit.wikimedia.org/r/1125660

Only thing I'm thinking is can we add any tests for ensuring it loads correctly in ve when the config is/isn't set?

Done.

TheresNoTime changed the task status from Open to Stalled.Mar 31 2025, 10:59 AM

Patch awaiting review

Change #1120698 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Optionally use new TemplateSearchLayout from TemplateData

https://gerrit.wikimedia.org/r/1120698

Samwilson changed the task status from Stalled to Open.Apr 4 2025, 1:15 AM
Samwilson moved this task from Feedback and Review to QA on the Community-Tech (Fox Squad) board.
dom_walden subscribed.

Resolving as needing no extra, specific testing.