Page MenuHomePhabricator

update.php fails to run on beta cluster due to updatelog not existing on the virtual database domain
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT

Description

The beta-update-databases-eqiad job is failing because MediaWiki core is attempting to write to the updatelog table on a non-local database.

Steps to replicate the issue
  1. Define $wgVirtualDomainsMapping['virtual-globalblocking'] = [ 'db' => 'centralauth' ];
  2. Run update.php

What happens?:
update.php fails because of an attempt to write to the updatelog table on the virtual database domain, which does not exist

What should have happened instead?:
The local updatelog table should have been used instead

Event Timeline

Change #1081141 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Skip 'gb_autoblock_parent_id' NOT NULL schema update if applied

https://gerrit.wikimedia.org/r/1081141

Change #1081141 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Skip 'gb_autoblock_parent_id' NOT NULL schema update if applied

https://gerrit.wikimedia.org/r/1081141

Change #1081169 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] [DatabaseUpdater] Don't interact with updatelog on virtual domains

https://gerrit.wikimedia.org/r/1081169

Change #1081169 merged by jenkins-bot:

[mediawiki/core@master] [DatabaseUpdater] Don't interact with updatelog on virtual domains

https://gerrit.wikimedia.org/r/1081169

Change #1081258 had a related patch set uploaded (by Reedy; author: Dreamy Jazz):

[mediawiki/core@REL1_42] [DatabaseUpdater] Don't interact with updatelog on virtual domains

https://gerrit.wikimedia.org/r/1081258

Change #1081259 had a related patch set uploaded (by Reedy; author: Dreamy Jazz):

[mediawiki/core@REL1_41] [DatabaseUpdater] Don't interact with updatelog on virtual domains

https://gerrit.wikimedia.org/r/1081259

Change #1081260 had a related patch set uploaded (by Reedy; author: Dreamy Jazz):

[mediawiki/core@REL1_39] [DatabaseUpdater] Don't interact with updatelog on virtual domains

https://gerrit.wikimedia.org/r/1081260

Change #1081259 merged by jenkins-bot:

[mediawiki/core@REL1_41] [DatabaseUpdater] Don't interact with updatelog on virtual domains

https://gerrit.wikimedia.org/r/1081259

Change #1081260 merged by jenkins-bot:

[mediawiki/core@REL1_39] [DatabaseUpdater] Don't interact with updatelog on virtual domains

https://gerrit.wikimedia.org/r/1081260

Change #1081258 merged by jenkins-bot:

[mediawiki/core@REL1_42] [DatabaseUpdater] Don't interact with updatelog on virtual domains

https://gerrit.wikimedia.org/r/1081258

The original problem is solved, so we can probably close this task.