| KSiebert | |
| Oct 17 2024, 1:36 PM |
| F58421210: image.png | |
| Feb 19 2025, 7:16 AM |
This is part of T377186: [STORY] New widget to search and favourite templates.
To the search results dropdown, add a favourite icon beside each result — results with a page_id in the favourites array will have the favourite icon in the "selected" state, results that are not will be in the "unselected" state
Clicking on an icon to favourite/unfavourite is not in scope for this ticket. That is done in T387187: Add functionality to favourite icon in search results.
Design (from Figma):
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Template Discovery: Add favourite icon to search results | mediawiki/extensions/TemplateData | master | +39 -4 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| In Progress | None | T367428 [EPIC] Favoriting Templates | |||
| In Progress | None | T377186 [STORY] New widget to search and favourite templates | |||
| Resolved | Samwilson | T377455 Add favourite icon to search results |
I've split out the user preferences handling, so am reducing the points of this task.
@JSengupta-WMF Should the favourite icon be a button (without border and any hover effect)?
It seems like keyboard navigation might be complicated here as well. We can arrow down the search result link and hit enter to select the highlighted item — but how should we handle tabbing to get to the favourite/unfavourite button?
Change #1122481 had a related patch set uploaded (by Samwilson; author: Samwilson):
[mediawiki/extensions/TemplateData@master] Template Discovery: Add favourite icon to search results
Yes favorite button is a quiet normal button. I guess in OOUI it will be called a button without border. Does the hover effect create any additional problem with keyboard navigation? If not then the hover state should be preserved.
Change #1122481 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] Template Discovery: Add favourite icon to search results