Page MenuHomePhabricator
Create Task
Maniphest T377466

Show bubble notification after adding favourite
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

After successfully calling api.php?action=options to add a favourite to user preferences, show a notification in the frontend that saving has been successful.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
FavouritesStore: Add notification on favourite changemediawiki/extensions/TemplateDatamaster+41 -9
Customize query in gerrit

Related Objects
Search...

Event Timeline

KSiebert created this task.Oct 17 2024, 2:44 PM
KSiebert mentioned this in T377186: [STORY] New widget to search and favourite templates.
Samwilson moved this task from New & TBD Tickets to Allow users to favorite a template on the Template-Discovery-And-Recall board.Oct 21 2024, 7:41 AM
Samwilson edited projects, added Template-Discovery-And-Recall (Allow users to favorite a template); removed Template-Discovery-And-Recall.
Cparle mentioned this in T377940: [STORY] Add template to favourites.Oct 23 2024, 11:59 AM
Cparle mentioned this in T377949: Handle error when saving favourite templates.Oct 23 2024, 1:17 PM
Cparle renamed this task from Show bubble notification after saving favourite to Show bubble notification after adding favourite.Oct 23 2024, 3:49 PM
Cparle updated the task description. (Show Details)
Cparle updated the task description. (Show Details)
KSiebert edited projects, added Community-Tech (Fox Squad); removed Community-Tech.Feb 28 2025, 3:13 PM
TheresNoTime claimed this task.Mar 3 2025, 11:26 AM
gerritbot added a comment.Mar 3 2025, 12:02 PM

Change #1124078 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/extensions/TemplateData@master] FavouritesStore: Add notification on favourite change

https://gerrit.wikimedia.org/r/1124078

gerritbot added a project: Patch-For-Review.Mar 3 2025, 12:02 PM
TheresNoTime moved this task from Ready for Dev to In Development on the Community-Tech (Fox Squad) board.Mar 3 2025, 12:03 PM
TheresNoTime moved this task from In Development to Feedback and Review on the Community-Tech (Fox Squad) board.Mar 3 2025, 1:47 PM
TheresNoTime set the point value for this task to 3.Mar 3 2025, 3:32 PM
gerritbot added a comment.Mar 5 2025, 12:04 AM

Change #1124078 merged by jenkins-bot:

[mediawiki/extensions/TemplateData@master] FavouritesStore: Add notification on favourite change

https://gerrit.wikimedia.org/r/1124078

Maintenance_bot removed a project: Patch-For-Review.Mar 5 2025, 12:30 AM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.20; 2025-03-11).Mar 5 2025, 1:00 AM
TheresNoTime moved this task from Feedback and Review to QA on the Community-Tech (Fox Squad) board.Mar 5 2025, 9:57 AM
TheresNoTime set Final Story Points to 3.Mar 6 2025, 10:25 AM
TheresNoTime mentioned this in T377972: Show bubble notification after removing favourite.Mar 6 2025, 10:59 AM
KSiebert changed the task status from Open to Stalled.Mar 27 2025, 10:38 AM
dom_walden closed this task as Resolved.Apr 24 2025, 9:55 AM
dom_walden subscribed.

I have tested this on each skin on beta on VisualEditor and WikiEditor on Chromium. I raised T392562 for MonoBook.

I tested on Firefox on Vector 2022 in an RTL language on VE and WE.

Note that the OOUI notification does not have a11y attributes as mentioned in T381036#10748152.

Test environment: https://en.wikipedia.beta.wmflabs.org TemplateData 0.2.0 (8bb5fb2) 07:29, 22 April 2025.

dom_walden mentioned this in T377460: Notify user if they try to favourite a template when they already have the max number of favourites.Apr 24 2025, 9:55 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits