Page MenuHomePhabricator

PHP Notice: Trying to get property 'href' of non-object
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error
labels.normalized_message
[{reqId}] {exception_url}   PHP Notice: Trying to get property 'href' of non-object
FrameLocationCall
from/srv/mediawiki/php-1.43.0-wmf.27/vendor/wikimedia/parsoid/src/Utils/ComputeSelectiveStats.php(142)
#0/srv/mediawiki/php-1.43.0-wmf.27/vendor/wikimedia/parsoid/src/Utils/ComputeSelectiveStats.php(142)MWExceptionHandler::handleError(int, string, string, int, array)
#1[internal function]Wikimedia\Parsoid\Utils\ComputeSelectiveStats::Wikimedia\Parsoid\Utils\{closure}(Wikimedia\Parsoid\DOM\Element, Wikimedia\Parsoid\Utils\DTState)
#2/srv/mediawiki/php-1.43.0-wmf.27/vendor/wikimedia/parsoid/src/Utils/DOMTraverser.php(111)call_user_func(Closure, Wikimedia\Parsoid\DOM\Element, Wikimedia\Parsoid\Utils\DTState)
#3/srv/mediawiki/php-1.43.0-wmf.27/vendor/wikimedia/parsoid/src/Utils/DOMTraverser.php(189)Wikimedia\Parsoid\Utils\DOMTraverser->callHandlers(Wikimedia\Parsoid\DOM\Element, null, Wikimedia\Parsoid\Utils\DTState)
#4/srv/mediawiki/php-1.43.0-wmf.27/vendor/wikimedia/parsoid/src/Utils/DOMTraverser.php(204)Wikimedia\Parsoid\Utils\DOMTraverser->traverseInternal(bool, null, Wikimedia\Parsoid\DOM\Element, Wikimedia\Parsoid\Utils\DTState)
#5/srv/mediawiki/php-1.43.0-wmf.27/vendor/wikimedia/parsoid/src/Utils/DOMTraverser.php(204)Wikimedia\Parsoid\Utils\DOMTraverser->traverseInternal(bool, null, Wikimedia\Parsoid\DOM\Element, Wikimedia\Parsoid\Utils\DTState)
#6/srv/mediawiki/php-1.43.0-wmf.27/vendor/wikimedia/parsoid/src/Utils/DOMTraverser.php(204)Wikimedia\Parsoid\Utils\DOMTraverser->traverseInternal(bool, null, Wikimedia\Parsoid\DOM\Element, Wikimedia\Parsoid\Utils\DTState)
#7/srv/mediawiki/php-1.43.0-wmf.27/vendor/wikimedia/parsoid/src/Utils/DOMTraverser.php(204)Wikimedia\Parsoid\Utils\DOMTraverser->traverseInternal(bool, null, Wikimedia\Parsoid\DOM\Element, Wikimedia\Parsoid\Utils\DTState)
#8/srv/mediawiki/php-1.43.0-wmf.27/vendor/wikimedia/parsoid/src/Utils/DOMTraverser.php(204)Wikimedia\Parsoid\Utils\DOMTraverser->traverseInternal(bool, null, Wikimedia\Parsoid\DOM\Element, Wikimedia\Parsoid\Utils\DTState)
#9/srv/mediawiki/php-1.43.0-wmf.27/vendor/wikimedia/parsoid/src/Utils/DOMTraverser.php(204)Wikimedia\Parsoid\Utils\DOMTraverser->traverseInternal(bool, null, Wikimedia\Parsoid\DOM\Element, Wikimedia\Parsoid\Utils\DTState)
#10/srv/mediawiki/php-1.43.0-wmf.27/vendor/wikimedia/parsoid/src/Utils/DOMTraverser.php(145)Wikimedia\Parsoid\Utils\DOMTraverser->traverseInternal(bool, null, Wikimedia\Parsoid\DOM\Element, Wikimedia\Parsoid\Utils\DTState)
#11/srv/mediawiki/php-1.43.0-wmf.27/vendor/wikimedia/parsoid/src/Utils/ComputeSelectiveStats.php(152)Wikimedia\Parsoid\Utils\DOMTraverser->traverse(null, Wikimedia\Parsoid\DOM\Element, Wikimedia\Parsoid\Utils\DTState)
#12/srv/mediawiki/php-1.43.0-wmf.27/vendor/wikimedia/parsoid/src/Parsoid.php(393)Wikimedia\Parsoid\Utils\ComputeSelectiveStats::classify(Wikimedia\Parsoid\Config\Env, MediaWiki\Parser\Parsoid\Config\PageConfig, Wikimedia\Parsoid\Core\PageBundle, MediaWiki\Parser\Parsoid\Config\PageConfig, Wikimedia\Parsoid\Core\PageBundle)
#13/srv/mediawiki/php-1.43.0-wmf.27/vendor/wikimedia/parsoid/src/Parsoid.php(284)Wikimedia\Parsoid\Parsoid->recordParseMetrics(Wikimedia\Parsoid\Config\Env, float, array, array, string, array)
#14/srv/mediawiki/php-1.43.0-wmf.27/includes/parser/Parsoid/ParsoidParser.php(162)Wikimedia\Parsoid\Parsoid->wikitext2html(MediaWiki\Parser\Parsoid\Config\PageConfig, array, array, MediaWiki\Parser\ParserOutput)
#15/srv/mediawiki/php-1.43.0-wmf.27/includes/parser/Parsoid/ParsoidParser.php(283)MediaWiki\Parser\Parsoid\ParsoidParser->genParserOutput(MediaWiki\Parser\Parsoid\Config\PageConfig, ParserOptions, MediaWiki\Parser\ParserOutput)
#16/srv/mediawiki/php-1.43.0-wmf.27/includes/content/WikitextContentHandler.php(384)MediaWiki\Parser\Parsoid\ParsoidParser->parse(string, MediaWiki\Title\Title, ParserOptions, bool, bool, int, MediaWiki\Parser\ParserOutput)
#17/srv/mediawiki/php-1.43.0-wmf.27/includes/content/ContentHandler.php(1693)MediaWiki\Content\WikitextContentHandler->fillParserOutput(MediaWiki\Content\WikitextContent, MediaWiki\Content\Renderer\ContentParseParams, MediaWiki\Parser\ParserOutput)
#18/srv/mediawiki/php-1.43.0-wmf.27/includes/content/Renderer/ContentRenderer.php(79)MediaWiki\Content\ContentHandler->getParserOutput(MediaWiki\Content\WikitextContent, MediaWiki\Content\Renderer\ContentParseParams)
#19/srv/mediawiki/php-1.43.0-wmf.27/includes/Revision/RenderedRevision.php(264)MediaWiki\Content\Renderer\ContentRenderer->getParserOutput(MediaWiki\Content\WikitextContent, MediaWiki\Title\Title, MediaWiki\Revision\RevisionStoreRecord, ParserOptions, array)
#20/srv/mediawiki/php-1.43.0-wmf.27/includes/Revision/RenderedRevision.php(236)MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached(MediaWiki\Content\WikitextContent, array)
#21/srv/mediawiki/php-1.43.0-wmf.27/includes/Revision/RevisionRenderer.php(239)MediaWiki\Revision\RenderedRevision->getSlotParserOutput(string, array)
#22/srv/mediawiki/php-1.43.0-wmf.27/includes/Revision/RevisionRenderer.php(172)MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, ParserOptions, array)
#23[internal function]MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}(MediaWiki\Revision\RenderedRevision, array)
#24/srv/mediawiki/php-1.43.0-wmf.27/includes/Revision/RenderedRevision.php(199)call_user_func(Closure, MediaWiki\Revision\RenderedRevision, array)
#25/srv/mediawiki/php-1.43.0-wmf.27/includes/page/ParserOutputAccess.php(454)MediaWiki\Revision\RenderedRevision->getRevisionParserOutput()
#26/srv/mediawiki/php-1.43.0-wmf.27/includes/page/ParserOutputAccess.php(366)MediaWiki\Page\ParserOutputAccess->renderRevision(MediaWiki\Page\PageStoreRecord, ParserOptions, MediaWiki\Revision\RevisionStoreRecord, int, MediaWiki\Parser\ParserOutput)
#27/srv/mediawiki/php-1.43.0-wmf.27/includes/Rest/Handler/Helper/HtmlOutputRendererHelper.php(900)MediaWiki\Page\ParserOutputAccess->getParserOutput(MediaWiki\Page\PageStoreRecord, ParserOptions, MediaWiki\Revision\RevisionStoreRecord, int)
#28/srv/mediawiki/php-1.43.0-wmf.27/includes/Rest/Handler/Helper/HtmlOutputRendererHelper.php(641)MediaWiki\Rest\Handler\Helper\HtmlOutputRendererHelper->getParserOutputInternal(ParserOptions)
#29/srv/mediawiki/php-1.43.0-wmf.27/includes/Rest/Handler/Helper/HtmlOutputRendererHelper.php(561)MediaWiki\Rest\Handler\Helper\HtmlOutputRendererHelper->getParserOutput()
#30/srv/mediawiki/php-1.43.0-wmf.27/includes/Rest/Handler/RevisionHTMLHandler.php(111)MediaWiki\Rest\Handler\Helper\HtmlOutputRendererHelper->getETag(string)
#31/srv/mediawiki/php-1.43.0-wmf.27/includes/Rest/Handler.php(479)MediaWiki\Rest\Handler\RevisionHTMLHandler->getETag()
#32/srv/mediawiki/php-1.43.0-wmf.27/includes/Rest/Handler.php(496)MediaWiki\Rest\Handler->getConditionalHeaderUtil()
#33/srv/mediawiki/php-1.43.0-wmf.27/includes/Rest/Module/Module.php(380)MediaWiki\Rest\Handler->checkPreconditions()
#34/srv/mediawiki/php-1.43.0-wmf.27/includes/Rest/Module/Module.php(269)MediaWiki\Rest\Module\Module->executeHandler(MediaWiki\Rest\Handler\RevisionHTMLHandler)
#35/srv/mediawiki/php-1.43.0-wmf.27/includes/Rest/Router.php(487)MediaWiki\Rest\Module\Module->execute(string, MediaWiki\Rest\RequestFromGlobals)
#36/srv/mediawiki/php-1.43.0-wmf.27/includes/Rest/Router.php(446)MediaWiki\Rest\Router->doExecute(string, MediaWiki\Rest\RequestFromGlobals)
#37/srv/mediawiki/php-1.43.0-wmf.27/includes/Rest/EntryPoint.php(211)MediaWiki\Rest\Router->execute(MediaWiki\Rest\RequestFromGlobals)
#38/srv/mediawiki/php-1.43.0-wmf.27/includes/MediaWikiEntryPoint.php(200)MediaWiki\Rest\EntryPoint->execute()
#39/srv/mediawiki/php-1.43.0-wmf.27/rest.php(39)MediaWiki\MediaWikiEntryPoint->run()
#40/srv/mediawiki/w/rest.php(3)require(string)
#41{main}
Impact
Notes

Started happening on 2024-10-17. Might be result of train T375658

Details

Request URL
https://www.wikidata.org/w/rest.php/v1/revision/2261381414/html

Event Timeline

Probably a side effect of the fix deployed for T377287: PHP Notice: Undefined property: Wikimedia\Parsoid\NodeData\DataMw::$parts.

Should be harmless, other than the logspam.

Actually, this should have been resolved by the fix deployed for T377287, and I don't see any new instances of this since that fix was backported.

cscott claimed this task.